ActivationEmail - Code Metrics - Inspection of "WIP: Proof of concept mail util refactor" - sunscrapers/djoser - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#227)

by Piotr

created 2017-09-22 10:34 UTC

ActivationEmail A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	10
Duplicated Lines	100 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
wmc	1
c	1
b	0
f	0
dl	10
loc	10
rs	10

1 Method

Rating	Name	Duplication	Size	Complexity
A	set_context_data()	7	7	1

How to fix Duplicated Code

from django.contrib.auth.tokens import default_token_generator
class SomeClass:
    def some_method(self):
        """Do x and return foo."""

from templated_mail.mail import BaseEmailMessage


from djoser import utils
from djoser.conf import settings


class ActivationEmail(BaseEmailMessage):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    template_name = 'email/activation.html'

    def set_context_data(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        super(ActivationEmail, self).set_context_data()

        user = self.context.get('user')
        self.context['uid'] = utils.encode_uid(user.pk)
        self.context['token'] = default_token_generator.make_token(user)
        self.context['url'] = settings.ACTIVATION_URL.format(**self.context)


class ConfirmationEmail(BaseEmailMessage):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    template_name = 'email/confirmation.html'


class PasswordResetEmail(BaseEmailMessage):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    template_name = 'email/password_reset.html'

    def set_context_data(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        super(PasswordResetEmail, self).set_context_data()

        user = self.context.get('user')
        self.context['uid'] = utils.encode_uid(user.pk)
        self.context['token'] = default_token_generator.make_token(user)
        self.context['url'] = settings.ACTIVATION_URL.format(**self.context)


1		from django.contrib.auth.tokens import default_token_generator
		0 ignored issues – show Coding Style introduced 2017-09-09 22:01 UTC by Report Bug Copy Issue Report This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... introduced 2017-08-24 11:14 UTC by Report Bug Copy Issue Report Unable to import 'django.contrib.auth.tokens' Loading history...
2
3		from templated_mail.mail import BaseEmailMessage
		0 ignored issues – show introduced 2017-09-15 17:07 UTC by Report Bug Copy Issue Report Unable to import 'templated_mail.mail' Loading history...
4
5		from djoser import utils
6		from djoser.conf import settings
7
8
9	View Code Duplication	class ActivationEmail(BaseEmailMessage):
		0 ignored issues – show Coding Style introduced 2017-09-15 17:07 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Duplication introduced 2017-09-15 17:07 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
10		template_name = 'email/activation.html'
11
12		def set_context_data(self):
		0 ignored issues – show Coding Style introduced 2017-09-15 17:07 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
13		super(ActivationEmail, self).set_context_data()
14
15		user = self.context.get('user')
16		self.context['uid'] = utils.encode_uid(user.pk)
17		self.context['token'] = default_token_generator.make_token(user)
18		self.context['url'] = settings.ACTIVATION_URL.format(**self.context)
19
20
21		class ConfirmationEmail(BaseEmailMessage):
		0 ignored issues – show Coding Style introduced 2017-09-15 17:07 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
22		template_name = 'email/confirmation.html'
23
24
25	View Code Duplication	class PasswordResetEmail(BaseEmailMessage):
		0 ignored issues – show Coding Style introduced 2017-09-15 17:07 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Duplication introduced 2017-09-15 17:07 UTC by Report Bug Copy Issue Report This code seems to be duplicated in your project. Loading history...
26		template_name = 'email/password_reset.html'
27
28		def set_context_data(self):
		0 ignored issues – show Coding Style introduced 2017-09-15 17:07 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
29		super(PasswordResetEmail, self).set_context_data()
30
31		user = self.context.get('user')
32		self.context['uid'] = utils.encode_uid(user.pk)
33		self.context['token'] = default_token_generator.make_token(user)
34		self.context['url'] = settings.ACTIVATION_URL.format(**self.context)
35

sunscrapers / djoser

Pull Request — master (#227)

ActivationEmail A

Complexity

Size/Duplication

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like