TestBaseEmailMessage - Code Metrics - Inspection of "Feature: pass context to mixins from BaseEmailMess..." - sunscrapers/django-templated-mail - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#3)

unknown

created 2018-01-23 19:48 UTC

TestBaseEmailMessage A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	203
Duplicated Lines	32.02 %

Importance

Changes	5
Bugs	0	Features	2

Metric	Value
wmc	14
c	5
b	0
f	2
dl	65
loc	203
rs	10

14 Methods

Rating	Name	Duplication	Size	Complexity
A	test_mail_cc_is_sent_to_valid_cc()	16	17	1
A	test_mail_bcc_is_sent_to_valid_bcc()	13	17	1
A	test_mail_from_email_is_sent_with_valid_from_email()	0	17	1
A	setUp()	0	3	1
A	test_html_mail_contains_valid_data()	13	14	1
A	test_can_send_mail_with_none_request()	3	11	1
A	test_extending_mail_with_context_mixin()	0	9	1
A	test_get_context_data_with_secure_request()	0	17	1
A	test_get_context_data_with_insecure_request()	0	17	1
A	test_get_context_data_without_request_no_context()	0	8	1
A	test_mail_reply_to_is_sent_with_valid_reply_to()	0	17	1
A	test_text_and_html_mail_contains_valid_data()	13	17	1
A	test_get_context_data_without_request_user_context()	0	11	1
A	test_text_mail_contains_valid_data()	3	14	1

How to fix Duplicated Code

try:
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    from unittest import mock
except ImportError:
    import mock

from django.contrib.auth.models import AnonymousUser
from django.contrib.sites.shortcuts import get_current_site
from django.core import mail
from django.test import RequestFactory, TestCase
from templated_mail.mail import BaseEmailMessage

from .helpers import MockMail


class TestBaseEmailMessage(TestCase):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
    def setUp(self):
        self.factory = RequestFactory()
        self.recipients = ['[email protected]']

    @mock.patch('django.core.handlers.wsgi.WSGIRequest.is_secure')
    def test_get_context_data_with_insecure_request(self, is_secure_mock):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        is_secure_mock.return_value = False

        request = self.factory.get('/')
        request.user = AnonymousUser()

        email_message = BaseEmailMessage(
            request=request, template_name='text_mail.html'
        )
        context = email_message.get_context_data()
        site = get_current_site(request)

        self.assertEquals(context['domain'], site.domain)

        self.assertEquals(context['protocol'], 'http')

        self.assertEquals(context['site_name'], site.name)

        self.assertEquals(context['user'], request.user)


    @mock.patch('django.core.handlers.wsgi.WSGIRequest.is_secure')
    def test_get_context_data_with_secure_request(self, is_secure_mock):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        is_secure_mock.return_value = True

        request = self.factory.get('/')
        request.user = AnonymousUser()

        email_message = BaseEmailMessage(
            request=request, template_name='text_mail.html'
        )
        context = email_message.get_context_data()
        site = get_current_site(request)

        self.assertEquals(context['domain'], site.domain)

        self.assertEquals(context['protocol'], 'https')

        self.assertEquals(context['site_name'], site.name)

        self.assertEquals(context['user'], request.user)


    def test_get_context_data_without_request_no_context(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        email_message = BaseEmailMessage(template_name='text_mail.html')
        context = email_message.get_context_data()

        self.assertEquals(context['domain'], '')

        self.assertEquals(context['protocol'], 'http')

        self.assertEquals(context['site_name'], '')

        self.assertEquals(context['user'], None)


    def test_get_context_data_without_request_user_context(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        user = AnonymousUser()
        email_message = BaseEmailMessage(
            context={'user': user}, template_name='text_mail.html'
        )
        context = email_message.get_context_data()

        self.assertEquals(context['domain'], '')

        self.assertEquals(context['protocol'], 'http')

        self.assertEquals(context['site_name'], '')

        self.assertEquals(context['user'], user)


    def test_text_mail_contains_valid_data(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        request = self.factory.get('/')
        request.user = AnonymousUser()

        BaseEmailMessage(
            request=request, template_name='text_mail.html'
        ).send(to=self.recipients)

        self.assertEqual(len(mail.outbox), 1)
        self.assertEqual(mail.outbox[0].recipients(), self.recipients)
        self.assertEqual(mail.outbox[0].subject, 'Text mail subject')
        self.assertEqual(mail.outbox[0].body, 'Foobar email content')

        self.assertEqual(mail.outbox[0].alternatives, [])
        self.assertEqual(mail.outbox[0].content_subtype, 'plain')

    def test_html_mail_contains_valid_data(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        request = self.factory.get('/')
        request.user = AnonymousUser()

        BaseEmailMessage(
            request=request, template_name='html_mail.html'
        ).send(to=self.recipients)

        self.assertEqual(len(mail.outbox), 1)
        self.assertEqual(mail.outbox[0].recipients(), self.recipients)
        self.assertEqual(mail.outbox[0].subject, 'HTML mail subject')
        self.assertEqual(mail.outbox[0].body, '<p>Foobar email content</p>')

        self.assertEqual(mail.outbox[0].alternatives, [])
        self.assertEqual(mail.outbox[0].content_subtype, 'html')

    def test_text_and_html_mail_contains_valid_data(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        request = self.factory.get('/')
        request.user = AnonymousUser()

        BaseEmailMessage(
            request=request, template_name='text_and_html_mail.html'
        ).send(to=self.recipients)

        self.assertEqual(len(mail.outbox), 1)
        self.assertEqual(mail.outbox[0].recipients(), self.recipients)
        self.assertEqual(mail.outbox[0].subject, 'Text and HTML mail subject')
        self.assertEqual(mail.outbox[0].body, 'Foobar email content')
        self.assertEqual(
            mail.outbox[0].alternatives,
            [('<p>Foobar email content</p>', 'text/html')]
        )
        self.assertEqual(mail.outbox[0].content_subtype, 'plain')

    def test_can_send_mail_with_none_request(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        BaseEmailMessage(
            request=None, template_name='text_mail.html'
        ).send(to=self.recipients)

        self.assertEqual(len(mail.outbox), 1)
        self.assertEqual(mail.outbox[0].recipients(), self.recipients)
        self.assertEqual(mail.outbox[0].subject, 'Text mail subject')
        self.assertEqual(mail.outbox[0].body, 'Foobar email content')

        self.assertEqual(mail.outbox[0].alternatives, [])
        self.assertEqual(mail.outbox[0].content_subtype, 'plain')

    def test_mail_cc_is_sent_to_valid_cc(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        request = self.factory.get('/')
        request.user = AnonymousUser()

        cc = ['[email protected]']


        BaseEmailMessage(
            request=request, template_name='text_mail.html'
        ).send(to=self.recipients, cc=cc)

        self.assertEqual(len(mail.outbox), 1)
        self.assertEqual(mail.outbox[0].to, self.recipients)
        self.assertEqual(mail.outbox[0].cc, cc)
        self.assertEqual(mail.outbox[0].subject, 'Text mail subject')
        self.assertEqual(mail.outbox[0].body, 'Foobar email content')

        self.assertEqual(mail.outbox[0].alternatives, [])
        self.assertEqual(mail.outbox[0].content_subtype, 'plain')

    def test_mail_bcc_is_sent_to_valid_bcc(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        request = self.factory.get('/')
        request.user = AnonymousUser()

        bcc = ['[email protected]']

        BaseEmailMessage(
            request=request, template_name='text_mail.html'
        ).send(to=self.recipients, bcc=bcc)

        self.assertEqual(len(mail.outbox), 1)
        self.assertEqual(mail.outbox[0].to, self.recipients)
        self.assertEqual(mail.outbox[0].bcc, bcc)
        self.assertEqual(mail.outbox[0].subject, 'Text mail subject')
        self.assertEqual(mail.outbox[0].body, 'Foobar email content')
        self.assertEqual(mail.outbox[0].alternatives, [])
        self.assertEqual(mail.outbox[0].content_subtype, 'plain')

    def test_mail_reply_to_is_sent_with_valid_reply_to(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        request = self.factory.get('/')
        request.user = AnonymousUser()

        reply_to = ['[email protected]']

        BaseEmailMessage(
            request=request, template_name='text_mail.html'
        ).send(to=self.recipients, reply_to=reply_to)

        self.assertEqual(len(mail.outbox), 1)
        self.assertEqual(mail.outbox[0].to, self.recipients)
        self.assertEqual(mail.outbox[0].reply_to, reply_to)
        self.assertEqual(mail.outbox[0].subject, 'Text mail subject')
        self.assertEqual(mail.outbox[0].body, 'Foobar email content')
        self.assertEqual(mail.outbox[0].alternatives, [])
        self.assertEqual(mail.outbox[0].content_subtype, 'plain')

    def test_mail_from_email_is_sent_with_valid_from_email(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        request = self.factory.get('/')
        request.user = AnonymousUser()

        from_email = '<Example - [email protected]>'

        BaseEmailMessage(
            request=request, template_name='text_mail.html'
        ).send(to=self.recipients, from_email=from_email)

        self.assertEqual(len(mail.outbox), 1)
        self.assertEqual(mail.outbox[0].to, self.recipients)
        self.assertEqual(mail.outbox[0].from_email, from_email)
        self.assertEqual(mail.outbox[0].subject, 'Text mail subject')
        self.assertEqual(mail.outbox[0].body, 'Foobar email content')
        self.assertEqual(mail.outbox[0].alternatives, [])
        self.assertEqual(mail.outbox[0].content_subtype, 'plain')

    def test_extending_mail_with_context_mixin(self):
class SomeClass:
    def some_method(self):
        """Do x and return foo."""
        email_message = MockMail(
            template_name='text_mail.html', context={'foo': 'bar'}
        )

        context = email_message.get_context_data()

        self.assertEquals(context['foo'], 'bar')

        self.assertEquals(context['thing'], 42)



1			try:
			0 ignored issues – show Coding Style introduced 2017-10-06 18:57 UTC by Report Bug Copy Issue Report This module should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
2			from unittest import mock
3			except ImportError:
4			import mock
5
6			from django.contrib.auth.models import AnonymousUser
7			from django.contrib.sites.shortcuts import get_current_site
8			from django.core import mail
9			from django.test import RequestFactory, TestCase
10			from templated_mail.mail import BaseEmailMessage
11
12			from .helpers import MockMail
13
14
15			class TestBaseEmailMessage(TestCase):
			0 ignored issues – show Coding Style introduced 2017-09-15 13:06 UTC by Report Bug Copy Issue Report This class should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history... Unused Code introduced 2018-01-04 22:33 UTC by Report Bug Copy Issue Report The variable `__class__` seems to be unused. Loading history...
16			def setUp(self):
17			self.factory = RequestFactory()
18			self.recipients = ['[email protected]']
19
20			@mock.patch('django.core.handlers.wsgi.WSGIRequest.is_secure')
21			def test_get_context_data_with_insecure_request(self, is_secure_mock):
			0 ignored issues – show Coding Style Naming introduced 2017-10-06 14:34 UTC by Report Bug Copy Issue Report The name `test_get_context_data_with_insecure_request` does not conform to the method naming conventions (`(([a-z][a-z0-9_]{2,30})\|(_[a-z0-9_]*))$`). This check looks for invalid names for a range of different identifiers. You can set regular expressions to which the identifiers must conform if the defaults do not match your requirements. If your project includes a Pylint configuration file, the settings contained in that file take precedence. To find out more about Pylint, please refer to their site. Loading history... Coding Style introduced 2017-10-06 14:34 UTC by Report Bug Copy Issue Report This method should have a docstring. The coding style of this project requires that you add a docstring to this code element. Below, you find an example for methods: class SomeClass: def some_method(self): """Do x and return foo.""" If you would like to know more about docstrings, we recommend to read PEP-257: Docstring Conventions. Loading history...
22			is_secure_mock.return_value = False
23
24			request = self.factory.get('/')
25			request.user = AnonymousUser()
26
27			email_message = BaseEmailMessage(
28			request=request, template_name='text_mail.html'
29			)
30			context = email_message.get_context_data()
31			site = get_current_site(request)
32
33			self.assertEquals(context['domain'], site.domain)
			0 ignored issues – show introduced 2017-10-07 07:34 UTC by Report Bug Copy Issue Report Using deprecated method assertEquals() Loading history...
34			self.assertEquals(context['protocol'], 'http')
			0 ignored issues – show introduced 2017-10-07 07:34 UTC by Report Bug Copy Issue Report Using deprecated method assertEquals() Loading history...
35			self.assertEquals(context['site_name'], site.name)

sunscrapers / django-templated-mail

Pull Request — master (#3)

TestBaseEmailMessage A

Complexity

Size/Duplication

Importance

14 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like