UploadedFile::moveTo() - Code Metrics - Inspection of "v3.0.0" - sunrise-php/http-message - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Pull Request — master (#27)

by Anatoly
created 2022-12-29 03:23 UTC
UploadedFile::moveTo() B

↳ Parent: UploadedFile
Complexity

Conditions	11
Paths	16
Size

Total Lines	53
Code Lines	30
Duplication

Lines	0
Ratio	0 %
Code Coverage

Tests	35
CRAP Score	11
Importance

Changes	1
Bugs	0	Features	0
Metric	Value
cc	11
eloc	30
c	1
b	0
f	0
nc	16
nop	1
dl	0
loc	53
ccs	35
cts	35
cp	1
crap	11
rs	7.3166
How to fix Long Method Complexity

<?php declare(strict_types=1);

/**
 * It's free open-source software released under the MIT License.
 *
 * @author Anatoly Nekhay <[email protected]>
 * @copyright Copyright (c) 2018, Anatoly Nekhay
 * @license https://github.com/sunrise-php/http-message/blob/master/LICENSE
 * @link https://github.com/sunrise-php/http-message
 */

namespace Sunrise\Http\Message;

/**
 * Import classes
 */
use Psr\Http\Message\StreamInterface;
use Psr\Http\Message\UploadedFileInterface;
use Sunrise\Http\Message\Exception\FailedUploadedFileOperationException;
use Sunrise\Http\Message\Exception\InvalidUploadedFileException;
use Sunrise\Http\Message\Exception\InvalidUploadedFileOperationException;
use Sunrise\Http\Message\Stream\FileStream;

/**
 * Import functions
 */
use function dirname;
use function is_dir;
use function is_file;
use function is_writable;
use function sprintf;
use function unlink;

/**
 * Import constants
 */
use const UPLOAD_ERR_OK;
use const UPLOAD_ERR_INI_SIZE;
use const UPLOAD_ERR_FORM_SIZE;
use const UPLOAD_ERR_PARTIAL;
use const UPLOAD_ERR_NO_FILE;
use const UPLOAD_ERR_NO_TMP_DIR;
use const UPLOAD_ERR_CANT_WRITE;
use const UPLOAD_ERR_EXTENSION;

/**
 * UploadedFile
 *
 * @link https://www.php-fig.org/psr/psr-7/
 */
class UploadedFile implements UploadedFileInterface
{

    /**
     * List of upload errors
     *
     * @link https://www.php.net/manual/en/features.file-upload.errors.php
     *
     * @var array<int, string>
     */
    public const UPLOAD_ERRORS = [
        UPLOAD_ERR_OK         => 'No error',
        UPLOAD_ERR_INI_SIZE   => 'The uploaded file exceeds the upload_max_filesize directive in php.ini',
        UPLOAD_ERR_FORM_SIZE  => 'The uploaded file exceeds the MAX_FILE_SIZE directive ' .
                                 'that was specified in the HTML form',
        UPLOAD_ERR_PARTIAL    => 'The uploaded file was only partially uploaded',
        UPLOAD_ERR_NO_FILE    => 'No file was uploaded',
        UPLOAD_ERR_NO_TMP_DIR => 'Missing a temporary folder',
        UPLOAD_ERR_CANT_WRITE => 'Failed to write file to disk',
        UPLOAD_ERR_EXTENSION  => 'File upload stopped by extension',
    ];

    /**
     * Unknown error description
     *
     * @var string
     */
    public const UNKNOWN_ERROR_TEXT = 'Unknown error';

    /**
     * The file stream
     *
     * @var StreamInterface|null
     */
    private ?StreamInterface $stream = null;

    /**
     * The file size
     *
     * @var int|null
     */
    private ?int $size;

    /**
     * The file's error code
     *
     * @var int
     */
    private int $errorCode;

    /**
     * The file's error message
     *
     * @var string
     */
    private string $errorMessage;

    /**
     * The file name
     *
     * @var string|null
     */
    private ?string $clientFilename;

    /**
     * The file type
     *
     * @var string|null
     */
    private ?string $clientMediaType;

    /**
     * Constructor of the class
     *
     * @param StreamInterface $stream
     * @param int|null $size
     * @param int $error
     * @param string|null $clientFilename
     * @param string|null $clientMediaType
     */
    public function __construct(
        StreamInterface $stream,
        ?int $size = null,
        int $error = UPLOAD_ERR_OK,
        ?string $clientFilename = null,
        ?string $clientMediaType = null
    ) {
        if (UPLOAD_ERR_OK === $error) {
            $this->stream = $stream;
        }

        $errorMessage = self::UPLOAD_ERRORS[$error] ?? self::UNKNOWN_ERROR_TEXT;

        $this->size = $size;
        $this->errorCode = $error;
        $this->errorMessage = $errorMessage;
        $this->clientFilename = $clientFilename;
        $this->clientMediaType = $clientMediaType;
    }

    /**
     * Gets the file stream
     *
     * @return StreamInterface
     *
     * @throws InvalidUploadedFileException
     *         If the file has no a stream due to an error or
     *         if the file was already moved.
     */
    public function getStream(): StreamInterface
    {
        if (UPLOAD_ERR_OK <> $this->errorCode) {
            throw new InvalidUploadedFileException(sprintf(
                'The uploaded file has no a stream due to the error #%d (%s)',
                $this->errorCode,
                $this->errorMessage
            ));
        }

        if (!isset($this->stream)) {
            throw new InvalidUploadedFileException(
                'The uploaded file has no a stream because it was already moved'
            );
        }

        return $this->stream;

    }

    /**
     * Moves the file to the given path
     *
     * @param string $targetPath
     *
     * @return void
     *
     * @throws InvalidUploadedFileException
     *         If the file has no a stream due to an error or
     *         if the file was already moved.
     *
     * @throws InvalidUploadedFileOperationException
     *         If the file cannot be read.
     *
     * @throws FailedUploadedFileOperationException
     *         If the target path cannot be used.
     */
    public function moveTo($targetPath): void
    {
        if (UPLOAD_ERR_OK <> $this->errorCode) {
            throw new InvalidUploadedFileException(sprintf(
                'The uploaded file cannot be moved due to the error #%d (%s)',
                $this->errorCode,
                $this->errorMessage
            ));
        }

        if (!isset($this->stream)) {
            throw new InvalidUploadedFileException(
                'The uploaded file cannot be moved because it was already moved'
            );
        }

        if (!$this->stream->isReadable()) {
        if (!$this->stream->/** @scrutinizer ignore-call */ isReadable()) {
            throw new InvalidUploadedFileOperationException(
                'The uploaded file cannot be moved because it is not readable'
            );
        }

        $targetDir = dirname($targetPath);
        if (!is_dir($targetDir) || !is_writable($targetDir)) {
            throw new FailedUploadedFileOperationException(sprintf(
                'The uploaded file cannot be moved because the directory "%s" is not writable',
                $targetDir
            ));
        }

        $targetStream = new FileStream($targetPath, 'wb');

        if ($this->stream->isSeekable()) {
            $this->stream->rewind();
        }

        while (!$this->stream->eof()) {
            $piece = $this->stream->read(4096);
            $targetStream->write($piece);
        }

        $targetStream->close();

        /** @var string|null */
        $sourcePath = $this->stream->getMetadata('uri');

        $this->stream->close();
        $this->stream = null;

        if (isset($sourcePath) && is_file($sourcePath)) {
        if (isset($sourcePath) && is_file(/** @scrutinizer ignore-type */ $sourcePath)) {
            $sourceDir = dirname($sourcePath);
            $sourceDir = dirname(/** @scrutinizer ignore-type */ $sourcePath);
            if (is_writable($sourceDir)) {
                unlink($sourcePath);
                unlink(/** @scrutinizer ignore-type */ $sourcePath);
            }
        }
    }

    /**
     * Gets the file size
     *
     * @return int|null
     */
    public function getSize(): ?int
    {
        return $this->size;
    }

    /**
     * Gets the file's error code
     *
     * @return int
     */
    public function getError(): int
    {
        return $this->errorCode;
    }

    /**
     * Gets the file name
     *
     * @return string|null
     */
    public function getClientFilename(): ?string
    {
        return $this->clientFilename;
    }

    /**
     * Gets the file type
     *
     * @return string|null
     */
    public function getClientMediaType(): ?string
    {
        return $this->clientMediaType;
    }
}

sunrise-php / http-message

Pull Request — master (#27)

UploadedFile::moveTo() B

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like
