Conditions | 8 |
Paths | 128 |
Total Lines | 59 |
Code Lines | 38 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php declare(strict_types=1); |
||
80 | private function createSettings(array $params) : Settings |
||
81 | { |
||
82 | $settings = new Settings(); |
||
83 | |||
84 | // the object initialization... |
||
85 | $settings->setAllowedOrigins([]); |
||
86 | $settings->setAllowedMethods([]); |
||
87 | $settings->setAllowedHeaders([]); |
||
88 | $settings->setExposedHeaders([]); |
||
89 | |||
90 | $settings->setServerOrigin( |
||
91 | (string) $params['server_origin_scheme'], |
||
92 | (string) $params['server_origin_host'], |
||
93 | (int) $params['server_origin_port'] |
||
94 | ); |
||
95 | |||
96 | $settings->setPreFlightCacheMaxAge( |
||
97 | (int) $params['pre_flight_cache_max_age'] |
||
98 | ); |
||
99 | |||
100 | $params['force_add_methods'] ? |
||
101 | $settings->enableAddAllowedMethodsToPreFlightResponse() : |
||
102 | $settings->disableAddAllowedMethodsToPreFlightResponse(); |
||
103 | |||
104 | $params['force_add_headers'] ? |
||
105 | $settings->enableAddAllowedHeadersToPreFlightResponse() : |
||
106 | $settings->disableAddAllowedHeadersToPreFlightResponse(); |
||
107 | |||
108 | $params['use_credentials'] ? |
||
109 | $settings->setCredentialsSupported() : |
||
110 | $settings->setCredentialsNotSupported(); |
||
111 | |||
112 | $params['all_origins_allowed'] ? |
||
113 | $settings->enableAllOriginsAllowed() : |
||
114 | $settings->setAllowedOrigins( |
||
115 | (array) $params['allowed_origins'] |
||
116 | ); |
||
117 | |||
118 | $params['all_methods_allowed'] ? |
||
119 | $settings->enableAllMethodsAllowed() : |
||
120 | $settings->setAllowedMethods( |
||
121 | (array) $params['allowed_methods'] |
||
122 | ); |
||
123 | |||
124 | $params['all_headers_allowed'] ? |
||
125 | $settings->enableAllHeadersAllowed() : |
||
126 | $settings->setAllowedHeaders( |
||
127 | (array) $params['allowed_headers'] |
||
128 | ); |
||
129 | |||
130 | $settings->setExposedHeaders( |
||
131 | (array) $params['exposed_headers'] |
||
132 | ); |
||
133 | |||
134 | $params['check_host'] ? |
||
135 | $settings->enableCheckHost() : |
||
136 | $settings->disableCheckHost(); |
||
137 | |||
138 | return $settings; |
||
139 | } |
||
156 |