CurrencyConverterPage_Controller::index() - Code Metrics - sunnysideup/silverstripe-widgets_currencyconverter - Measure and Improve Code Quality continuously with Scrutinizer

CurrencyConverterPage_Controller::index() A
last analyzed 2018-03-20 01:39 UTC

↳ Parent: CurrencyConverterPage_Controller

Complexity

Conditions	3
Paths	2

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	6
rs	9.4285
c	0
b	0
f	0
cc	3
eloc	3
nc	2
nop	0

<?php
/**
  * This page is the Currency Converter page
  *
  */
class CurrencyConverterPage extends Page
namespace YourVendor;

class YourClass { }
{
    private static $icon = "widgets_currencyconverter/images/treeicons/CurrencyConverterPage";


    private static $description = "This page is the Currency Converter page";

    
    private static $db = array(

        "IntroText" => "Varchar(250)"
    );

    private static $has_one = array(

        "MainContent" => "WidgetArea"
    );

    public function canCreate($member = null)
    {
        return SiteTree::get()->filter(array("ClassName" => "CurrencyConverterPage"))->count() ? false : true;
    }

    public function getCMSFields()

    {
        $fields = parent::getCMSFields();
        $fields->addFieldToTab("Root.Disclaimer", new TextField("IntroText", "Intro Text (can put disclaimer here)"));
        return $fields;
    }
}

class CurrencyConverterPage_Controller extends Page_Controller
namespace YourVendor;

class YourClass { }
{
    public function init()
    {
        parent::init();
        Requirements::javascript(THIRDPARTY_DIR."/jquery/jquery.js");
        Requirements::javascript("widgets_currencyconverter/javascript/CurrencyConverter.js");
        Requirements::css("widgets_currencyconverter/css/CurrencyConverter.css");
    }
    public function index()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (Director::is_ajax() || isset($_GET["ajax"])) {
            return $this->renderWith("CurrencyConverterAjax");
        }
    }
    public function CurrencyConverterWidget()

    {
        $widget = new CurrencyConverterWidget();
        return $widget->renderWith("WidgetHolderMysite");
    }
}


1			<?php
2			/**
3			* This page is the Currency Converter page
4			*
5			*/
6			class CurrencyConverterPage extends Page
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-10 01:04 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
7			{
8			private static $icon = "widgets_currencyconverter/images/treeicons/CurrencyConverterPage";
			0 ignored issues – show Unused Code introduced 2017-01-10 01:04 UTC by Report Bug Copy Issue Report The property `$icon` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
9
10			private static $description = "This page is the Currency Converter page";
			0 ignored issues – show Unused Code introduced 2017-01-10 01:04 UTC by Report Bug Copy Issue Report The property `$description` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
11
12			private static $db = array(
			0 ignored issues – show Unused Code introduced 2017-01-10 01:04 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
13			"IntroText" => "Varchar(250)"
14			);
15
16			private static $has_one = array(
			0 ignored issues – show Unused Code introduced 2017-01-10 01:04 UTC by Report Bug Copy Issue Report The property `$has_one` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
17			"MainContent" => "WidgetArea"
18			);
19
20			public function canCreate($member = null)
21			{
22			return SiteTree::get()->filter(array("ClassName" => "CurrencyConverterPage"))->count() ? false : true;
23			}
24
25			public function getCMSFields()
			0 ignored issues – show Documentation introduced 2017-01-10 01:04 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
26			{
27			$fields = parent::getCMSFields();
28			$fields->addFieldToTab("Root.Disclaimer", new TextField("IntroText", "Intro Text (can put disclaimer here)"));
29			return $fields;
30			}
31			}
32
33			class CurrencyConverterPage_Controller extends Page_Controller
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-10 01:04 UTC by Report Bug Copy Issue Report PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history... Coding Style Compatibility introduced 2017-01-10 01:04 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
34			{
35			public function init()
36			{
37			parent::init();
38			Requirements::javascript(THIRDPARTY_DIR."/jquery/jquery.js");
39			Requirements::javascript("widgets_currencyconverter/javascript/CurrencyConverter.js");
40			Requirements::css("widgets_currencyconverter/css/CurrencyConverter.css");
41			}
42			public function index()
			0 ignored issues – show Documentation introduced 2017-01-10 01:04 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history... Coding Style introduced 2017-01-10 01:04 UTC by Report Bug Copy Issue Report `index` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
43			{
44			if (Director::is_ajax() \|\| isset($_GET["ajax"])) {
45			return $this->renderWith("CurrencyConverterAjax");
46			}
47			}
48			public function CurrencyConverterWidget()
			0 ignored issues – show Documentation introduced 2017-01-10 01:04 UTC by Report Bug Copy Issue Report The return type could not be reliably inferred; please add a `@return` annotation. Our type inference engine in quite powerful, but sometimes the code does not provide enough clues to go by. In these cases we request you to add a `@return` annotation as described here. Loading history...
49			{
50			$widget = new CurrencyConverterWidget();
51			return $widget->renderWith("WidgetHolderMysite");
52			}
53			}
54

sunnysideup / silverstripe-widgets_currencyconverter

CurrencyConverterPage_Controller::index() A last analyzed 2018-03-20 01:39 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

CurrencyConverterPage_Controller::index() A
last analyzed 2018-03-20 01:39 UTC