CurrencyConverterPage

Complexity

Total Complexity

3

Size/Duplication

Total Lines	26
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	canCreate()	0	4	2
A	getCMSFields()	0	6	1

<?php
/**
  * This page is the Currency Converter page
  *
  */
class CurrencyConverterPage extends Page

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $icon = "widgets_currencyconverter/images/treeicons/CurrencyConverterPage";

The property $icon is not used and could be removed.

    private static $description = "This page is the Currency Converter page";

The property $description is not used and could be removed.

    
    private static $db = array(

The property $db is not used and could be removed.

        "IntroText" => "Varchar(250)"
    );

    private static $has_one = array(

The property $has_one is not used and could be removed.

        "MainContent" => "WidgetArea"
    );

    public function canCreate($member = null)
    {
        return SiteTree::get()->filter(array("ClassName" => "CurrencyConverterPage"))->count() ? false : true;
    }

    public function getCMSFields()

The return type could not be reliably inferred; please add a @return annotation.

    {
        $fields = parent::getCMSFields();
        $fields->addFieldToTab("Root.Disclaimer", new TextField("IntroText", "Intro Text (can put disclaimer here)"));
        return $fields;
    }
}

class CurrencyConverterPage_Controller extends Page_Controller

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    public function init()
    {
        parent::init();
        Requirements::javascript(THIRDPARTY_DIR."/jquery/jquery.js");
        Requirements::javascript("widgets_currencyconverter/javascript/CurrencyConverter.js");
        Requirements::css("widgets_currencyconverter/css/CurrencyConverter.css");
    }
    public function index()

The return type could not be reliably inferred; please add a @return annotation.

index uses the super-global variable $_GET which is generally not recommended.

    {
        if (Director::is_ajax() || isset($_GET["ajax"])) {
            return $this->renderWith("CurrencyConverterAjax");
        }
    }
    public function CurrencyConverterWidget()

The return type could not be reliably inferred; please add a @return annotation.

    {
        $widget = new CurrencyConverterWidget();
        return $widget->renderWith("WidgetHolderMysite");
    }
}