WebPortfolioWhatWeDidDescriptor - Code Metrics - sunnysideup/silverstripe-webportfolio - Measure and Improve Code Quality continuously with Scrutinizer

WebPortfolioWhatWeDidDescriptor A
last analyzed 2018-06-18 00:10 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	112
Duplicated Lines	9.82 %

Coupling/Cohesion

Components	1
Dependencies	9

Importance

Changes

Metric	Value
wmc	16
lcom	1
cbo	9
dl	11
loc	112
c	0
b	0
f	0
rs	10

4 Methods

Rating	Name	Duplication	Size	Complexity
A	Link()	7	12	3
B	getCMSFields()	0	35	6
A	onAfterWrite()	0	12	3
A	onBeforeWrite()	4	14	4

How to fix Duplicated Code

<?php
/**
 * @author Nicolaas [at] sunnysideup.co.nz
 * @package Webquote
 * @sub-package Webquote
 */

class WebPortfolioWhatWeDidDescriptor extends DataObject
namespace YourVendor;

class YourClass { }
{
    private static $db = array(

        "Name" => "Varchar(255)",
        "Code" => "Varchar(255)",
        "Description" => "Text"
    );

    private static $belongs_many_many = array(

        "WebPortfolioItem" => "WebPortfolioItem"
    );

    private static $default_sort = "Name";


    private static $searchable_fields = array(

        "Name" => "PartialMatchFilter",
        "Description" => "PartialMatchFilter"
    );

    private static $summary_fields = array(

        "Name",
        "Description"
    );

    private static $indexes = array(

        "Code" => true
    );

    private static $singular_name = "What We Did Descriptor";


    private static $plural_name = "What We Did Descriptors";


    public function Link()
    {
        $link = '';
        if ($page = WebPortfolioPage::get()->first()) {

            if (!$this->Code) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $this->Code = $page->generateURLSegment($this->Name);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                $this->write();
            }
            $link = $page->Link().'show/'.$this->Code."/";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
        return $link;
    }

    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $fields->removeByName("Code");
        if ($this->ID) {
            $dos = WebPortfolioWhatWeDidDescriptor::get()
                ->exclude(array("ID" => $this->ID));
            if ($dos->count()) {
                $dosArray = array("" => "--- do not merge ---");
                $dosArray += $dos->map("ID", "Name")->toArray();
                $fields->addFieldToTab("Root.Merge", new DropdownField("MergeID", "Merge <i>$this->Name</i> into:", $dosArray));
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            }
        }
        $dos = WebPortfolioItem::get();
        if ($dos->count() && $this->ID) {
            $dosArray = $dos->map()->toArray();
            $fields->addFieldsToTab(
                "Root.WebPortfolioItem",
                array(
                    new CheckboxSetField("WebPortfolioItem", "Carried out for", $dosArray)
                )
            );
        }
        if (class_exists("DataObjectOneFieldUpdateController")) {
            $link = DataObjectOneFieldUpdateController::popup_link(
                $ClassName = $this->ClassName,
                $FieldName = "Description",
                $where = '',
                $sort = 'Description DESC',
                $linkText = 'Edit Description'
            );
            $fields->addFieldToTab("Root.Main", new LiteralField("EditDescription", $link), "Description");
        }
        return $fields;
    }


    protected $mergeInto = null;

    public function onAfterWrite()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        parent::onAfterWrite();
        if ($this->mergeInto) {
            DB::query("UPDATE \"WebPortfolioItem_WhatWeDid\" SET \"WebPortfolioWhatWeDidDescriptorID\" = ".$this->mergeInto->ID." WHERE \"WebPortfolioWhatWeDidDescriptorID\"  = ".$this->ID);
            $this->delete();
        }
        if (isset($_REQUEST["MergeID"])) {
            unset($_REQUEST["MergeID"]);
        }
        $this->mergeInto = null;
    }

    public function onBeforeWrite()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        parent::onBeforeWrite();
        if (isset($_REQUEST["MergeID"])) {
            $mergeID = intval($_REQUEST["MergeID"]);
            if ($mergeID) {
                $this->mergeInto = WebPortfolioWhatWeDidDescriptor::get()->byID($mergeID);
            }
        }
        if ($page = WebPortfolioPage::get()->first()) {

            $link = $page->Link().'show/'.$this->Code."/";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->Code = $page->generateURLSegment($this->Name);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
    }
}


1		<?php
2		/**
3		* @author Nicolaas [at] sunnysideup.co.nz
4		* @package Webquote
5		* @sub-package Webquote
6		*/
7
8		class WebPortfolioWhatWeDidDescriptor extends DataObject
		0 ignored issues – show Coding Style Compatibility introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
9		{
10		private static $db = array(
		0 ignored issues – show Comprehensibility introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
11		"Name" => "Varchar(255)",
12		"Code" => "Varchar(255)",
13		"Description" => "Text"
14		);
15
16		private static $belongs_many_many = array(
		0 ignored issues – show Comprehensibility introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report The property `$belongs_many_many` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
17		"WebPortfolioItem" => "WebPortfolioItem"
18		);
19
20		private static $default_sort = "Name";
		0 ignored issues – show Comprehensibility introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report The property `$default_sort` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
21
22		private static $searchable_fields = array(
		0 ignored issues – show Comprehensibility introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report The property `$searchable_fields` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
23		"Name" => "PartialMatchFilter",
24		"Description" => "PartialMatchFilter"
25		);
26
27		private static $summary_fields = array(
		0 ignored issues – show Comprehensibility introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report The property `$summary_fields` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
28		"Name",
29		"Description"
30		);
31
32		private static $indexes = array(
		0 ignored issues – show Comprehensibility introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report The property `$indexes` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
33		"Code" => true
34		);
35
36		private static $singular_name = "What We Did Descriptor";
		0 ignored issues – show Comprehensibility introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report The property `$singular_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
37
38		private static $plural_name = "What We Did Descriptors";
		0 ignored issues – show Comprehensibility introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report The property `$plural_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
39
40		public function Link()
41		{
42		$link = '';
43	View Code Duplication	if ($page = WebPortfolioPage::get()->first()) {
		0 ignored issues – show Duplication introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
44		if (!$this->Code) {
		0 ignored issues – show Documentation introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report The property `Code` does not exist on `object<WebPortfolioWhatWeDidDescriptor>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
45		$this->Code = $page->generateURLSegment($this->Name);
		0 ignored issues – show Documentation introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report The property `Code` does not exist on `object<WebPortfolioWhatWeDidDescriptor>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report The property `Name` does not exist on `object<WebPortfolioWhatWeDidDescriptor>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
46		$this->write();
47		}
48		$link = $page->Link().'show/'.$this->Code."/";
		0 ignored issues – show Documentation introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report The property `Code` does not exist on `object<WebPortfolioWhatWeDidDescriptor>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
49		}
50		return $link;
51		}
52
53		public function getCMSFields()
54		{
55		$fields = parent::getCMSFields();
56		$fields->removeByName("Code");
57		if ($this->ID) {
58		$dos = WebPortfolioWhatWeDidDescriptor::get()
59		->exclude(array("ID" => $this->ID));
60		if ($dos->count()) {
61		$dosArray = array("" => "--- do not merge ---");
62		$dosArray += $dos->map("ID", "Name")->toArray();
63		$fields->addFieldToTab("Root.Merge", new DropdownField("MergeID", "Merge <i>$this->Name</i> into:", $dosArray));
		0 ignored issues – show Documentation introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report The property `Name` does not exist on `object<WebPortfolioWhatWeDidDescriptor>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
64		}
65		}
66		$dos = WebPortfolioItem::get();
67		if ($dos->count() && $this->ID) {
68		$dosArray = $dos->map()->toArray();
69		$fields->addFieldsToTab(
70		"Root.WebPortfolioItem",
71		array(
72		new CheckboxSetField("WebPortfolioItem", "Carried out for", $dosArray)
73		)
74		);
75		}
76		if (class_exists("DataObjectOneFieldUpdateController")) {
77		$link = DataObjectOneFieldUpdateController::popup_link(
78		$ClassName = $this->ClassName,
79		$FieldName = "Description",
80		$where = '',
81		$sort = 'Description DESC',
82		$linkText = 'Edit Description'
83		);
84		$fields->addFieldToTab("Root.Main", new LiteralField("EditDescription", $link), "Description");
85		}
86		return $fields;
87		}
88
89
90		protected $mergeInto = null;
91
92		public function onAfterWrite()
		0 ignored issues – show Coding Style introduced 2018-02-21 04:20 UTC by Report Bug Copy Issue Report `onAfterWrite` uses the super-global variable `$_REQUEST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
93		{
94		parent::onAfterWrite();
95		if ($this->mergeInto) {
96		DB::query("UPDATE \"WebPortfolioItem_WhatWeDid\" SET \"WebPortfolioWhatWeDidDescriptorID\" = ".$this->mergeInto->ID." WHERE \"WebPortfolioWhatWeDidDescriptorID\" = ".$this->ID);
97		$this->delete();
98		}
99		if (isset($_REQUEST["MergeID"])) {
100		unset($_REQUEST["MergeID"]);
101		}
102		$this->mergeInto = null;
103		}
104
105		public function onBeforeWrite()
		0 ignored issues – show Coding Style introduced 2018-02-21 04:20 UTC by Report Bug Copy Issue Report `onBeforeWrite` uses the super-global variable `$_REQUEST` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
106		{
107		parent::onBeforeWrite();
108		if (isset($_REQUEST["MergeID"])) {
109		$mergeID = intval($_REQUEST["MergeID"]);
110		if ($mergeID) {
111		$this->mergeInto = WebPortfolioWhatWeDidDescriptor::get()->byID($mergeID);
112		}
113		}
114	View Code Duplication	if ($page = WebPortfolioPage::get()->first()) {
		0 ignored issues – show Duplication introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
115		$link = $page->Link().'show/'.$this->Code."/";
		0 ignored issues – show Documentation introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report The property `Code` does not exist on `object<WebPortfolioWhatWeDidDescriptor>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Unused Code introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report `$link` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
116		$this->Code = $page->generateURLSegment($this->Name);
		0 ignored issues – show Documentation introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report The property `Code` does not exist on `object<WebPortfolioWhatWeDidDescriptor>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text / class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history... Documentation introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report The property `Name` does not exist on `object<WebPortfolioWhatWeDidDescriptor>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /* * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
117		}
118		}
119		}
120

sunnysideup / silverstripe-webportfolio

WebPortfolioWhatWeDidDescriptor A last analyzed 2018-06-18 00:10 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like

WebPortfolioWhatWeDidDescriptor A
last analyzed 2018-06-18 00:10 UTC