WebPortfolioItem - Code Metrics - sunnysideup/silverstripe-webportfolio - Measure and Improve Code Quality continuously with Scrutinizer

WebPortfolioItem A
last analyzed 2018-06-18 00:10 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	189
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	9

Importance

Changes

Metric	Value
wmc	24
lcom	2
cbo	9
dl	0
loc	189
c	0
b	0
f	0
rs	10

9 Methods

Rating	Name	Size	Complexity
B	getCMSFields()	29	5
A	getHeadLine()	18	1
A	onAfterWrite()	12	3
A	onBeforeWrite()	17	4
A	Title()	4	1
A	getTitle()	4	1
A	Link()	13	4
A	getThumbnail()	4	1
A	Thumbnail()	12	4

<?php

 /**
 * @author Nicolaas [at] sunnysideup.co.nz
 *
 *
 *
 *
 *
 *
 */

class WebPortfolioItem extends DataObject
namespace YourVendor;

class YourClass { }
{
    private static $db = array(

        "WebAddress" => "Varchar(255)",
        "NoLongerActive" => "Boolean",
        "NotPubliclyAvailable" => "Boolean",
        "Favourites" => "Boolean",
        "Notes" => "Varchar(255)",
        "Client" => "Varchar(255)",
        "Design" => "Varchar(255)",
        "CodingFrontEnd" => "Varchar(255)",
        "CodingBackEnd" => "Varchar(255)",
        "Copy" => "Varchar(255)",
        "Photography" => "Varchar(255)",
        "ScreenshotTaken" => "Date",
        "StartDate" => "Date",
        "EndDate" => "Date"
    );

    private static $has_one = array(

        "Agent" => "WebPortfolioAgent",
        "Screenshot" => "Image",
    );

    private static $many_many = array(

        "WhatWeDid" => "WebPortfolioWhatWeDidDescriptor",
    );

    private static $belongs_many_many = array(

        "WhatWeDid" => "WebPortfolioWhatWeDidDescriptor",
    );

    private static $defaults = array(

        "WebAddress" => "http",
        "NoLongerActive" => false,
        "Favourites" => false
    );

    private static $default_sort = "Favourites DESC, Created DESC";


    private static $searchable_fields = array(

        "WebAddress",
        "Client",
        "NoLongerActive",
        "NotPubliclyAvailable",
        "Favourites",
        "Agent.Name"
    );

    private static $summary_fields = array(

        "WebAddress",
        "Client",
        "Thumbnail"
    );

    private static $casting = array(

        "Title" => "Varchar",
        "Thumbnail" => "HTMLText",
        "HeadLine" => "Varchar"
    );

    private static $singular_name = "Item";


    private static $plural_name = "Items";



    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $dos = WebPortfolioWhatWeDidDescriptor::get();
        if ($dos->count() && $this->ID) {
            $dosArray = $dos->map()->toArray();
            $fields->addFieldsToTab(
                "Root.WhatWeDid",
                array(
                    new CheckboxSetField("WhatWeDid", "Select work done", $dosArray),
                    new TextField("AddWhatWeDid", "Add a job")
                )
            );
        }
        if (class_exists("DataObjectOneFieldUpdateController")) {
            $editableFields = array_keys($this->Config()->get("db"));
            foreach ($editableFields as $editableField) {
                $link = DataObjectOneFieldUpdateController::popup_link(
                    $ClassName = $this->ClassName,
                    $FieldName = $editableField,
                    $where = '',
                    $sort = '"'.$editableField.'" DESC',
                    $linkText = $editableField
                );
                $fields->addFieldToTab("Root.QuickEdits", new LiteralField("QuickEdit".$editableField, "<h2>".$link."</h2>"));
            }
        }
        return $fields;
    }

    public function getHeadLine()

    {
        $searchArray = array(
            "https://www.",
            "http://www.",
            "https://",
            "http://",
            "."
        );
        $replaceArray = array(
            "",
            "",
            "",
            "",
            " . "
        );
        return str_replace($searchArray, $replaceArray, $this->WebAddress);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    protected $newWhatWeDid = null;

    public function onAfterWrite()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        parent::onAfterWrite();
        if ($this->newWhatWeDid) {
            $this->newWhatWeDid->WebPortfolioItem()->add($this);
            $this->WhatWeDid()->add($this->newWhatWeDid);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
        }
        if (isset($_REQUEST["AddWhatWeDid"])) {
            unset($_REQUEST["AddWhatWeDid"]);
        }
        $this->newWhatWeDid = null;
    }

    public function onBeforeWrite()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        parent::onBeforeWrite();
        if (isset($_REQUEST["AddWhatWeDid"])) {
            $name = Convert::raw2sql($_REQUEST["AddWhatWeDid"]);
            if ($name) {
                $this->newWhatWeDid = WebPortfolioWhatWeDidDescriptor::get()
                    ->filter(array("Name" => $name))->first();
                if (!$this->newWhatWeDid) {
                    $this->newWhatWeDid = new WebPortfolioWhatWeDidDescriptor();
                    $this->newWhatWeDid->Name = $name;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                    $this->newWhatWeDid->write();
                    //TO DO - does not work!!!
                }
            }
        }
    }

    public function Title()

    {
        return $this->getTitle();
    }
    public function getTitle()

    {
        return $this->WebAddress;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }


    public function Link()

    {
        $link = "";
        $page = WebPortfolioPage::get()->first();
        if ($page) {
            $link = $page->Link("show/".$this->ID."/");
        } elseif ($this->ScreenshotID) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            if ($screenshot = $this->Screenshot()) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                $link = $screenshot->Link();
            }
        }
        return $link;
    }

    public function getThumbnail()

    {
        return $this->Thumbnail();
    }
    public function Thumbnail()

    {
        if ($this->ScreenshotID) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            if ($image = $this->Screenshot()) {
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                if ($image->exists()) {
                    return $image->CroppedImage(100, 100);
                }
            }
            return "image can not be found";
        }
        return "no image";
    }
}


1			<?php
2
3			/**
4			* @author Nicolaas [at] sunnysideup.co.nz
5			*
6			*
7			*
8			*
9			*
10			*
11			*/
12
13			class WebPortfolioItem extends DataObject
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
14			{
15			private static $db = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
16			"WebAddress" => "Varchar(255)",
17			"NoLongerActive" => "Boolean",
18			"NotPubliclyAvailable" => "Boolean",
19			"Favourites" => "Boolean",
20			"Notes" => "Varchar(255)",
21			"Client" => "Varchar(255)",
22			"Design" => "Varchar(255)",
23			"CodingFrontEnd" => "Varchar(255)",
24			"CodingBackEnd" => "Varchar(255)",
25			"Copy" => "Varchar(255)",
26			"Photography" => "Varchar(255)",
27			"ScreenshotTaken" => "Date",
28			"StartDate" => "Date",
29			"EndDate" => "Date"
30			);
31
32			private static $has_one = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report The property `$has_one` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
33			"Agent" => "WebPortfolioAgent",
34			"Screenshot" => "Image",
35			);
36
37			private static $many_many = array(

sunnysideup / silverstripe-webportfolio

WebPortfolioItem A last analyzed 2018-06-18 00:10 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

9 Methods

Duplication Side-by-Side

Filter issues like

WebPortfolioItem A
last analyzed 2018-06-18 00:10 UTC