Issues in VimeoDataObject.php (master) - Issues in master - sunnysideup/silverstripe-vimeoembed - Measure and Improve Code Quality continuously with Scrutinizer

Issues (88)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

code/model/VimeoDataObject.php (73 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
 *@author nicolaas[at]sunnysideup.co.nz
 *
 *
 **/

class VimeoDataObject extends DataObject
namespace YourVendor;

class YourClass { }
{
    private static $db = array(

        "Title" => "Varchar(100)",
        "VimeoCode" => "Int",
        "HTMLSnippet" => "HTMLText",
        "Data" => "Text"
    );

    private static $casting = array(

        "FullName" => "Text",
        "Icon" => "HTMLText",
        "IconLink" => "Varchar",
        "FullImage" => "HTMLText",
        "FullImageLink" => "Varchar"
    );

    private static $searchable_fields = array(

        "Title" => "PartialMatchFilter",
        "VimeoCode"
    );

    private static $summary_fields = array(

        "Icon" => "Icon",
        "Title" => "Title",
    );

    private static $singular_name = "Vimeo Video";


    private static $plural_name = "Vimeo Videos";


    private static $default_sort = "Title ASC";


    private static $vimeo_base_url = "http://vimeo.com/api/oembed.xml?url=http%3A//vimeo.com/";//The exact width of the video. Defaults to original size.


    private static $width = null;//The exact width of the video. Defaults to original size.


    private static $maxwidth = null;////Same as width, but video will not exceed original size.


    private static $height = null;//The exact height of the video. Defaults to original size.


    private static $maxheight = null;//Same as height, but video will not exceed original size.


    private static $byline = null;//Show the byline on the video. Defaults to true.


    private static $title = null;//Show the title on the video. Defaults to true.


    private static $portrait = null;//// Show the user's portrait on the video. Defaults to true.


    private static $color = null;// Specify the color of the video controls.


    private static $callback = null;//When returning JSON, wrap in this function.


    private static $autoplay = null;//Automatically start playback of the video. Defaults to false.


    private static $xhtml = null;// Make the embed code XHTML compliant. Defaults to true.


    private static $api = null;// Enable the Javascript API for Moogaloop. Defaults to false.


    private static $wmode = null;//add the "wmode" parameter. Can be either transparent or opaque.


    private static $iframe;// Use our new embed code. Defaults to true. NEW!


    protected $dataAsArray = array();

    protected $variables = array(
        "type",
        "version",
        "provider_name",
        "provider_url",
        "title",
        "author_name",
        "author_url",
        "is_plus",
        "html",
        "width",
        "height",
        "duration",
        "description",
        "thumbnail_url",
        "thumbnail_width",
        "thumbnail_height",
        "video_id"
    );

    /**
     * do not retrieve data from vimeo server ...
     * for internal use only
     * @var Boolean
     */
    private $doNotRetrieveData = false;

    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $fields->removeByName("HTMLSnippet");
        $fields->removeByName("Data");
        $fields->addFieldToTab("Root.Main", new LiteralField("HTMLSnippet", $this->HTML($noCaching = false)));
        $this->getDataAsArray();
        if (is_array($this->dataAsArray) && count($this->dataAsArray)) {
            foreach ($this->dataAsArray as $name => $value) {
                $fields->addFieldToTab("Root.Details", new ReadOnlyField($name, $name, $value));
            }
        }
        return $fields;
    }

    /**
     * casted variable
     * @return string
     */
    public function getFullName()
    {
        return $this->Title." (".$this->VimeoCode.")";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * alias for getVariable
     * @param String $name
     * @return Varchar

     */
    public function MetaDataVariable($name)
    {
        return $this->getMetaDataVariable($name);
    }

    /**
     *
     * @param String - name of variable
     *
     * @return Varchar Object

     */
    public function getMetaDataVariable($name)

    {
        $this->getDataAsArray();
        if (!empty($this->dataAsArray[$name])) {
            return DBField::create_field("Varchar", $this->dataAsArray[$name]);
        }
        return null;
    }

    /**
     * return icon as <img tag>
     * @return String

     */
    public function getIcon()
    {
        if (!count($this->dataAsArray)) {

            //remove non-ascii characters as they were causing havoc...
            $this->Data = preg_replace('/[^(\x20-\x7F)]*/', '', $this->Data);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->dataAsArray = $this->safelyUnserialize($this->Data);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
        if (!empty($this->dataAsArray["thumbnail_url"])) {
            $v = "<img src=\"".$this->dataAsArray["thumbnail_url"]."\" width=\"".$this->dataAsArray["thumbnail_width"]."\" height=\"".$this->dataAsArray["thumbnail_height"]."\" alt=\"".Convert::raw2att($this->Title)."\"/>";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        } else {
            $v = "[".$this->Title."]";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
        return DBField::create_field("HTMLText", $v);
    }

    /**
     * returns icon as myimage.png
     * @return String

     */
    public function getIconLink()

    {
        $this->getDataAsArray();
        if (!empty($this->dataAsArray["thumbnail_url"])) {
            return DBField::create_field("Varchar", $this->dataAsArray["thumbnail_url"]);
        }
        return null;
    }

    /**
     * return icon as <img tag>
     * @return String

     */
    public function getFullImage()
    {
        if (!count($this->dataAsArray)) {

            //remove non-ascii characters as they were causing havoc...
            $this->Data = preg_replace('/[^(\x20-\x7F)]*/', '', $this->Data);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->dataAsArray = $this->safelyUnserialize($this->Data);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
        if (!empty($this->dataAsArray["thumbnail_url"])) {
            $imageLink = str_replace("_295x166", "", $this->dataAsArray["thumbnail_url"]);
            $v = "<img src=\"".$imageLink."\" alt=\"".Convert::raw2att($this->Title)."\"/>";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        } else {
            $v = "[".$this->Title."]";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        }
        return DBField::create_field("HTMLText", $v);
    }

    /**
     * returns icon as myimage.png
     * @return String

     */
    public function getFullImageLink()
    {
        $this->getDataAsArray();
        if (!empty($this->dataAsArray["thumbnail_url"])) {
            $imageLink = str_replace("_295x166", "", $this->dataAsArray["thumbnail_url"]);
            return DBField::create_field("Varchar", $imageLink);
        }
        return null;
    }

    /**
     * returns the HTML Embed code
     * @return String
     */
    public function HTML($noCaching = false)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if ($noCaching || strlen($this->HTMLSnippet) < 17 || !$this->Data || isset($_GET["flush"])) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            //
            $this->updateData();
        }
        return $this->HTMLSnippet;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }

    /**
     * turns the saved serialized data into an array to return
     * if there is no data then it will try to retrieve and save it
     * then return it.
     * @return Array
     */
    protected function getDataAsArray()
    {
        if ($this->dataAsArray) {

            return $this->dataAsArray;
        }
        if (!$this->Data) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->updateData();
        }
        $this->dataAsArray = $this->safelyUnserialize($this->Data);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        return $this->dataAsArray;
    }

    /**
     * retrieves data from Vimeo Site
     *
     * @return Array
     */
    protected function updateData($writeToDatabase = true)
    {
        if ($this->doNotRetrieveData) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
            //do nothing
        } elseif ($this->VimeoCode) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $get = array();
            if ($width = $this->Config()->get("width")) {
                $get["width"] = $width;
            }
            if ($max_width = $this->Config()->get("maxwidth")) {
                $get["maxwidth"] = $max_width;
            }
            if ($height = $this->Config()->get("height")) {
                $get["height"] = $height;
            }
            if ($maxheight = $this->Config()->get("maxheight")) {
                $get["maxheight"] = $maxheight;
            }
            if ($byline = $this->Config()->get("byline")) {
                $get["byline"] = $byline;
            }
            if ($title = $this->Config()->get("title")) {
                $get["title"] = $title;
            }
            if ($portrait = $this->Config()->get("portrait")) {
                $get["portrait"] = $portrait;
            }
            if ($color = $this->Config()->get("color")) {
                $get["color"] = $color;
            }
            if ($callback = $this->Config()->get("callback")) {
                $get["callback"] = $callback;
            }
            if ($autoplay = $this->Config()->get("autoplay ")) {
                $get["autoplay"] = $autoplay;
            }
            if ($xhtml = $this->Config()->get("xhtml")) {
                $get["xhtml"] = $xhtml;
            }
            if ($api = $this->Config()->get("api")) {
                $get["api"] = $api;
            }
            if ($wmode = $this->Config()->get("wmode")) {
                $get["wmode"] = $wmode;
            }
            if ($iframe = $this->Config()->get("iframe")) {
                $get["iframe"] = $iframe;
            }
            $url = '';
            $url .= $this->Config()->get("vimeo_base_url").$this->VimeoCode;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            if (is_array($get) && count($get)) {
                foreach ($get as $key => $value) {
                    $get[$key] = $key."=".urlencode($value);
                }
                $url .= "?".implode("&", $get);
            }
            $ch = curl_init();
            curl_setopt($ch, CURLOPT_URL, $url);
            curl_setopt($ch, CURLOPT_HEADER, 0);
            curl_setopt($ch, CURLOPT_RETURNTRANSFER, 1);
            $data = curl_exec($ch);
            $array = $this->my_xml2array($data);
            foreach ($this->variables as $variable) {
                $data_array = $this->get_value_by_path($array, 'oembed/'.$variable);
                if (isset($data_array["name"]) && isset($data_array["value"])) {
                    $this->dataAsArray[$data_array["name"]] = $data_array["value"];
                } else {
                    $this->dataAsArray[$variable] = null;
                }
            }
            $this->Data = $this->safelySerialize($this->dataAsArray);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $this->HTMLSnippet = $this->dataAsArray["html"];
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            if ($writeToDatabase) {
                $this->write();
            }
        }
        return $this->Data;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
    }


    public function onBeforeWrite()
    {
        parent::onBeforeWrite();
        $this->VimeoCode = intval($this->VimeoCode);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $this->updateData(false);
    }


    //SOURCE: http://php.net/manual/en/function.xml-parse.php
    private function my_xml2array($contents)
    {
        $parser = xml_parser_create('');
        if (!$parser) {
            return false;
        }
        xml_parser_set_option($parser, XML_OPTION_TARGET_ENCODING, 'UTF-8');
        xml_parser_set_option($parser, XML_OPTION_CASE_FOLDING, 0);
        xml_parser_set_option($parser, XML_OPTION_SKIP_WHITE, 1);
        xml_parse_into_struct($parser, trim($contents), $xml_values);
        xml_parser_free($parser);
        if (!$xml_values) {

            return array();
        }
        $xml_array = array();
        $last_tag_ar =& $xml_array;
        $parents = array();
        $last_counter_in_tag = array(1=>0);
        foreach ($xml_values as $data) {
            switch ($data['type']) {
                case 'open':
                    $last_counter_in_tag[$data['level']+1] = 0;
                    $new_tag = array('name' => $data['tag']);
                    if (isset($data['attributes'])) {
                        $new_tag['attributes'] = $data['attributes'];
                    }
                    if (isset($data['value']) && trim($data['value'])) {

                        $new_tag['value'] = trim($data['value']);
                    }
                    $last_tag_ar[$last_counter_in_tag[$data['level']]] = $new_tag;
                    $parents[$data['level']] =& $last_tag_ar;
                    $last_tag_ar =& $last_tag_ar[$last_counter_in_tag[$data['level']]++];
                    break;
                case 'complete':
                    $new_tag = array('name' => $data['tag']);
                    if (isset($data['attributes'])) {
                        $new_tag['attributes'] = $data['attributes'];
                    }
                    if (isset($data['value']) && trim($data['value'])) {

                        $new_tag['value'] = trim($data['value']);
                    }
                    $last_count = count($last_tag_ar)-1;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                    $last_tag_ar[$last_counter_in_tag[$data['level']]++] = $new_tag;
                    break;
                case 'close':
                    $last_tag_ar =& $parents[$data['level']];
                    break;
                default:
                    break;
            };
        }
        return $xml_array;
    }

    //
    // use this to get node of tree by path with '/' terminator
    //
    //SOURCE: http://php.net/manual/en/function.xml-parse.php
    private function get_value_by_path($__xml_tree, $__tag_path)

    {
        $tmp_arr =& $__xml_tree;
        $tag_path = explode('/', $__tag_path);
        foreach ($tag_path as $tag_name) {
            $res = false;
            foreach ($tmp_arr as $key => $node) {
                if (is_int($key) && $node['name'] == $tag_name) {
                    $tmp_arr = $node;
                    $res = true;
                    break;
                }
            }
            if (!$res) {
                return false;
            }
        }
        return $tmp_arr;
    }

    /**
     *
     * @param String $serializedData
     *
     * @return Array
     */
    public function safelyUnserialize($serializedData)
    {
        return unserialize(base64_decode($serializedData));
        //this code needs checking.
        try {
function fx() {
    try {
        doSomething();
        return true;
    }
    catch (\Exception $e) {
        return false;
    }

    return false;
}
            $fixed = unserialize(base64_decode($serializedData));
            if (is_array($fixed)) {
                return $fixed;
            } else {
                return unserialize($serializedData);
            }
        } catch (Exception $e) {
            $fixed = preg_replace_callback(
                '!s:(\d+):"(.*?)";!',
                function ($match) {
                    return ($match[1] == strlen($match[2])) ? $match[0] : 's:' . strlen($match[2]) . ':"' . $match[2] . '";';
                },
                $serializedData
            );
        }
        return $fixed;
    }

    /**
     *
     * @param Array $dataAsArray
     *
     * @return String
     *
     */
    public function safelySerialize($dataAsArray)
    {
        return base64_encode(serialize($dataAsArray));
    }
}


1			<?php
2
3			/**
4			*@author nicolaas[at]sunnysideup.co.nz
5			*
6			*
7			**/
8
9			class VimeoDataObject extends DataObject
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
10			{
11			private static $db = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
12			"Title" => "Varchar(100)",
13			"VimeoCode" => "Int",
14			"HTMLSnippet" => "HTMLText",
15			"Data" => "Text"
16			);
17
18			private static $casting = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$casting` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
19			"FullName" => "Text",
20			"Icon" => "HTMLText",
21			"IconLink" => "Varchar",
22			"FullImage" => "HTMLText",
23			"FullImageLink" => "Varchar"
24			);
25
26			private static $searchable_fields = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$searchable_fields` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
27			"Title" => "PartialMatchFilter",
28			"VimeoCode"
29			);
30
31			private static $summary_fields = array(
			0 ignored issues – show Comprehensibility introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-01-10 01:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `$summary_fields` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
32			"Icon" => "Icon",
33			"Title" => "Title",
34			);
35

sunnysideup / silverstripe-vimeoembed

Issues (88)

Security Analysis no request data

code/model/VimeoDataObject.php (73 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like