Issues in RegisterAndEditDetailsPage.php (master) - Issues in master - sunnysideup/silverstripe-userpage - Measure and Improve Code Quality continuously with Scrutinizer

Issues (24)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

code/RegisterAndEditDetailsPage.php (22 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/**
    * Page containing an edit details form
    * Uses Member::getMemberFormFields() to know what to make available for editing
    */
class RegisterAndEditDetailsPage extends Page
namespace YourVendor;

class YourClass { }
{
    private static $icon = "userpage/images/treeicons/RegisterAndEditDetailsPage";


    private static $can_be_root = false;


    private static $db = array(

        "ThankYouTitle" => "Varchar(255)",
        "ThankYouContent" => "HTMLText",
        "WelcomeTitle" => "Varchar(255)",
        "WelcomeContent" => "HTMLText",
        "TitleLoggedIn" => "Varchar(255)",
        "MenuTitleLoggedIn" => "Varchar(255)",
        "ContentLoggedIn" => "HTMLText",
        "ErrorEmailAddressAlreadyExists" => "Varchar(255)",
        "ErrorBadEmail" => "Varchar(255)",
        "ErrorPasswordDoNotMatch" => "Varchar(255)",
        "ErrorMustSupplyPassword" => "Varchar(255)"
    );

    private static $register_group_title = "Registered users";

    private static $register_group_code = "registrations";

    private static $register_group_access_key = "REGISTRATIONS";

    protected function showLoggedInFields()
    {
        if (!$this->isCMSRead() && Member::currentUser()) {
            return true;
        }
    }

    protected function isCMSRead()
    {
        return $this->isCMS || Controller::curr()->getRequest()->param("URLSegment") == "admin";
    }

    /**
     * Returns a link to this page that will, on completion,
     * redirect back to the another page
     *@param String - $link
     *@return String - $link
     **/


    public function link_for_going_to_page_via_making_user($link)
    {
        $registerAndEditDetailsPage = RegisterAndEditDetailsPage::get()->first();
        if ($registerAndEditDetailsPage) {
            return $registerAndEditDetailsPage->Link()."?BackURL=".urlencode($link);
        }
    }

    public function getCMSFields()

    {
        $fields = parent::getCMSFields();
        $this->isCMS = true;
        $fields->addFieldToTab('Root.LoggedIn', new TextField('TitleLoggedIn', 'Title when user is Logged In'));
        $fields->addFieldToTab('Root.LoggedIn', new TextField('MenuTitleLoggedIn', 'Navigation Label when user is Logged In'));
        $fields->addFieldToTab('Root.Welcome', new TextField('WelcomeTitle', 'Welcome Title (afer user creates an account)'));
        $fields->addFieldToTab('Root.Welcome', new HtmlEditorField('WelcomeContent', 'Welcome message (afer user creates an account)'));
        $fields->addFieldToTab('Root.UpdatingDetails', new TextField('ThankYouTitle', 'Thank you Title (afer user updates their details)'));
        $fields->addFieldToTab('Root.UpdatingDetails', new HtmlEditorField('ThankYouContent', 'Thank you message (afer user updates their details)'));
        $fields->addFieldToTab('Root.LoggedIn', new HtmlEditorField('ContentLoggedIn', 'Content when user is Logged In'));
        $fields->addFieldToTab('Root.ErrorMessages', new TextField('ErrorEmailAddressAlreadyExists', 'Error shown when email address is already registered'));
        $fields->addFieldToTab('Root.ErrorMessages', new TextField('ErrorBadEmail', 'Bad email'));
        $fields->addFieldToTab('Root.ErrorMessages', new TextField('ErrorPasswordDoNotMatch', 'Error shown when passwords do not match'));
        $fields->addFieldToTab('Root.ErrorMessages', new TextField('ErrorMustSupplyPassword', 'Error shown when new user does not supply password'));
        return $fields;
    }

    public function canCreate($member = null)
    {
        return RegisterAndEditDetailsPage::get()->count() ? false : true;
    }

    public function requireDefaultRecords()
    {
        parent::requireDefaultRecords();
        $bt = defined('DB::USE_ANSI_SQL') ? "\"" : "`";
        $update = array();
        $group = Group::get()
            ->filter(array("Code" => self::$register_group_code))->first();
        if (!$group) {
            $group = new Group();
            $group->Code = self::$register_group_code;
            $group->Title = self::$register_group_title;
            $group->write();
            Permission::grant($group->ID, self::$register_group_access_key);
            DB::alteration_message("GROUP: ".self::$register_group_code.' ('.self::$register_group_title.')', "created");
        } elseif (DB::query("SELECT * FROM Permission WHERE {$bt}GroupID{$bt} = ".$group->ID." AND {$bt}Code{$bt} = '".self::$register_group_access_key."'")->numRecords() == 0) {
            Permission::grant($group->ID, self::$register_group_access_key);
        }
        $page = RegisterAndEditDetailsPage::get()->first();
        if (!$page) {
            $page = new RegisterAndEditDetailsPage();
            $page->Title = "Register";
            $page->URLSegment = "register";
            $page->MenuTitle = "Register";
            $update[] = "created RegisterAndEditDetailsPage";
        }
        if ($page) {

            //REGISTER
            if (strlen($page->Content) < 17) {
                $page->Content = "<p>Please log in or register here.</p>";
                $update[] =  "updated Content";
            }

            //WELCOME !
            if (!$page->WelcomeTitle) {
                $page->WelcomeTitle = "Thank you for registering";
                $update[] =  "updated WelcomeTitle";
            }
            if (strlen($page->WelcomeContent) < 17) {
                $page->WelcomeContent = "<p>Thank you for registration. Please make sure to remember your username and password.</p>";
                $update[] =  "updated WelcomeContent";
            }

            // WELCOME BACK
            if (!$page->TitleLoggedIn) {
                $page->TitleLoggedIn = "Welcome back";
                $update[] =  "updated TitleLoggedIn";
            }
            if (!$page->MenuTitleLoggedIn) {
                $page->MenuTitleLoggedIn = "Welcome back";
                $update[] =  "updated MenuTitleLoggedIn";
            }
            if (strlen($page->ContentLoggedIn) < 17) {
                $page->ContentLoggedIn = "<p>Welcome back - you can do the following ....</p>";
                $update[] =  "updated ContentLoggedIn";
            }

            //THANK YOU FOR UPDATING
            if (!$page->ThankYouTitle) {
                $page->ThankYouTitle = "Thank you for updating your details";
                $update[] =  "updated ThankYouTitle";
            }
            if (strlen($page->ThankYouContent) < 17) {
                $page->ThankYouContent = "<p>Thank you for updating your details. </p>";
                $update[] =  "updated ThankYouContent";
            }

            //ERRORS!
            if (!$page->ErrorEmailAddressAlreadyExists) {
                $page->ErrorEmailAddressAlreadyExists = "Sorry, that email address is already in use by someone else. You may have setup an account in the past or mistyped your email address.";
                $update[] =  "updated ErrorEmailAddressAlreadyExists";
            }
            if (!$page->ErrorBadEmail) {
                $page->ErrorBadEmail = "Sorry, that does not appear a valid email address.";
                $update[] =  "updated ErrorBadEmail";
            }
            if (!$page->ErrorPasswordDoNotMatch) {
                $page->ErrorPasswordDoNotMatch = "Your passwords do not match. Please try again.";
                $update[] =  "updated ErrorPasswordDoNotMatch";
            }
            if (!$page->ErrorMustSupplyPassword) {
                $page->ErrorMustSupplyPassword = "Your must supply a password.";
                $update[] =  "updated ErrorMustSupplyPassword";
            }
            if (count($update)) {
                $page->writeToStage('Stage');
                $page->publish('Stage', 'Live');
                DB::alteration_message($page->ClassName." created/updated: <ul><li>".implode("</li><li>", $update)."</li></ul>", 'created');
            }
        }
    }
}

class RegisterAndEditDetailsPage_Controller extends Page_Controller
namespace YourVendor;

class YourClass { }
{
    private static $fields_to_remove = array("Locale","DateFormat", "TimeFormat");


    private static $required_fields = array("FirstName","Email");


    private static $minutes_before_member_is_not_new_anymore = 30;


    public function init()
    {
        parent::init();
        if ($this->showLoggedInFields()) {
            $field = "TitleLoggedIn";
        } else {
            $field = "Title";
        }
        $this->Title = $this->getField($field);
        if ($this->showLoggedInFields()) {
            $field = "MenuTitleLoggedIn";
        } else {
            $field = "MenuTitle";
        }
        $this->MenuTitle =  $this->getField($field);
        if ($this->showLoggedInFields()) {
            $field = "ContentLoggedIn";
        } else {
            $field = "Content";
        }
        $this->Content =  $this->getField($field);
    }

    public function index()

    {
        if (Director::is_ajax()) {
            return $this->renderWith(array("RegisterAndEditDetailsPageAjax", "RegisterAndEditDetailsPage"));
        }
        return array();
    }

    public function Form()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (isset($_REQUEST["BackURL"])) {
            Session::set('BackURL', $_REQUEST["BackURL"]);
        }
        $member = Member::currentUser();
        $fields = new FieldList();

        $passwordField = null;
        if ($member) {
            $name = $member->getName();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            //if($member && $member->Password != '') {$passwordField->setCanBeEmpty(true);}

            $action = new FormAction("submit", "Update your details");
            $action->addExtraClass("updateButton");
            $actions = new FieldList($action);
        } else {
            $passwordField = new ConfirmedPasswordField("Password", "Password");
            $action = new FormAction("submit", "Register");
            $action->addExtraClass("registerButton");
            $actions = new FieldList($action);
            $member = new Member();
        }
        $memberFormFields = $member->getMemberFormFields();

        if ($memberFormFields) {
            if (is_array(self::$fields_to_remove) && count(self::$fields_to_remove)) {
                foreach (self::$fields_to_remove as $fieldName) {
                    $memberFormFields->removeByName($fieldName);
                }
            }
            $fields->merge($memberFormFields);
        }
        if ($passwordField) {
            $fields->push($passwordField);
        }
        foreach (self::$required_fields as $fieldName) {
            $fields->fieldByName($fieldName)->addExtraClass("RequiredField");
        }
        $requiredFields = new RequiredFields(self::$required_fields);
        $form = new Form($this, "Form", $fields, $actions, $requiredFields);
        // Load any data avaliable into the form.
        if ($member) {
            $member->Password = null;
            $form->loadDataFrom($member);
        }
        $data = Session::get("FormInfo.Form_Form.data");
        if (is_array($data)) {
            $form->loadDataFrom($data);
        }

        // Optional spam protection
        if (class_exists('SpamProtectorManager')) {
            SpamProtectorManager::update_form($form);
        }
        if (!isset($_REQUEST["Password"])) {
            $form->fields()->fieldByName("Password")->SetValue("");
        }
        return $form;
    }


    /**
     * Save the changes to the form
     */
    public function submit($data, $form)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        $bt = defined('DB::USE_ANSI_SQL') ? "\"" : "`";
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $member = Member::currentUser();
        $newMember = false;
        Session::set("FormInfo.Form_Form.data", $data);
        $emailField = new EmailField("Email");
        $emailField->setValue($data["Email"]);
        if ($emailField) {
            if (!$emailField->validate($form->validator)) {
                $form->addErrorMessage("Blurb", $this->ErrorBadEmail, "bad");
                $this->redirectBack();
                return;
            }
        }
        if (!$member) {
            $newMember = true;
            $member = Object::create('Member');
            $form->sessionMessage($this->WelcomeTitle, 'good');
            $id = 0;
        } else {
            $form->sessionMessage($this->ThankYouTitle, 'good');
            $id = $member->ID;
        }

        //validation
        if ($existingMember = Member::get()->filter(array("Email" => Convert::raw2sql($data['Email'])))->exclude(array("ID" => $id))->first()) {
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $form->addErrorMessage("Blurb", $this->ErrorEmailAddressAlreadyExists, "bad");
            return $this->redirectBack();
        }
        // check password fields are the same before saving
        if ($data["Password"]["_Password"] != $data["Password"]["_ConfirmPassword"]) {
            $form->addErrorMessage("Password", $this->ErrorPasswordDoNotMatch, "bad");
            return $this->redirectBack();
        }

        if (!$id && !$data["Password"]["_Password"]) {
            $form->addErrorMessage("Password", $this->ErrorMustSupplyPassword, "bad");
            return $this->redirectBack();
        }
        $password = $member->Password;
        if (isset($data["Password"]["Password"]) && strlen($data["Password"]["Password"]) > 3) {
            $password = $data["Password"]["Password"];
        }
        $form->saveInto($member);
        $member->changePassword($password);
        $member->write();
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        if ($newMember) {
            $form->saveInto($member);
            $member->write();
        }
        //adding to group
        $group = Group::get()
            ->filter(array("Code" => self::$register_group_code))
            ->first();
        if ($group) {
            $member->Groups()->add($group);
        }
        if ($newMember) {
            $member->logIn();
            $link = ContentController::join_links($this->Link(), 'welcome');
        } else {
            $link = ContentController::join_links($this->Link(), 'thanks');
        }
        if (!isset($_REQUEST["BackURL"]) && Session::get('BackURL')) {

            $_REQUEST["BackURL"] = Session::get('BackURL');
        }
        if (isset($_REQUEST["BackURL"])) {

            $link = urldecode($_REQUEST["BackURL"]);
            Session::set('BackURL', '');
        }
        if ($link) {
            return $this->redirect($link);
        }
        return array();
    }

    public function thanks()

    {
        $member = Member::currentUser();
        if (!$member) {
            return $this->redirect($this->Link());
        }
        if ($this->numberOfMinutesMemberIsListed($member) < self::get_minutes_before_member_is_not_new_anymore()) {
            $this->Title = $this->WelcomeTitle;
            $this->Content = $this->WelcomeContent;
        } else {
            $this->Title = $this->ThankYouTitle;
            $this->Content = $this->ThankYouContent;
        }
        return array();
    }

    public function welcome()

    {
        if (!Member::currentUser()) {
            return $this->redirect($this->Link());
        }
        $this->Title = $this->WelcomeTitle;
        $this->Content = $this->WelcomeContent;
        return array();
    }

    public function numberOfMinutesMemberIsListed($member)
    {
        if ($member) {
            $timestamp = strtotime(strval($member->Created));
            $nowTimestamp = time();
            return ($nowTimestamp - $timestamp) / 60;
        }
        return 0;
    }
}


Issues (24)

Security Analysis not enabled

code/RegisterAndEditDetailsPage.php (22 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

sunnysideup / silverstripe-userpage

Issues (24)

Security Analysis not enabled

code/RegisterAndEditDetailsPage.php (22 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Duplication Side-by-Side

Filter issues like