OffSpringField::__construct() - Code Metrics - sunnysideup/silverstripe-userforms_relatives - Measure and Improve Code Quality continuously with Scrutinizer

OffSpringField::__construct() A
last analyzed 2018-03-20 01:37 UTC

↳ Parent: OffSpringField

Complexity

Conditions	1
Paths	1

Size

Total Lines	13
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	13
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	10
nc	1
nop	3

<?php
/**
 *
 * @package userforms
 * @subpackage relatives
 */
class OffSpringField extends FormField
namespace YourVendor;

class YourClass { }
{

    /**
     * @var nameField
     */
    protected $headerField = null;

    /**
     * @var nameField
     */
    protected $nameField = null;

    /**
     * @var dobField
     */
    protected $dobField = null;

    /**
     * @var dobField
     */
    protected $sexField = null;


    public function __construct($name, $title = null, $value = "")
    {
        $this->headerField = new HeaderField($name . '[header]', $title, 4);

        $this->nameField = new TextField($name . '[name]', "Name");

        $this->dobField = new TextField($name . '[dob]', "Date of Birth (e.g. 31/01/1986)");

        $this->sexField = new OptionsetField($name . '[sex]', false, array("female", "male"));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $this->headerField->addExtraClass("header");
        $this->nameField->addExtraClass("name");
        $this->dobField->addExtraClass("dob");
        $this->sexField->addExtraClass("sexField");

        parent::__construct($name, $title, $value);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    }

    public function setForm($form)
    {
        parent::setForm($form);

        $this->headerField->setForm($form);
        $this->nameField->setForm($form);
        $this->dobField->setForm($form);
        $this->sexField->setForm($form);
    }

    public function Field()
    {
        //Requirements::css();

        //Requirements::javascript();

        return $this->headerField->SmallFieldHolder() . $this->nameField->SmallFieldHolder() . $this->dobField->SmallFieldHolder() . $this->sexField->SmallFieldHolder() . '<div class="clear"><!-- --></div>';
    }

    /**
     * Sets the internal value to ISO date format.
     *
     * @param string|array $val String expects an ISO date format. Array notation with 'date' and 'time'
     *  keys can contain localized strings. If the 'dmyfields' option is used for {@link nameField},
     *  the 'date' value may contain array notation was well (see {@link nameField->setValue()}).
     */
    public function setValue($val)
    {
        if (empty($val)) {
            $this->nameField->setValue(null);
            $this->dobField->setValue(null);
            $this->sexField->setValue(null);
        } else {
            // String setting is only possible from the database, so we don't allow anything but ISO format
            if (is_string($val)) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
                //TO DO
            }
            // Setting from form submission
            elseif (is_array($val) && array_key_exists('name', $val) && array_key_exists('dob', $val) && array_key_exists('sex', $val)) {
                $this->nameField->setValue($val['name']);
                $this->dobField->setValue($val['dob']);
                $this->sexField->setValue($val['sex']);
            } else {
                $this->nameField->setValue($val);
                $this->dobField->setValue($val);
                $this->sexField->setValue($val);
            }
        }
    }

    public function dataValue()
    {
        $valName = $this->nameField->dataValue();
        $valDob = $this->dobField->dataValue();
        $valSex = $this->sexField->dataValue();

        $array = array("name" => $valName, "dob" => $valDob, "sex" => $valSex);
        return implode("|", $array);
    }


    /**
     * @return nameField
     */
    public function getHeaderField()
    {
        return $this->headerField;
    }

    /**
     * @return nameField
     */
    public function getNameField()
    {
        return $this->nameField;
    }

    /**
     * @return dobField
     */
    public function getDobField()
    {
        return $this->dobField;
    }

    /**
     * @return sexField

     */
    public function getSexField()
    {
        return $this->sexField;
    }


    public function validate($validator)
    {
        $dateValid = $this->nameField->validate($validator);
        $timeValid = $this->dobField->validate($validator);
        $sexValid = $this->sexField->validate($validator);

        return ($dateValid && $timeValid && $sexValid);
    }

    public function jsValidation()
    {
        return $this->nameField->jsValidation() . $this->dobField->jsValidation() . $this->sexField->jsValidation() ;
    }

    public function performReadonlyTransformation()
    {
        $field = new OffSpringField_Readonly($this->name, $this->title, $this->dataValue());
        $field->setForm($this->form);
        return $field;
    }
}

/**

 */
class OffSpringField_Readonly extends OffSpringField
namespace YourVendor;

class YourClass { }
{
    protected $readonly = true;

    public function Field()
    {
        $valName = $this->nameField->dataValue();
        $valDob = $this->dobField->dataValue();
        $valSex = $this->sexField->dataValue();
        if ($valDate && $valTime && $valSex) {

            $val = $valName." ".$valDob." ".$valSex;
        } else {
            // TODO Localization
            $val = '<i>(not set)</i>';
        }

        return "<span class=\"readonly\" id=\"" . $this->id() . "\">$val</span>";
    }

    public function jsValidation()
    {
        return null;
    }

    public function validate($validator)
    {
        return true;
    }
}


1			<?php
2			/**
3			*
4			* @package userforms
5			* @subpackage relatives
6			*/
7			class OffSpringField extends FormField
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:38 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
8			{
9
10			/**
11			* @var nameField
12			*/
13			protected $headerField = null;
14
15			/**
16			* @var nameField
17			*/
18			protected $nameField = null;
19
20			/**
21			* @var dobField
22			*/
23			protected $dobField = null;
24
25			/**
26			* @var dobField
27			*/
28			protected $sexField = null;
29
30
31			public function __construct($name, $title = null, $value = "")
32			{
33			$this->headerField = new HeaderField($name . '[header]', $title, 4);
			0 ignored issues – show Documentation Bug introduced 2017-01-03 01:38 UTC by Report Bug Copy Issue Report It seems like `new \HeaderField($name . '[header]', $title, 4)` of type `object<HeaderField>` is incompatible with the declared type `object<nameField>` of property `$headerField`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
34			$this->nameField = new TextField($name . '[name]', "Name");
			0 ignored issues – show Documentation Bug introduced 2017-01-03 01:38 UTC by Report Bug Copy Issue Report It seems like `new \TextField($name . '[name]', 'Name')` of type `object<TextField>` is incompatible with the declared type `object<nameField>` of property `$nameField`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
35			$this->dobField = new TextField($name . '[dob]', "Date of Birth (e.g. 31/01/1986)");
			0 ignored issues – show Documentation Bug introduced 2017-01-03 01:38 UTC by Report Bug Copy Issue Report It seems like `new \TextField($name . '...rth (e.g. 31/01/1986)')` of type `object<TextField>` is incompatible with the declared type `object<dobField>` of property `$dobField`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
36			$this->sexField = new OptionsetField($name . '[sex]', false, array("female", "male"));
			0 ignored issues – show Documentation introduced 2017-01-03 01:38 UTC by Report Bug Copy Issue Report `$name . '[sex]'` is of type `string`, but the function expects a `object<The>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2017-01-03 01:38 UTC by Report Bug Copy Issue Report `false` is of type `boolean`, but the function expects a `string\|object<The>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation Bug introduced 2017-01-03 01:38 UTC by Report Bug Copy Issue Report It seems like `new \OptionsetField($nam...rray('female', 'male'))` of type `object<OptionsetField>` is incompatible with the declared type `object<dobField>` of property `$sexField`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
37			$this->headerField->addExtraClass("header");
38			$this->nameField->addExtraClass("name");
39			$this->dobField->addExtraClass("dob");
40			$this->sexField->addExtraClass("sexField");
41
42			parent::__construct($name, $title, $value);
			0 ignored issues – show Documentation introduced 2017-01-03 01:38 UTC by Report Bug Copy Issue Report `$value` is of type `string`, but the function expects a `object<The>\|null`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
43			}
44
45			public function setForm($form)
46			{
47			parent::setForm($form);
48
49			$this->headerField->setForm($form);
50			$this->nameField->setForm($form);
51			$this->dobField->setForm($form);
52			$this->sexField->setForm($form);
53			}
54
55			public function Field()
56			{
57			//Requirements::css();
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-03 01:38 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
58			//Requirements::javascript();
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-01-03 01:38 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
59			return $this->headerField->SmallFieldHolder() . $this->nameField->SmallFieldHolder() . $this->dobField->SmallFieldHolder() . $this->sexField->SmallFieldHolder() . '<div class="clear"><!-- --></div>';
60			}
61
62			/**
63			* Sets the internal value to ISO date format.
64			*
65			* @param string\|array $val String expects an ISO date format. Array notation with 'date' and 'time'
66			* keys can contain localized strings. If the 'dmyfields' option is used for {@link nameField},
67			* the 'date' value may contain array notation was well (see {@link nameField->setValue()}).
68			*/
69			public function setValue($val)
70			{
71			if (empty($val)) {
72			$this->nameField->setValue(null);
73			$this->dobField->setValue(null);
74			$this->sexField->setValue(null);
75			} else {
76			// String setting is only possible from the database, so we don't allow anything but ISO format
77			if (is_string($val)) {
			0 ignored issues – show Unused Code introduced 2017-01-03 01:38 UTC by Report Bug Copy Issue Report This `if` statement is empty and can be removed. This check looks for the bodies of `if` statements that have no statements or where all statements have been commented out. This may be the result of changes for debugging or the code may simply be obsolete. These `if` bodies can be removed. If you have an empty if but statements in the `else` branch, consider inverting the condition. if (rand(1, 6) > 3) { //print "Check failed"; } else { print "Check succeeded"; } could be turned into if (rand(1, 6) <= 3) { print "Check succeeded"; } This is much more concise to read. Loading history...
78			//TO DO
79			}
80			// Setting from form submission
81			elseif (is_array($val) && array_key_exists('name', $val) && array_key_exists('dob', $val) && array_key_exists('sex', $val)) {
82			$this->nameField->setValue($val['name']);
83			$this->dobField->setValue($val['dob']);
84			$this->sexField->setValue($val['sex']);
85			} else {
86			$this->nameField->setValue($val);
87			$this->dobField->setValue($val);
88			$this->sexField->setValue($val);
89			}
90			}
91			}
92
93			public function dataValue()
94			{
95			$valName = $this->nameField->dataValue();
96			$valDob = $this->dobField->dataValue();
97			$valSex = $this->sexField->dataValue();
98
99			$array = array("name" => $valName, "dob" => $valDob, "sex" => $valSex);
100			return implode("\|", $array);
101			}
102
103
104			/**
105			* @return nameField
106			*/
107			public function getHeaderField()
108			{
109			return $this->headerField;
110			}
111
112			/**
113			* @return nameField
114			*/
115			public function getNameField()
116			{
117			return $this->nameField;
118			}
119
120			/**
121			* @return dobField
122			*/
123			public function getDobField()
124			{
125			return $this->dobField;
126			}
127
128			/**
129			* @return sexField
			0 ignored issues – show Documentation introduced 2017-01-03 01:38 UTC by Report Bug Copy Issue Report Should the return type not be `dobField`? This check compares the return type specified in the `@return` annotation of a function or method doc comment with the types returned by the function and raises an issue if they mismatch. Loading history...
130			*/
131			public function getSexField()
132			{
133			return $this->sexField;
134			}
135
136
137			public function validate($validator)
138			{
139			$dateValid = $this->nameField->validate($validator);
140			$timeValid = $this->dobField->validate($validator);
141			$sexValid = $this->sexField->validate($validator);
142
143			return ($dateValid && $timeValid && $sexValid);
144			}
145
146			public function jsValidation()
147			{
148			return $this->nameField->jsValidation() . $this->dobField->jsValidation() . $this->sexField->jsValidation() ;
149			}
150
151			public function performReadonlyTransformation()
152			{
153			$field = new OffSpringField_Readonly($this->name, $this->title, $this->dataValue());
154			$field->setForm($this->form);
155			return $field;
156			}
157			}
158
159			/**
160
161			*/
162			class OffSpringField_Readonly extends OffSpringField
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:38 UTC by Report Bug Copy Issue Report PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history... Coding Style Compatibility introduced 2017-01-03 01:38 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
163			{
164			protected $readonly = true;
165
166			public function Field()
167			{
168			$valName = $this->nameField->dataValue();
169			$valDob = $this->dobField->dataValue();
170			$valSex = $this->sexField->dataValue();
171			if ($valDate && $valTime && $valSex) {
			0 ignored issues – show Bug introduced 2017-01-03 01:38 UTC by Report Bug Copy Issue Report The variable `$valDate` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history... Bug introduced 2017-01-03 01:38 UTC by Report Bug Copy Issue Report The variable `$valTime` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
172			$val = $valName." ".$valDob." ".$valSex;
173			} else {
174			// TODO Localization
175			$val = '<i>(not set)</i>';
176			}
177
178			return "<span class=\"readonly\" id=\"" . $this->id() . "\">$val</span>";
179			}
180
181			public function jsValidation()
182			{
183			return null;
184			}
185
186			public function validate($validator)
187			{
188			return true;
189			}
190			}
191

sunnysideup / silverstripe-userforms_relatives

OffSpringField::__construct() A last analyzed 2018-03-20 01:37 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

OffSpringField::__construct() A
last analyzed 2018-03-20 01:37 UTC