Sunnysideup\UpgradeToSilverstripe4\Tasks\IndividualTasks\AddPSR4Autoloading::runActualTask()

Complexity

Conditions	4
Paths	6

Size

Total Lines	67
Code Lines	37

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	1

<?php
    public function runActualTask($params = [])
    {
        //project composer.json
        // - app/src/...
        // - app2/src/...
        // DO FOR BOTH
        //module composor.json
        //  ONLY FOR module
        $listOfAutoLoads = [];

The assignment to $listOfAutoLoads is dead and can be removed.

        $baseCommands = '
            if(! isset($data["autoload"])) {
                $data["autoload"] = [];
            }
            if(! isset($data["autoload"]["psr-4"])) {
                $data["autoload"]["psr-4"] = [];
            }
        ';
        $addPage = '';
        if ($this->mu()->getIsModuleUpgrade()) {

The method getIsModuleUpgrade() does not exist on Sunnysideup\UpgradeToSilverstripe4\ModuleUpgrader. Since you implemented __call, consider adding a @method annotation.

            $addPage = '
            if(! isset($data["autoload"]["files"])) {
                $data["autoload"]["files"] = [
                    "app/src/Page.php",
                    "app/src/PageController.php"
                ];
            }';
        }

        $codeDirs = $this->mu()->findNameSpaceAndCodeDirs();
        $webRootLocation = $this->mu()->getWebRootDirLocation();

The method getWebRootDirLocation() does not exist on Sunnysideup\UpgradeToSilverstripe4\ModuleUpgrader. Since you implemented __call, consider adding a @method annotation.

        $command = $baseCommands . $addPage;
        $comment = 'Adding autoload Page and Page controller details in ' . $webRootLocation . '/composer.json';
        $this->updateJSONViaCommandLine(
            $webRootLocation,
            $command,
            $comment
        );
        foreach ($codeDirs as $baseNameSpace => $codeDir) {
            $location = trim(str_replace($webRootLocation, '', $codeDir), '/') . '/';
            //update webroot composer file
            //location:
            $command = $baseCommands . '
            $data["autoload"]["psr-4"]["' . $this->doubleSlash($baseNameSpace) . '"] = "' . $location . '";';
            $comment = 'Adding autoload psr-4 details in ' . $webRootLocation . '/composer.json: ' . $baseNameSpace . ' => ' . $location;
            $this->updateJSONViaCommandLine(
                $webRootLocation,
                $command,
                $comment
            );
            if ($this->mu()->getIsModuleUpgrade()) {
                $moduleLocation = dirname($codeDir);
                $location = trim(basename($codeDir), '/') . '/';
                $command = $baseCommands . '
                $data["autoload"]["psr-4"]["' . $this->doubleSlash($baseNameSpace) . '"] = "' . ltrim($location, '/') . '";';
                $comment = 'Adding autoload psr-4 details in ' . $moduleLocation . '/composer.json: ' . $baseNameSpace . ' => ' . $location;
                $this->updateJSONViaCommandLine(
                    $moduleLocation,
                    $command,
                    $comment
                );
            }
        }
        $this->mu()->execMe(
            $this->mu()->getWebRootDirLocation(),
            'composer dumpautoload',
            'run composer dumpautoload',
            false
        );