SearchAndReplace::checkReplacementDataIssues() - Code Metrics - Inspection of "PATCH: better scrutizner" - sunnysideup/silverstripe-upgrade_to_silverstripe_4 - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Branch — master (2f7647)

by Nicolaas
created 2019-07-12 19:57 UTC
SearchAndReplace::checkReplacementDataIssues() C

↳ Parent: SearchAndReplace
Complexity

Conditions	17
Paths	64
Size

Total Lines	63
Code Lines	42
Duplication

Lines	0
Ratio	0 %
Importance

Changes	1
Bugs	0	Features	0
Metric	Value
eloc	42
c	1
b	0
f	0
dl	0
loc	63
rs	5.2166
cc	17
nc	64
nop	0
How to fix Long Method Complexity

<?php

namespace Sunnysideup\UpgradeToSilverstripe4\Tasks\IndividualTasks;

use Sunnysideup\UpgradeToSilverstripe4\Api\SearchAndReplaceAPI;
use Sunnysideup\UpgradeToSilverstripe4\ReplacementData\LoadReplacementData;

use Sunnysideup\UpgradeToSilverstripe4\Tasks\Task;

/**
 * Replaces a bunch of code snippets in preparation of the upgrade.
 * Controversial replacements will be replaced with a comment
 * next to it so you can review replacements easily.
 */
class SearchAndReplace extends Task
{
    protected $taskStep = 's30';

    protected $debug = false;

    protected $checkReplacementIssues = false;

    protected $replacementHeader = 'upgrade to SS4';

    protected $ignoreFolderArray = [
        '.git',
    ];

    protected $alternativePathForReplacementData = '';

    public function getTitle()
    {
        return 'Search and Replace';
    }

    public function getDescription()
    {
        return '
            Replaces a bunch of code snippets in preparation of the upgrade.
            Controversial replacements will be replaced with a comment
            next to it so you can review replacements easily.';
    }

    public function setCheckReplacementIssues($b)
    {
        $this->checkReplacementIssues = $b;

        return $this;
    }

    public function setIgnoreFolderArray($a)
    {
        $this->ignoreFolderArray = $a;

        return $this;
    }

    public function setAlternativePathForReplacementData($s)
    {
        $this->alternativePathForReplacementData = $s;

        return $this;
    }

    public function runActualTask($params = [])
    {
        if ($this->checkReplacementIssues) {
            $this->checkReplacementDataIssues();
        }

        //replacement data
        $replacementDataObject = new LoadReplacementData(
            $this->mu(),
            $this->alternativePathForReplacementData,
            $this->params
        );
        $replacementArray = $replacementDataObject->getReplacementArrays();

        if ($this->debug) {
            $this->mu()->colourPrint(print_r($replacementArray, 1));
        }

        //replace API
        foreach ($this->mu()->getExistingModuleDirLocationsWithThemeFolders() as $moduleOrThemeDir) {
            $textSearchMachine = new SearchAndReplaceAPI($moduleOrThemeDir);
            $textSearchMachine->setIsReplacingEnabled(true);
            $textSearchMachine->addToIgnoreFolderArray($this->ignoreFolderArray);

            foreach ($replacementArray as $path => $pathArray) {
                $path = $moduleOrThemeDir . '/' . $path ?: '';
                $path = $this->mu()->checkIfPathExistsAndCleanItUp($path);
                if (! file_exists($path)) {
                    $this->mu()->colourPrint("SKIPPING ${path}");
                } else {
                    $textSearchMachine->setSearchPath($path);
                    foreach ($pathArray as $extension => $extensionArray) {
                        $textSearchMachine->setExtensions(explode('|', $extension)); //setting extensions to search files within
                        $this->mu()->colourPrint(
                            "++++++++++++++++++++++++++++++++++++\n" .
                            "CHECKING\n" .
                            "IN ${path}\n" .
                            "FOR ${extension} FILES\n" .
                            'BASE ' . $moduleOrThemeDir . "\n" .
                            "++++++++++++++++++++++++++++++++++++\n"
                        );
                        foreach ($extensionArray as $find => $findDetails) {
                            $replace = isset($findDetails['R']) ? $findDetails['R'] : $find;
                            $comment = isset($findDetails['C']) ? $findDetails['C'] : '';
                            $ignoreCase = isset($findDetails['I']) ? $findDetails['I'] : false;
                            $caseSensitive = ! $ignoreCase;
                            //$replace = $replaceArray[1]; unset($replaceArray[1]);
                            //$fullReplacement = (isset($replaceArray[2]) ? "/* ".$replaceArray[2]." */\n" : "").$replaceArray[1];
                            $fullReplacement = $replace;
                            $isStraightReplace = true;
                            if ($comment) {
                                $isStraightReplace = false;
                            }
                            if (! $find) {
                                user_error("no find is specified, replace is: ${replace}");
                            }
                            if (! $fullReplacement) {
                                user_error("no replace is specified, find is: ${find}. We suggest setting your final replace to a single space if you would like to replace with NOTHING.");
                            }
                            $replaceKey = $isStraightReplace ? 'BASIC' : 'COMPLEX';

                            $textSearchMachine->setSearchKey($find, $caseSensitive, $replaceKey);
                            $textSearchMachine->setReplacementKey($fullReplacement);
                            if ($comment) {
                                $textSearchMachine->setComment($comment);
                            }
                            $textSearchMachine->setReplacementHeader($this->replacementHeader);
                            $textSearchMachine->startSearchAndReplace();
                        }
                        $replacements = $textSearchMachine->showFormattedSearchTotals();
                        if ($replacements) {
                        } else {
                            //flush output anyway!
                            $this->mu()->colourPrint("No replacements for  ${extension}");
                        }
                        $this->mu()->colourPrint($textSearchMachine->getOutput());
                    }
                }
            }
        }
    }

    protected function hasCommitAndPush()
    {
        return true;
    }

    /**
     * 1. check that one find is not used twice:
     * find can be found 2x
     */
    private function checkReplacementDataIssues()
    {
        $replacementDataObject = new LoadReplacementData(
            $this->mu(),
            $this->alternativePathForReplacementData,
            $this->params
        );
        $arr = $replacementDataObject->getReplacementArrays(null);
        $arr = $replacementDataObject->getReplacementArrays(null);
        $arrTos = [];

        $arrLanguages = $replacementDataObject->getLanguages();
        $fullFindArray = $replacementDataObject->getFlatFindArray();
        $fullReplaceArray = $replacementDataObject->getFlatReplacedArray();

        //1. check that one find may not stop another replacement.
        foreach ($arrLanguages as $language) {
            if (! isset($fullFindArray[$language])) {
                continue;
            }
            unset($keyOuterDoneSoFar);
            $keyOuterDoneSoFar = [];
            foreach ($fullFindArray[$language] as $keyOuter => $findStringOuter) {
                $keyOuterDoneSoFar[$keyOuter] = true;
                foreach ($fullFindArray[$language] as $keyInner => $findStringInner) {
                    if (! isset($keyOuterDoneSoFar[$keyInner])) {
                        if ($keyOuter !== $keyInner) {
                            $findStringOuterReplaced = str_replace($findStringInner, '...', $findStringOuter);
                            if ($findStringOuter === $findStringInner || $findStringOuterReplaced !== $findStringOuter) {
                                $this->mu()->colourPrint("
ERROR in ${language}: \t\t we are trying to find the same thing twice (A and B)
---- A: (${keyOuter}): \t\t ${findStringOuter}
---- B: (${keyInner}): \t\t ${findStringInner}");
                            }
                        }
                    }
                }
            }
        }

        //2. check that a replacement is not mentioned before the it is being replaced
        foreach ($arrLanguages as $language) {
            if (! isset($fullReplaceArray[$language])) {
                continue;
            }
            unset($keyOuterDoneSoFar);
            $keyOuterDoneSoFar = [];
            foreach ($fullReplaceArray[$language] as $keyOuter => $findStringOuter) {
                $keyOuterDoneSoFar[$keyOuter] = true;
                foreach ($fullFindArray[$language] as $keyInner => $findStringInner) {
                    if (isset($keyOuterDoneSoFar[$keyInner])) {
                        if ($keyOuter !== $keyInner) {
                            $findStringOuterReplaced = str_replace($findStringInner, '...', $findStringOuter);
                            if ($findStringOuter === $findStringInner || $findStringOuterReplaced !== $findStringOuter) {
                                $this->mu()->colourPrint("
ERROR in ${language}: \t\t there is a replacement (A) that was earlier tried to be found (B).
---- A: (${keyOuter}): \t\t ${findStringOuter}
---- B: (${keyInner}): \t\t ${findStringInner}");
                            }
                        }
                    }
                }
            }
        }
        $this->mu()->colourPrint('');
    }
}

sunnysideup / silverstripe-upgrade_to_silverstripe_4

Branch — master (2f7647)

SearchAndReplace::checkReplacementDataIssues() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like
