Sunnysideup\UpgradeToSilverstripe4\Tasks\IndividualTasks\InspectAPIChanges

Complexity

Total Complexity

6

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Importance

Changes	3
Bugs	1	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	runActualTask()	0	24	3
A	getDescription()	0	3	1
A	hasCommitAndPush()	0	3	1
A	getTitle()	0	3	1

<?php

namespace Sunnysideup\UpgradeToSilverstripe4\Tasks\IndividualTasks;

use Sunnysideup\UpgradeToSilverstripe4\Tasks\Task;

/**
 * Runs the silverstripe/upgrade task "inspect". See:
 * https://github.com/silverstripe/silverstripe-upgrader#inspect.
 * Once a project has all class names migrated, and is brought up to a
 * "loadable" state (that is, where all classes reference or extend real classes)
 * then the inspect command can be run to perform additional automatic code rewrites.
 * This step will also warn of any upgradable code issues that may prevent a succesful upgrade.
 */
class InspectAPIChanges extends Task
{
    protected $taskStep = 's50';

    protected $param1 = '';

    protected $param2 = '';

    protected $rootDirForCommand = '';

    protected $settings = '';

    public function getTitle()
    {
        return 'After load fixes (inspect)';
    }

    public function getDescription()
    {
        return '
            Runs the silverstripe/upgrade task "inspect". See:
            https://github.com/silverstripe/silverstripe-upgrader#inspect.
            Once a project has all class names migrated, and is brought up to a
            "loadable" state (that is, where all classes reference or extend real classes)
            then the inspect command can be run to perform additional automatic code rewrites.
            This step will also warn of any upgradable code issues that may prevent a succesful upgrade.';
    }

    public function runActualTask($params = [])
    {
        $this->mu()->execMe(
            $this->mu()->getWebRootDirLocation(),

The method getWebRootDirLocation() does not exist on Sunnysideup\UpgradeToSilverstripe4\ModuleUpgrader. Since you implemented __call, consider adding a @method annotation.

            'composer dump-autoload',
            'run composer dump-autoload to create autoload classes',
            false
        );

        foreach ($this->mu()->findNameSpaceAndCodeDirs() as $baseNameSpace => $codeDir) {
            if($this->mu->getIsModuleUpgrade()) {
                $dirToRun = $codeDir;
            } else {
                $dirToRun = dirname($codeDir);
                $rootDir = '';
            }
            $this->runSilverstripeUpgradeTask(
                'inspect',
                $this->param1 = $dirToRun,
                $this->param2 = '',
                $rootDir,

The variable $rootDir does not seem to be defined for all execution paths leading up to this point.

                $this->settings
            );
            $this->setCommitMessage('MAJOR: core upgrade to SS4: running INSPECT on ' . $this->param1);
        }
    }

    protected function hasCommitAndPush()
    {
        return true;
    }
}