Sunnysideup\UpgradeToSilverstripe4\Tasks\IndividualTasks\FinaliseUpgradeWithMergeIntoMaster

Complexity

Total Complexity

7

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Importance

Changes	3
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	runActualTask()	0	18	2
A	hasCommitAndPush()	0	3	1
A	getTitle()	0	6	2
A	getDescription()	0	11	2

<?php

namespace Sunnysideup\UpgradeToSilverstripe4\Tasks\IndividualTasks;

use Sunnysideup\UpgradeToSilverstripe4\Tasks\Task;

/**
 * Adds a new branch to your repository that is going to be used for upgrading it.
 */
class FinaliseUpgradeWithMergeIntoMaster extends Task
{
    protected $taskStep = 's70';

    public function getTitle()
    {
        if ($this->mu()->getRunIrreversibly()) {

The method getRunIrreversibly() does not exist on Sunnysideup\UpgradeToSilverstripe4\ModuleUpgrader. Since you implemented __call, consider adding a @method annotation.

            return 'Finalise Upgrade with merge into Master.';
        }
        return 'Finalise Upgrade with merge into Master (TURNED OFF)';
    }

    public function getDescription()
    {
        if ($this->mu()->getRunIrreversibly()) {
            return '
                CAREFUL - THIS STEP CAN NOT BE UNDONE. IT IS NOT RECOMMENDED!
                You should only run this upgrade task if you are 100% sure.
                You can turn off this task by setting `runIrreversibly` to false in the upgrader.
                You can do this as follows: `$upgrader->setRunIrreversibly(false)`
                 ';
        }
        return '
                This is currently turned off allowing you to run the upgrader more than once without any consequences to the project at hand.
                You can turn on this task by setting `runIrreversibly` to true in the upgrader.
                You can do this as follows: `$upgrader->setRunIrreversibly(true)`.';
    }

    public function runActualTask($params = [])
    {
        $branchName = $this->mu()->getNameOfTempBranch();

The method getNameOfTempBranch() does not exist on Sunnysideup\UpgradeToSilverstripe4\ModuleUpgrader. Since you implemented __call, consider adding a @method annotation.

        if ($this->mu()->getRunIrreversibly()) {
            $this->mu()->execMe(
                $this->mu()->getGitRootDir(),
                '
                    git checkout ' . $branchName . '
                    git pull origin ' . $branchName . '
                    git checkout master
                    git merge --squash ' . $branchName . '
                    git commit . -m "MAJOR: upgrade to Silverstripe 4"
                    git push origin master
                    git branch -D ' . $branchName . '
                    git push origin --delete ' . $branchName . '
                ',
                'merging ' . $branchName . ' into master in ' . $this->mu()->getGitRootDir(),
                false
            );
        }
    }

    protected function hasCommitAndPush()
    {
        return false;
    }
}