Sunnysideup\UpgradeToSilverstripe4\Tasks\IndividualTasks\RemoveInstallerFolder::runActualTask()

Complexity

Conditions	2
Paths	2

Size

Total Lines	16
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function runActualTask($params = []): ?string
    {
        if ($this->mu()->getIsModuleUpgrade()) {

The method getIsModuleUpgrade() does not exist on Sunnysideup\UpgradeToSilverstripe4\ModuleUpgrader. Since you implemented __call, consider adding a @method annotation.

It seems like getIsModuleUpgrade() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $command =
            'if(isset($data["extra"]["installer-name"])) { '
            . '    unset($data["extra"]["installer-name"]);'
            . '}';
            $comment = 'Removing extra.installer-name variable';
            ComposerJsonFixes::inst($this->mu())->UpdateJSONViaCommandLine(
                $this->mu()->getGitRootDir(),

It seems like getGitRootDir() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                $command,
                $comment
            );
            $this->setCommitMessage('API:  Removing extra.installer-name variable');
        }
        return null;
    }