Sunnysideup\UpgradeToSilverstripe4\Tasks\IndividualTasks\Recompose::runActualTask()

Complexity

Conditions	4
Paths	5

Size

Total Lines	20
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function runActualTask($params = []): ?string
    {
        if ($this->mu()->getIsModuleUpgrade()) {

The method getIsModuleUpgrade() does not exist on Sunnysideup\UpgradeToSilverstripe4\ModuleUpgrader. Since you implemented __call, consider adding a @method annotation.

It seems like getIsModuleUpgrade() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        } else {
            if (! $this->param1) {
                $this->param1 = '--recipe-core-constraint="' . $this->mu()->getFrameworkComposerRestraint() . '"';

The method getFrameworkComposerRestraint() does not exist on Sunnysideup\UpgradeToSilverstripe4\ModuleUpgrader. Since you implemented __call, consider adding a @method annotation.

It seems like getFrameworkComposerRestraint() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            }
            if (empty($this->rootDirForCommand)) {
                $this->rootDirForCommand = $this->mu()->getGitRootDir();

It seems like getGitRootDir() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            }
            $this->runSilverstripeUpgradeTask(
                'recompose',
                $this->param1,
                $this->param2,
                $this->rootDirForCommand,
                $this->settings
            );
            $this->setCommitMessage('API:  upgrading composer requirements to SS4 - STEP 2');
        }
        return null;
    }