Sunnysideup\UpgradeToSilverstripe4\Tasks\IndividualTasks\AddPSR4Autoloading::runActualTask()

Complexity

Conditions	4
Paths	6

Size

Total Lines	70
Code Lines	39

Duplication

Lines	0
Ratio	0 %

Importance

Changes	3
Bugs	0	Features	1

<?php
    public function runActualTask($params = []): ?string
    {
        //project composer.json
        // - app/src/...
        // - app2/src/...
        // DO FOR BOTH
        //module composor.json
        //  ONLY FOR module
        $baseCommands = '
            if(! isset($data["autoload"])) {
                $data["autoload"] = [];
            }
            if(! isset($data["autoload"]["psr-4"])) {
                $data["autoload"]["psr-4"] = [];
            }
        ';
        $addPage = '';
        if ($this->mu()->getIsModuleUpgrade()) {

It seems like getIsModuleUpgrade() must be provided by classes using this trait. How about adding it as abstract method to this trait?

The method getIsModuleUpgrade() does not exist on Sunnysideup\UpgradeToSilverstripe4\ModuleUpgrader. Since you implemented __call, consider adding a @method annotation.

            $addPage = '
            if(! isset($data["autoload"]["files"])) {
                $data["autoload"]["files"] = [
                    "app/src/Page.php",
                    "app/src/PageController.php"
                ];
            }';
        }

        $codeDirs = $this->mu()->findNameSpaceAndCodeDirs();

It seems like findNameSpaceAndCodeDirs() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $webRootLocation = $this->mu()->getWebRootDirLocation();

It seems like getWebRootDirLocation() must be provided by classes using this trait. How about adding it as abstract method to this trait?

The method getWebRootDirLocation() does not exist on Sunnysideup\UpgradeToSilverstripe4\ModuleUpgrader. Since you implemented __call, consider adding a @method annotation.

        $command = $baseCommands . $addPage;
        $comment = 'Adding autoload Page and Page controller details in ' . $webRootLocation . '/composer.json';
        ComposerJsonFixes::inst($this->mu())->UpdateJSONViaCommandLine(
            $webRootLocation,
            $command,
            $comment
        );
        foreach ($codeDirs as $baseNameSpace => $codeDir) {
            $location = trim(str_replace($webRootLocation, '', $codeDir), '/') . '/';

It seems like $webRootLocation can also be of type Sunnysideup\UpgradeToSilverstripe4\ModuleUpgrader and Sunnysideup\UpgradeToSilverstripe4\Traits\Creator; however, parameter $search of str_replace() does only seem to accept string|string[], maybe add an additional type check?

            //update webroot composer file
            //location:
            $command = $baseCommands . '
            $data["autoload"]["psr-4"]["' . $this->doubleSlash($baseNameSpace) . '"] = "' . $location . '";';
            $comment = 'Adding autoload psr-4 details in ' .
                $webRootLocation . '/composer.json: ' .
                $baseNameSpace . ' => ' . $location;
            ComposerJsonFixes::inst($this->mu())->UpdateJSONViaCommandLine(
                $webRootLocation,
                $command,
                $comment
            );
            if ($this->mu()->getIsModuleUpgrade()) {
                $moduleLocation = dirname($codeDir);
                $location = trim(basename($codeDir), '/') . '/';
                $command = $baseCommands . '
                $data["autoload"]["psr-4"]["' .
                $this->doubleSlash($baseNameSpace) . '"] = "' .
                ltrim($location, '/') . '";';
                $comment = 'Adding autoload psr-4 details in ' .
                    $moduleLocation . '/composer.json: ' .
                    $baseNameSpace . ' => ' . $location;
                ComposerJsonFixes::inst($this->mu())->UpdateJSONViaCommandLine(
                    $moduleLocation,
                    $command,
                    $comment
                );
            }
        }
        Composer::inst($this->mu())
            ->DumpAutoload();
        return null;
    }