Sunnysideup\UpgradeToSilverstripe4\Api\CreateListOfTasks::run()

Complexity

Conditions	9
Paths	32

Size

Total Lines	60
Code Lines	48

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

<?php
    public function run()
    {
        $this->myMu = ModuleUpgrader::create();

The property myMu does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $html = '';
        foreach (array_keys($this->mu()->getAvailableRecipes()) as $recipeKey) {

It seems like getAvailableRecipes() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $this->mu()->applyRecipe($recipeKey);

It seems like applyRecipe() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $html .= '<h1>List of Tasks in run order for recipe: ' . $recipeKey . '</h1>';
            $count = 0;
            $totalCount = count($this->mu()->getListOfTasks());

It seems like getListOfTasks() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $previousStep = '';
            foreach ($this->mu()->getListOfTasks() as $class => $params) {
                $properClass = current(explode('-', $class));
                $nameSpacesArray = explode('\\', $class);
                $shortClassCode = end($nameSpacesArray);
                if (! class_exists($properClass)) {
                    $properClass = $this->mu()->getDefaultNamespaceForTasks() . '\\' . $properClass;

It seems like getDefaultNamespaceForTasks() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                }
                if (class_exists($properClass)) {
                    $count++;
                    // $runItNow = $this->mu()->shouldWeRunIt((string) $shortClassCode);
                    $params['taskName'] = $shortClassCode;
                    $obj = $properClass::create($this, $params);
                    if ($obj->getTaskName()) {
                        $params['taskName'] = $obj->getTaskName();
                    }
                    $reflectionClass = new \ReflectionClass($properClass);
                    $path = 'https://github.com/sunnysideup/silverstripe-upgrade_to_silverstripe_4/tree/master/src/';
                    $path .= str_replace('\\', '/', $reflectionClass->getName()) . '.php';
                    $path = str_replace('Sunnysideup/UpgradeToSilverstripe4/', '', $path);
                    $currentStepCode = $obj->getTaskStepCode();
                    $currentStep = $obj->getTaskStep($currentStepCode);
                    if ($currentStepCode === 's00') {
                        //do nothing when it is an anytime step
                    } else {
                        if ($previousStep !== $currentStep) {
                            $html .= '<h2>' . $currentStep . '</h2>';
                        }
                        $previousStep = $currentStep;
                    }
                    $html .= '<h4>' . $count . '/' . $totalCount . ': ' . $obj->getTitle() . '</h4>';
                    $html .= '<p>' . $obj->getDescription() . '<br />';
                    $html .= '<strong>Class Code: </strong>' . $class;
                    $html .= '<br /><strong>Class Name: </strong>';
                    $html .= '<a href="' . $path . '">' . $reflectionClass->getShortName() . '</a>';
                    $html .= '</p>';
                    $obj = $properClass::deleteTask($params);

The assignment to $obj is dead and can be removed.

                } else {
                    user_error($properClass . ' could not be found as class', E_USER_ERROR);
                }
            }
        }
        $dir = $this->mu()->checkIfPathExistsAndCleanItUp(__DIR__ . '/../../docs/en/');

It seems like checkIfPathExistsAndCleanItUp() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        if ($dir) {
            $html = str_replace(' _', ' \_', $html);
            file_put_contents(
                rtrim($dir, '/') . '/AvailableTasks.md',
                $html
            );
        } else {
            user_error('Coult not find ' . $dir . ' directory');
        }