Sunnysideup\UpgradeToSilverstripe4\Tasks\IndividualTasks\Upgrade

Complexity

Total Complexity

5

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Importance

Changes	4
Bugs	3	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getTitle()	0	3	1
A	getDescription()	0	3	1
A	runActualTask()	0	17	2
A	hasCommitAndPush()	0	3	1

<?php

namespace Sunnysideup\UpgradeToSilverstripe4\Tasks\IndividualTasks;

use Sunnysideup\UpgradeToSilverstripe4\Tasks\Task;

/**
 * Runs the silverstripe upgrade task 'upgrade'.
 * More information on this task at https://github.com/silverstripe/silverstripe-upgrader#upgrade
 */
class Upgrade extends Task
{
    protected $taskStep = 's40';

    protected $param1 = '';

    protected $param2 = '';

    protected $rootDirForCommand = '';

    /**
     * @todo Prompt does not show up sometimes, leaving the program hanging
     * --prompt
     */
    protected $settings = '';

    public function getTitle()
    {
        return 'Update Code';
    }

    public function getDescription()
    {
        return '
            Runs the silverstripe/upgrade task "upgrade". See:
            Upgrade a variety of stuff (e.g. update reference with namespaces)
            https://github.com/silverstripe/silverstripe-upgrader#upgrade';
    }

    public function runActualTask($params = []): ?string
    {
        $this->mu()->setBreakOnAllErrors(true);

It seems like setBreakOnAllErrors() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        foreach ($this->mu()->findNameSpaceAndCodeDirs() as $codeDir) {

It seems like findNameSpaceAndCodeDirs() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $actualDir = dirname($codeDir);
            $this->param1 = $actualDir;
            $this->runSilverstripeUpgradeTask(
                'upgrade',
                $this->param1,
                $this->param2,
                $this->rootDirForCommand,
                $this->settings
            );
            $this->setCommitMessage('API:  core upgrade to SS4 - STEP 1 (upgrade) on ' . $actualDir);
        }
        $this->mu()->setBreakOnAllErrors(false);
        return null;
    }

    protected function hasCommitAndPush()
    {
        return true;
    }
}