Sunnysideup\UpgradeToSilverstripe4\Tasks\IndividualTasks\SwitchPhpVersion

Complexity

Total Complexity

8

Size/Duplication

Total Lines	58
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	hasCommitAndPush()	0	3	1
A	getTitle()	0	3	1
A	getVersion()	0	3	1
A	getDescription()	0	3	1
A	setVersion()	0	4	1
A	runActualTask()	0	19	3

<?php

namespace Sunnysideup\UpgradeToSilverstripe4\Tasks\IndividualTasks;

use Sunnysideup\PHP2CommandLine\PHP2CommandLineSingleton;
use Sunnysideup\UpgradeToSilverstripe4\Tasks\Task;

/**
 * This task adds a legacy branch to the git repo of the original to act as a backup/legacy version for
 * holding a version of the module before it was changed
 */
class SwitchPhpVersion extends Task
{
    protected $taskStep = 's10';

    protected $defaultVersion = '7.1';

    public function getTitle()
    {
        return 'Change PHP version';
    }

    public function getDescription()
    {
        return '
            This requires https://github.com/sunnysideup/silverstripe-switch-php-versions to be installed';
    }

    protected $version = '';

    public function setVersion(string $version)
    {
        $this->version = $version;
        return $this;
    }

    public function getVersion(): string
    {
        return $this->version;
    }

    /**
     * [runActualTask description]
     * @param  array  $params not currently used for this task
     */
    public function runActualTask($params = []): ?string
    {
        $version = $this->version ?: $this->defaultVersion;
        if (PHP2CommandLineSingleton::commandExists('php-switch')) {
            $this->mu()->execMe(

It seems like execMe() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                $this->mu()->getWebRootDirLocation(),

It seems like getWebRootDirLocation() must be provided by classes using this trait. How about adding it as abstract method to this trait?

The method getWebRootDirLocation() does not exist on Sunnysideup\UpgradeToSilverstripe4\ModuleUpgrader. Since you implemented __call, consider adding a @method annotation.

It seems like $this->mu()->getWebRootDirLocation() can also be of type Sunnysideup\UpgradeToSilverstripe4\ModuleUpgrader and Sunnysideup\UpgradeToSilverstripe4\Traits\Creator and null; however, parameter $newDir of Sunnysideup\UpgradeToSilverstripe4\ModuleUpgrader::execMe() does only seem to accept string, maybe add an additional type check?

                'php-switch ' . $version,
                'switching to PHP version ' . $version,
                false
            );
        } else {
            $this->mu()->execMe(
                $this->mu()->getWebRootDirLocation(),
                'echo \'switch to PHP Version: ' . $version . '\'',
                'Reminder to switch to PHP ' . $version,
                false
            );
        }
        return null;
    }

    protected function hasCommitAndPush()
    {
        return false;
    }
}