Sunnysideup\UpgradeToSilverstripe4\Tasks\IndividualTasks\RewriteConstructors

Complexity

Total Complexity

4

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getDescription()	0	3	1
A	getTitle()	0	3	1
A	hasCommitAndPush()	0	3	1
A	runActualTask()	0	9	1

<?php

namespace Sunnysideup\UpgradeToSilverstripe4\Tasks\IndividualTasks;

use Sunnysideup\UpgradeToSilverstripe4\Tasks\Task;

/**
 * Delete the web root directory to allow for a fresh install.
 */
class RewriteConstructors extends Task
{
    protected $taskStep = 's00';

    public function getTitle()
    {
        return 'Constructor rewrite';
    }

    public function getDescription()
    {
        return '
            rewrites deprecated constructors to be compatible with PHP7.';
    }

    public function runActualTask($params = []): ?string
    {
        $this->mu()->execMe(

It seems like execMe() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $this->mu()->getAboveWebRootDirLocation(),

The method getAboveWebRootDirLocation() does not exist on Sunnysideup\UpgradeToSilverstripe4\ModuleUpgrader. Since you implemented __call, consider adding a @method annotation.

It seems like $this->mu()->getAboveWebRootDirLocation() can also be of type Sunnysideup\UpgradeToSilverstripe4\ModuleUpgrader and Sunnysideup\UpgradeToSilverstripe4\Traits\Creator and null; however, parameter $newDir of Sunnysideup\UpgradeToSilverstripe4\ModuleUpgrader::execMe() does only seem to accept string, maybe add an additional type check?

It seems like getAboveWebRootDirLocation() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            'php ' . $this->mu()->getWebRootDirLocation() . '--disable-class-file-create',

It seems like getWebRootDirLocation() must be provided by classes using this trait. How about adding it as abstract method to this trait?

The method getWebRootDirLocation() does not exist on Sunnysideup\UpgradeToSilverstripe4\ModuleUpgrader. Since you implemented __call, consider adding a @method annotation.

            'create upgrade directory: ' . $this->mu()->getWebRootDirLocation(),
            false
        );
        return null;
    }

    protected function hasCommitAndPush()
    {
        return false;
    }
}