Sunnysideup\UpgradeToSilverstripe4\Tasks\IndividualTasks\DoMigrateSiteTreeLinkingTask

Complexity

Total Complexity

5

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getTitle()	0	3	1
A	getDescription()	0	3	1
A	hasCommitAndPush()	0	3	1
A	runActualTask()	0	12	2

<?php

namespace Sunnysideup\UpgradeToSilverstripe4\Tasks\IndividualTasks;

use Sunnysideup\UpgradeToSilverstripe4\Tasks\Task;

/**
 * Run a dev/build as a smoke test to see if all is well
 */
class DoMigrateSiteTreeLinkingTask extends Task
{
    protected $taskStep = 's60';

    public function getTitle()
    {
        return 'Run dev/tasks/MigrateSiteTreeLinkingTask';
    }

    public function getDescription()
    {
        return '
            Run a dev/tasks/MigrateSiteTreeLinkingTask to upgrade sitetree links.';
    }

    /**
     * @param array $params
     */
    public function runActualTask($params = []): ?string
    {
        if ($this->mu()->getIsModuleUpgrade()) {

It seems like getIsModuleUpgrade() must be provided by classes using this trait. How about adding it as abstract method to this trait?

The method getIsModuleUpgrade() does not exist on Sunnysideup\UpgradeToSilverstripe4\ModuleUpgrader. Since you implemented __call, consider adding a @method annotation.

            return null;
        }
        $this->mu()->execMe(

It seems like execMe() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $this->mu()->getWebRootDirLocation(),

It seems like $this->mu()->getWebRootDirLocation() can also be of type Sunnysideup\UpgradeToSilverstripe4\ModuleUpgrader and Sunnysideup\UpgradeToSilverstripe4\Traits\Creator and null; however, parameter $newDir of Sunnysideup\UpgradeToSilverstripe4\ModuleUpgrader::execMe() does only seem to accept string, maybe add an additional type check?

The method getWebRootDirLocation() does not exist on Sunnysideup\UpgradeToSilverstripe4\ModuleUpgrader. Since you implemented __call, consider adding a @method annotation.

It seems like getWebRootDirLocation() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            'php vendor/silverstripe/framework/cli-script.php dev/tasks/MigrateSiteTreeLinkingTask flush=all',
            'MigrateSiteTreeLinkingTask is running',
            false
        );
        return null;
    }

    protected function hasCommitAndPush()
    {
        return false;
    }
}