Sunnysideup\UpgradeToSilverstripe4\Tasks\IndividualTasks\DatabaseMigrationLegacyYML

Complexity

Total Complexity

6

Size/Duplication

Total Lines	65
Duplicated Lines	0 %

Importance

Changes	3
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getDescription()	0	3	1
A	getTitle()	0	3	1
A	hasCommitAndPush()	0	3	1
A	runActualTask()	0	41	3

<?php

namespace Sunnysideup\UpgradeToSilverstripe4\Tasks\IndividualTasks;

use Sunnysideup\UpgradeToSilverstripe4\Api\FileSystemFixes;
use Sunnysideup\UpgradeToSilverstripe4\Tasks\Task;

/**
 * This task adds a legacy branch to the git repo of the original to act as a backup/legacy version for
 * holding a version of the module before it was changed
 */
class DatabaseMigrationLegacyYML extends Task
{
    protected $taskStep = 's50';

    public function getTitle()
    {
        return 'Copy legacy data to database migration file';
    }

    public function getDescription()
    {
        return '
            Take the data from .upgrade.yml and move it to _config/legay.yml with a header.';
    }

    /**
     * [runActualTask description]
     * @param  array  $params not currently used for this task
     */
    public function runActualTask($params = []): ?string
    {
        foreach ($this->mu()->getExistingModuleDirLocations() as $moduleDir) {

It seems like getExistingModuleDirLocations() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $oldFile = $moduleDir . '/.upgrade.yml';
            $newFile = $moduleDir . '/_config/database.legacy.yml';
            $tmpFile = $moduleDir . '/_config/database.legacy.yml.tmp';
            $mvStatement = $newFile . ' > ' . $tmpFile . ' && mv ' . $tmpFile . ' ' . $newFile;
            if (! file_exists($oldFile)) {
                return $oldFile . ' NOT FOUND!!!';
            }
            $dir = dirname($newFile);
            FileSystemFixes::inst($this->mu())
                ->mkDir($dir)
                ->copyFolderOrFile($oldFile, $newFile);

            $this->mu()->execMe(

It seems like execMe() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                $moduleDir,
                'sed \'1d\' ' . $mvStatement,
                'removing the first line and placing into temp file',
                false
            );
            $this->mu()->execMe(
                $moduleDir,
                "sed -i -e 's/^/  /' " . $newFile,
                'adding two additional spaces to the start of each line',
                false
            );
            $this->mu()->execMe(
                $moduleDir,
                'echo \'  classname_value_remapping:\' | cat - ' . $mvStatement,
                'adding `  classname_value_remapping:` to the start of ' . $newFile,
                false
            );
            $this->mu()->execMe(
                $moduleDir,
                'echo \'SilverStripe\ORM\DatabaseAdmin:\' | cat - ' . $mvStatement,
                'adding `SilverStripe\ORM\DatabaseAdmin:` to the start of ' . $newFile,
                false
            );
        }
        return null;
    }

    protected function hasCommitAndPush()
    {
        return true;
    }
}