Sunnysideup\UpgradeToSilverstripe4\Tasks\IndividualTasks\ChangeEnvironment

Complexity

Total Complexity

6

Size/Duplication

Total Lines	49
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getDescription()	0	3	1
A	getTitle()	0	3	1
A	hasCommitAndPush()	0	6	2
A	runActualTask()	0	15	2

<?php

namespace Sunnysideup\UpgradeToSilverstripe4\Tasks\IndividualTasks;

use Sunnysideup\UpgradeToSilverstripe4\Tasks\Task;

/**
 * Runs the silverstripe/upgrade task "environment". See:
 * https://github.com/silverstripe/silverstripe-upgrader#environment.
 * You can use this command to migrate an SilverStripe 3 _ss_environment.php
 * file to the .env format used by SilverStripe 4.'
 */
class ChangeEnvironment extends Task
{
    protected $taskStep = 's20';

    protected $rootDirForCommand = '';

    protected $param1 = '';

    protected $param2 = '';

    protected $settings = '';

    public function getTitle()
    {
        return 'Change Environment File';
    }

    public function getDescription()
    {
        return '
            Runs the silverstripe/upgrade task "environment". See:
            https://github.com/silverstripe/silverstripe-upgrader#environment.
            You can use this command to migrate a SilverStripe 3 _ss_environment.php
            file to the Silverstripe 4 .env format.';
    }

    public function runActualTask($params = []): ?string
    {
        if ($this->mu()->getIsModuleUpgrade()) {

It seems like getIsModuleUpgrade() must be provided by classes using this trait. How about adding it as abstract method to this trait?

The method getIsModuleUpgrade() does not exist on Sunnysideup\UpgradeToSilverstripe4\ModuleUpgrader. Since you implemented __call, consider adding a @method annotation.

            //do nothing
        } else {
            $this->runSilverstripeUpgradeTask(
                'environment',
                $this->param1,
                $this->param2,
                $this->rootDirForCommand,
                $this->settings
            );
            $this->setCommitMessage('API:  changing environment file(s)');
        }
        return null;
    }

    protected function hasCommitAndPush()
    {
        if ($this->mu()->getIsModuleUpgrade()) {
            return false;
        }
        return true;
    }
}