Sunnysideup\UpgradeToSilverstripe4\Tasks\IndividualTasks\AddTempUpgradeBranch

Complexity

Total Complexity

6

Size/Duplication

Total Lines	38
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getTitle()	0	3	1
A	getDescription()	0	7	3
A	runActualTask()	0	13	1
A	hasCommitAndPush()	0	3	1

<?php

namespace Sunnysideup\UpgradeToSilverstripe4\Tasks\IndividualTasks;

use Sunnysideup\UpgradeToSilverstripe4\Tasks\Helpers\Git;
use Sunnysideup\UpgradeToSilverstripe4\Tasks\Task;

/**
 * Adds a new branch to your repository that is going to be used for upgrading it.
 */
class AddTempUpgradeBranch extends Task
{
    protected $taskStep = 's10';

    public function getTitle()
    {
        return 'Add Upgrade Branch';
    }

    public function getDescription()
    {
        return '
            Adds a new branch ' . $this->mu()->getNameOfTempBranch() . '

It seems like getNameOfTempBranch() must be provided by classes using this trait. How about adding it as abstract method to this trait?

The method getNameOfTempBranch() does not exist on Sunnysideup\UpgradeToSilverstripe4\ModuleUpgrader. Since you implemented __call, consider adding a @method annotation.

            based on ' . $this->mu()->getNameOfUpgradeStarterBranch() . '

The method getNameOfUpgradeStarterBranch() does not exist on Sunnysideup\UpgradeToSilverstripe4\ModuleUpgrader. Since you implemented __call, consider adding a @method annotation.

It seems like getNameOfUpgradeStarterBranch() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            (both names can be customised)
            to your repository (' . ($this->mu()->getVendorName() ?: 'Vendor Name') . '/' . ($this->mu()->getPackageName() ?: 'Package Name') . ')

The method getVendorName() does not exist on Sunnysideup\UpgradeToSilverstripe4\ModuleUpgrader. Since you implemented __call, consider adding a @method annotation.

It seems like getVendorName() must be provided by classes using this trait. How about adding it as abstract method to this trait?

It seems like getPackageName() must be provided by classes using this trait. How about adding it as abstract method to this trait?

The method getPackageName() does not exist on Sunnysideup\UpgradeToSilverstripe4\ModuleUpgrader. Since you implemented __call, consider adding a @method annotation.

            that is going to be used for upgrading it.
            If it already exists then it will first be DELETED!';
    }

    public function runActualTask($params = []): ?string
    {
        Git::inst($this->mu())
            ->deleteBranch(
                $this->mu()->getGitRootDir(),

It seems like getGitRootDir() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                $this->mu()->getNameOfTempBranch()
            )
            ->createNewBranch(
                $this->mu()->getGitRootDir(),
                $this->mu()->getNameOfTempBranch(),
                $this->mu()->getNameOfUpgradeStarterBranch()
            );
        return null;
    }

    protected function hasCommitAndPush()
    {
        return true;
    }
}