Sunnysideup\UpgradeToSilverstripe4\Tasks\IndividualTasks\AddLicenceToProjectForRecomposeTask

Complexity

Total Complexity

6

Size/Duplication

Total Lines	36
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getDescription()	0	3	1
A	getTitle()	0	3	1
A	runActualTask()	0	16	2
A	hasCommitAndPush()	0	3	2

<?php

namespace Sunnysideup\UpgradeToSilverstripe4\Tasks\IndividualTasks;

use Sunnysideup\UpgradeToSilverstripe4\Tasks\Helpers\ComposerJsonFixes;
use Sunnysideup\UpgradeToSilverstripe4\Tasks\Task;

/**
 * Replaces the composer type from silverstripe-module to silverstripe-vendormodule in line with SS4 standards.
 * This means your module will be installed in the vendor folder after this upgrade.
 */
class AddLicenceToProjectForRecomposeTask extends Task
{
    protected $taskStep = 's50';

    public function getTitle()
    {
        return 'Add license to project to ensure recompose works.';
    }

    public function getDescription()
    {
        return '
            Adds the license = proprietary to the composer file to ensure the recompose task works.';
    }

    public function runActualTask($params = []): ?string
    {
        if ($this->mu()->getIsProjectUpgrade()) {

It seems like getIsProjectUpgrade() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $comment = 'add license';
            $command =
            'if(! isset($data["license"])) { '
            . '    $data["license"] = proprietary";'
            . '}';
            ComposerJsonFixes::inst($this->mu())->UpdateJSONViaCommandLine(
                $this->mu()->getGitRootDir(),

It seems like getGitRootDir() must be provided by classes using this trait. How about adding it as abstract method to this trait?

                $command,
                $comment
            );
            $this->setCommitMessage('API:  ' . $this->getTitle());
        }
        return null;
    }

    protected function hasCommitAndPush()
    {
        return $this->mu()->getIsModuleUpgrade() ? false : true;

The method getIsModuleUpgrade() does not exist on Sunnysideup\UpgradeToSilverstripe4\ModuleUpgrader. Since you implemented __call, consider adding a @method annotation.

It seems like getIsModuleUpgrade() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }
}