sunnysideup / silverstripe-update_note

code/model/UpdateNoteExtension.php

<?php



class UpdateNoteExtension extends DataExtension

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $has_many = array(

The property $has_many is not used and could be removed.

        'UpdateNotes' => 'UpdateNote'
    );

    private static $seconds_grace = 600;

The property $seconds_grace is not used and could be removed.

    private static $latest_limit = 600;

The property $latest_limit is not used and could be removed.

    private static $_run_once_only = array();

    /**
     * Event handler called after writing to the database.
     */
    public function onAfterWrite()
    {
        parent::onAfterWrite();
        $id = $this->owner->ID;
        $class = $this->owner->ClassName;
        $userID = Member::currentUserID();
        $filter = array(
            'UpdateNoteRecordID' => $id,
            'UpdateNoteRecordClass' => $class,
            'UpdatedByID' => $userID
        );
        $key = implode('_', $filter);
        if (! isset(self::$_run_once_only[$key])) {
            self::$_run_once_only[$key] = true;
            $now = SS_Datetime::now()->Rfc2822();
            $gracePointInTime = strtotime($now) - Config::inst()->get('UpdateNoteExtension', 'seconds_grace');
            $log = DataObject::get_one(
                'UpdateNote',
                $filter,
                $cacheDataObjectGetOne = false,
                array('Created' => 'DESC')

array('Created' => 'DESC') is of type array<string,string,{"Created":"string"}>, but the function expects a string.

            );
            if ($log) {
                $editPointInTime = strtotime($log->Created);
                debug::log(Date('l jS \of F Y h:i:s A', $editPointInTime).'...'.Date('l jS \of F Y h:i:s A', $gracePointInTime));
                if ($editPointInTime < $gracePointInTime) {
                    $log = null;
                }
            }
            if ($log && $log->exists()) {

This if statement is empty and can be removed.

                //already exists ...
            } else {
                $log = UpdateNote::create($filter);
            }
            $log->write();
        }
    }

    /**
     * Update Fields
     * @return FieldList
     */
    public function updateCMSFields(FieldList $fields)
    {
        $owner = $this->owner;

$owner is not used, you could remove the assignment.

        $name = Injector::inst()->get('UpdateNote')->i18n_plural_name();
        $fields->addFieldToTab(
            'Root.'.$name,
            GridField::create(
                'UpdateNotes',
                $name,
                $this->owner->UpdateNotes(),
                GridFieldConfig_RecordEditor::create()
            )
        );

        return $fields;
    }

    /**
     * Event handler called before deleting from the database.
     */
    public function onBeforeDelete()
    {
        foreach ($this->owner->UpdateNotes() as $note) {
            $note->delete();
        }
    }


    public function LatestUpdateNotes()

The return type could not be reliably inferred; please add a @return annotation.

    {
        return $this->owner->UpdateNotes()
            ->limit(Config::inst()->get('xx', 'latest_limit'));
    }
}