UpdateNoteModelAdmin

Complexity

Total Complexity

3

Size/Duplication

Total Lines	24
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	getList()	0	8	3

<?php


class UpdateNoteModelAdmin extends ModelAdmin

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    public $showImportForm = false;

    private static $managed_models = array('UpdateNote', 'UpdateNoteToBeCompleted');

Consider using a different property name as you override a private property of the parent class.

The property $managed_models is not used and could be removed.

    private static $url_segment = 'updatenotes';

Consider using a different property name as you override a private property of the parent class.

The property $url_segment is not used and could be removed.

    private static $menu_title = 'Update Log';

Consider using a different property name as you override a private property of the parent class.

The property $menu_title is not used and could be removed.

    private static $menu_icon = 'update_note/images/treeicons/UpdateNoteModelAdmin.png';

Consider using a different property name as you override a private property of the parent class.

The property $menu_icon is not used and could be removed.

    /**
     * @return DataList
     */
    public function getList()
    {
        $list = parent::getList();
        if (is_subclass_of($this->modelClass, 'UpdateNoteToBeCompleted') || $this->modelClass === 'UpdateNoteToBeCompleted') {
            $list = $list->filter(array('FutureReminderCompleted' => 0));
        }
        return $list;
    }
}