TypographyTestPage_Controller

Complexity

Total Complexity

17

Size/Duplication

Total Lines	117
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	7

Importance

Changes

0

12 Methods

Rating	Name	Duplication	Size	Complexity
A	get_css_folder()	0	15	3
A	init()	0	5	1
A	index()	0	6	1
A	ShowFirstHeading()	0	4	1
A	colours()	0	12	2
A	Form()	0	4	1
A	TestForm()	0	4	1
A	typographyhtml()	0	4	1
A	RandomLinkExternal()	0	4	1
A	RandomLinkInternal()	0	4	1
A	SiteColours()	0	9	2
A	replacecolours()	0	9	2

<?php

/**
 * Add a page to your site that allows you to view all the html that can be used in the typography section - if applied correctly.
 * TO DO: add a testing sheet with a list of checks to be made (e.g. italics, bold, paragraphy) - done YES / NO, a date and a person who checked it (member).
 */

class TypographyTestPage_Controller extends Page_Controller

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    /**
     * @var string
     */
    private static $include_first_heading_in_test_copy = false;

The property $include_first_heading_in_test_copy is not used and could be removed.

    /**
     * @var string
     */
    private static $css_folder = '';

The property $css_folder is not used and could be removed.

    /**
     * use this to set up alternative form
     * formats
     * @var string
     */
    private static $form_class_name = "Form";

The property $form_class_name is not used and could be removed.

    public static function get_css_folder()

The return type could not be reliably inferred; please add a @return annotation.

    {
        if (Config::inst()->get("TypographyTestPage_Controller", "css_folder")) {
            $folder = Config::inst()->get("TypographyTestPage_Controller", "css_folder");
        } else {
            $folder = "themes/".SSViewer::current_theme()."/css/";

The method SSViewer::current_theme() has been deprecated with message: 4.0 Use the "SSViewer.theme" config setting instead

        }
        $fullFolder = Director::baseFolder().'/'.$folder;
        if (!file_exists($fullFolder)) {
            @mkdir($fullFolder);

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

            //user_error("could not find the default CSS folder $fullFolder");
            $folder = '';
        }
        return $folder;
    }

    private static $allowed_actions = array(

The property $allowed_actions is not used and could be removed.

        "colours" => "ADMIN",
        "replacecolours" => "ADMIN"
    );

    public function init()
    {
        parent::init();
        Page_Controller::init();
    }

    public function index()

The return type could not be reliably inferred; please add a @return annotation.

    {
        $this->Content = $this->typographyhtml();
        $this->Title = 'Typography Test Page';
        return $this->renderWith('Page');
    }

    public function ShowFirstHeading()
    {
        return Config::inst()->get("TypographyTestPage_Controller", "include_first_heading_in_test_copy");
    }

    public function colours()
    {
        $baseFolder = Director::baseFolder();
        require($baseFolder.'/typography/thirdparty/colourchart/csscolorchart.php');
        $cssPath = array($baseFolder.'/themes/', $baseFolder.$this->project()."css/");
        echo '<h1>CSS colors found in: ' .
            (is_array($cssPath)?implode($cssPath, ', '):$cssPath) . '</h1>';
        $themes = new CssColorChart();
        $colourList = $themes->listColors($cssPath);
        $html = DBField::create_field("HTMLText", $colourList);
        echo $html;
    }

    public function Form()
    {
        return TypographyTestForm::create($this, 'TestForm');
    }

    public function TestForm($data)
    {
        $this->redirectBack();
    }

    protected function typographyhtml()

The return type could not be reliably inferred; please add a @return annotation.

    {
        return $this->renderWith('TypographySample');
    }

    public function RandomLinkExternal()
    {
        return "http://www.google.com/?q=".rand(0, 100000);
    }

    public function RandomLinkInternal()
    {
        return "/?q=".rand(0, 100000);
    }

    public function SiteColours()
    {
        if ($folder = TypographyTestPage_Controller::get_css_folder()) {
            Requirements::themedCSS("CssColorChart", "typography");
            //Requirements::javascript("typography/javascript/CssColorChart.js");

72% of this comment could be valid code. Did you maybe forget this after debugging?

            $cssColorChart = new CssColorChart();
            return $cssColorChart->listColors(Director::baseFolder()."/".$folder);
        }
    }

    public function replacecolours()

The return type could not be reliably inferred; please add a @return annotation.

    {
        if ($folder = Config::inst()->get("TypographyTestPage_Controller", "css_folder")) {

$folder is not used, you could remove the assignment.

            require_once(Director::baseFolder()."/typography/thirdparty/csscolorchart.php");
            $cssColorChart = new CssColorChart();
            return $cssColorChart->replaceColours(Director::baseFolder()."/".Config::inst()->get("TypographyTestPage_Controller", "css_folder"));

The method replaceColours() does not seem to exist on object<CssColorChart>.

        }
        return "no folder specified, use TypographyTestPage_Controller::set_css_folder()";
    }
}