TrainingSignupForm

Complexity

Total Complexity

19

Size/Duplication

Total Lines	114
Duplicated Lines	11.4 %

Coupling/Cohesion

Components	1
Dependencies	12

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
D	__construct()	0	43	9
D	doSave()	13	36	10

<?php

class TrainingSignupForm extends Form

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    public function __construct($controller, $name, $title = "Training")
    {
        if ($member = Member::currentUser()) {

This if statement is empty and can be removed.

        } else {
            $member = new Member();
        }
        $fields = new FieldList(
            new HeaderField($title)
        );
        $extraFields = $member->getTrainingFields();
        foreach ($extraFields as $field) {
            if ("Password" == $field->title() && $member->ID) {

This if statement is empty and can be removed.

            } elseif ("Password" == $field->title()) {
                $fields->push(new ConfirmedPasswordField("Password"));
            } else {
                $fields->push($field);
            }
        }
        $actions = new FieldList(
                new FormAction("doSave", "Sign Up Now")
        );
        $requiredFields = new RequiredFields(
            "FirstName",
            "Surname",
            "Email",
            "Password"
        );
        if ($controller->Options) {
            $array = array();
            $explodedOptions = explode(",", $controller->Options);
            foreach ($explodedOptions as $option) {
                $option = trim(Convert::raw2att($option));
                $array[$option] = $option;
            }
            if (count($array)) {
                $fields->push(new DropdownField("SelectedOption", "Select Option", $array));
            }
        }
        $fields->push(new TextField("BookingCode", "Booking Code (if any)"));
        parent::__construct($controller, $name, $fields, $actions, $requiredFields);
        $this->loadNonBlankDataFrom($member);

The method loadNonBlankDataFrom does not exist on object<TrainingSignupForm>? Since you implemented __call, maybe consider adding a @method annotation.

        return $this;

Constructors do not have meaningful return values, anything that is returned from here is discarded. Are you sure this is correct?

    }

    public function doSave($data, $form)

The return type could not be reliably inferred; please add a @return annotation.

The parameter $form is not used and could be removed.

    {
        if (isset($data['Password']) && is_array($data['Password'])) {

This code seems to be duplicated across your project.

            $data['Password'] = $data['Password']['_Password'];
        }

        // We need to ensure that the unique field is never overwritten
        $uniqueField = Member::get_unique_identifier_field();

The method Member::get_unique_identifier_field() has been deprecated with message: 4.0 Use the "Member.unique_identifier_field" config setting instead

        if (isset($data[$uniqueField])) {

This code seems to be duplicated across your project.

            $SQL_unique = Convert::raw2sql($data[$uniqueField]);
            $existingUniqueMember = Member::get()->filter(array($uniqueField => $SQL_unique))->first();
            if ($existingUniqueMember && $existingUniqueMember->exists()) {
                if (Member::currentUserID() != $existingUniqueMember->ID) {
                    die("current member does not match enrolled member.");

The method doSave() contains an exit expression.

                    return false;

return false; does not seem to be reachable.

                }
            }
        }
        $member = Member::currentUser();
        if (!$member) {
            $member = new Member();
        }

        $member->update($data);
        $member->write();
        $arrayExtraFields = array();
        if (isset($data["SelectedOption"])) {
            $arrayExtraFields["SelectedOption"] = $data["SelectedOption"];
        }
        if (isset($data["BookingCode"])) {
            $arrayExtraFields["BookingCode"] = $data["BookingCode"];
        }
        $this->controller->addAttendee($member, $arrayExtraFields);
        $this->redirect($this->getController()->Link("thankyou"));

The call to Controller::Link() has too many arguments starting with 'thankyou'.

The method redirect() does not exist on TrainingSignupForm. Did you maybe mean getRedirectToFormOnValidationError()?

        return;
    }

/*

I don't think saveInto can deal with saving many_many relations
currently, unless your Post class has a customised method called
saveCategories($data) in which you simply add the code like this:

$this->Categories->add($item, $extraFields),
where $item should be the category's ID (you can get it from $data),
depending on how your Form is stuctured, your $extraFields should be
either from $data, or assigned from backend by you before you call
saveInto in doPostForm or before you call $this->Categories->add
saveCetegories.

The name of saving many_many relation (here refer to saveCategories)
must bond with your field name, ie, if your field is called:
new DropdownField('GoneWithWind',"Category", $catOptions), the save
method must name as saveGoneWithWind().

if PrimeCategory need to be also submitted from from, your your can
get CategoryID and PrimeCategory in an array from $data, try this:
new DropdownField('Categories[CetegoryID]',"Category", $catOptions),
new CheckboxField('Categories[PrimeCategory]', "Prime Category?"),
The $data[Categories] submitted from from is a array.

In addition, dropdown field is not supposed to simulate many_many
relation, CheckboxSetField is aim to submit multiple IDs from a form
(maybe you have you special consideration here?). If this is the case,
$this->Categories->add need to change to $this->Categories-

*/
}