TrainingHolder_Controller

Complexity

Total Complexity

7

Size/Duplication

Total Lines	44
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
C	MonthlyCourses()	0	36	7

<?php

File has mixed line endings; this may cause incorrect results

class TrainingHolder extends Page

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $icon = "mysite/images/treeicons/TrainingHolder";

The property $icon is not used and could be removed.

    //parents and children in sitetree
    private static $allowed_children = array("TrainingPage"); //can also be "none";

The property $allowed_children is not used and could be removed.

    private static $default_child = "TrainingPage";

The property $default_child is not used and could be removed.

    public function canCreate($member = null)
    {
        return TrainingHolder::get()->count() ? false: true;
    }

    public function canDelete($member = null)
    {
        return false;
    }

    public function getCMSFields()

The return type could not be reliably inferred; please add a @return annotation.

    {
        $fields = parent::getCMSFields();
        return $fields;
    }
}

class TrainingHolder_Controller extends Page_Controller

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    /**
     *
     * @return ArrayList
     */
    public function MonthlyCourses()
    {
        $results = new ArrayList();

        $stage = Versioned::current_stage();
        $suffix = (!$stage || $stage == 'Stage') ? "" : "_$stage";

        $sqlResults = DB::query("

			SELECT DISTINCT MONTH(\"Date\") AS \"Month\", YEAR(\"Date\") AS \"Year\"

			FROM \"SiteTree$suffix\" NATURAL JOIN \"TrainingPage$suffix\"

			WHERE \"ParentID\" = ".$this->ID." AND \"Date\" > CONVERT_TZ(now(),'+00:00','+13:00')

			ORDER BY \"Year\" DESC, \"Month\" ASC;"
        );

        if ($sqlResults) {
            foreach ($sqlResults as $sqlResult) {
                $month = (isset($sqlResult['Month'])) ? (int) $sqlResult['Month'] : 1;
                $year = ($sqlResult['Year']) ? (int) $sqlResult['Year'] : date('Y');

                $date = DBField::create_field('Date', array(
                'Day' => 1,
                'Month' => $month,
                'Year' => $year
            ));


                $results->push(new ArrayData(array(
                'Date' => $date,
                'Courses' => TrainingPage::get()
                    ->filter(array("ShowInMenus" => 1))
                    ->where(" MONTH(\"TrainingPage\".\"Date\") = $month AND YEAR(\"TrainingPage\".\"Date\") = $year")
            )));
            }
        }
        return $results;
    }
}