TestMailerToFile

Complexity

Total Complexity

6

Size/Duplication

Total Lines	68
Duplicated Lines	47.06 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	sendPlain()	15	20	2
A	sendHTML()	17	22	2
A	writeToFile()	0	8	2

<?php

File has mixed line endings; this may cause incorrect results

/**
 *@author nicolaas [at] sunnysideup.co.nz
 * @package sapphire
 * @subpackage email
 */

class TestMailerToFile extends Mailer

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $show_all_details = false;

The property $show_all_details is not used and could be removed.

    private static $file_to_write_to = "assets/emails.txt";

    private static $separation_string = "

-------------------------------------------------------------------------------------------------------------------------------------";

    /**
     * Send a plain-text email
     */
    public function sendPlain($to, $from, $subject, $plainContent, $attachedFiles = false, $customheaders = false)
    {
        if ($this->Config()->get("show_all_details")) {

This code seems to be duplicated across your project.

            $string = "

~TO: $to ~

~FROM: $from ~

~SUBJECT: $subject ~

~PLAINTEXT: $plainContent ~

~ATTACHEDFILES: ".print_r($attachedFiles, 1)." ~

~CUSTOMHEADERS: ".print_r($customheaders, 1)." ~";
        } else {
            $string = "

~PLAINTEXT: TRUE

~TO: $to ~

~FROM: $from ~

~SUBJECT: $subject ~";
        }
        $this->writeToFile($string);
        return true;
    }

    /**
     * Send a multi-part HTML email
     */
    public function sendHTML($to, $from, $subject, $htmlContent, $attachedFiles = false, $customheaders = false, $plainContent = false, $inlineImages = false)
    {
        if ($this->Config()->get("show_all_details")) {

This code seems to be duplicated across your project.

            $string = "

~TO: $to ~

~FROM: $from ~

~SUBJECT: $subject ~

~HTMLCONTENT: $htmlContent ~

~ATTACHEDFILES: ".print_r($attachedFiles, 1)." ~

~CUSTOMHEADERS: ".print_r($customheaders, 1)." ~

~PLAINTEXT: $plainContent ~

~INLINEIMAGES: $inlineImages ~";
        } else {
            $string = "

~PLAINTEXT: FALSE

~TO: $to ~

~FROM: $from ~

~SUBJECT: $subject ~";
        }
        $this->writeToFile($string);
        return true;
    }

    protected function writeToFile($string)
    {
        $myFile = Director::baseFolder()."/".self::$file_to_write_to;
        $fh = fopen($myFile, 'a') or die("can't open file $myFile");

The method writeToFile() contains an exit expression.

Using logical operators such as or instead of || is generally not recommended.

        $stringData = self::$separation_string.$string;
        fwrite($fh, $stringData);
        fclose($fh);
    }
}