Conditions | 13 |
Paths | 12 |
Total Lines | 88 |
Code Lines | 34 |
Lines | 0 |
Ratio | 0 % |
Changes | 13 | ||
Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
23 | public function run($request) |
||
24 | { |
||
25 | // <<<<<<< HEAD |
||
26 | // $from = $_GET['from'] ?? 'webmaster@' . Director::host(); |
||
27 | // $to = $_GET['to'] ?? 'support@' . Director::host(); |
||
28 | // $subject = $_GET['subject'] ?? 'testing email'; |
||
29 | // $message = $_GET['message'] ?? 'Message goes here'; |
||
30 | // |
||
31 | // echo ' |
||
32 | // <style> |
||
33 | // input {width: 80vw; max-width: 500px; padding: 5px;} |
||
34 | // </style> |
||
35 | // <form action="" method="get"> |
||
36 | // from: <br/><input name="from" value="' . Convert::raw2att($from) . '" /><br/><br/> |
||
37 | // to: <br/><input name="to" value="' . Convert::raw2att($to) . '" /><br/><br/> |
||
38 | // subject: <br/><input name="subject" value="' . Convert::raw2att($subject) . '" /><br/><br/> |
||
39 | // message: <br/><input name="message" value="' . Convert::raw2att($message) . '" /><br/><br/> |
||
40 | // <input type="submit" /> |
||
41 | // </form> |
||
42 | // <h1>Outcome</h1> |
||
43 | // |
||
44 | // '; |
||
45 | // $outcome = mail($to, $subject, $message); |
||
46 | // echo 'PHP mail sent: ' . ($outcome ? 'YES' : 'NO') . $this->newLine(); |
||
47 | // $email = new Email($from, $to, $subject, $message); |
||
48 | // $outcome = $email->sendPlain(); |
||
49 | // echo 'Silverstripe e-mail sent: ' . ($outcome ? 'YES' : 'NO') . $this->newLine(); |
||
50 | // ======= |
||
51 | /** @var Kernel $kernel */ |
||
52 | $kernel = Injector::inst()->get(Kernel::class); |
||
53 | $kernel->setEnvironment('dev'); |
||
54 | |||
55 | $from = $request->getVar('from') ?: Config::inst()->get(Email::class, 'admin_email'); |
||
|
|||
56 | $to = $request->getVar('to') ?: Config::inst()->get(Email::class, 'admin_email'); |
||
57 | $adminEmail = Config::inst()->get(Email::class, 'admin_email'); |
||
58 | if (is_array($adminEmail)) { |
||
59 | $keys = array_keys($adminEmail); |
||
60 | $adminEmail = array_pop($keys); |
||
61 | } |
||
62 | |||
63 | $from = $request->getVar('from') ?: $adminEmail; |
||
64 | $to = $request->getVar('to') ?: $adminEmail; |
||
65 | $subject = $request->getVar('subject') ?: 'testing email'; |
||
66 | $message = $request->getVar('message') ?: 'Message goes here'; |
||
67 | if (Director::is_cli()) { |
||
68 | echo ' |
||
69 | |||
70 | from: ' . Convert::raw2att($from) . ' |
||
71 | |||
72 | to: ' . Convert::raw2att($to) . ' |
||
73 | |||
74 | subject:' . Convert::raw2att($subject) . '" /><br/><br/> |
||
75 | |||
76 | message: ' . Convert::raw2att($message) . ' |
||
77 | |||
78 | Change values like this: sake dev/tasks/testemail [email protected] [email protected] subject=test message=hello |
||
79 | '; |
||
80 | } else { |
||
81 | echo ' |
||
82 | <style> |
||
83 | input {width: 80vw; max-width: 500px; padding: 5px;} |
||
84 | </style> |
||
85 | <form action="" method="get"> |
||
86 | from: <br/><input name="from" value="' . Convert::raw2att($from) . '" /><br/><br/> |
||
87 | to: <br/><input name="to" value="' . Convert::raw2att($to) . '" /><br/><br/> |
||
88 | subject: <br/><input name="subject" value="' . Convert::raw2att($subject) . '" /><br/><br/> |
||
89 | message: <br/><input name="message" value="' . Convert::raw2att($message) . '" /><br/><br/> |
||
90 | <input type="submit" /> |
||
91 | </form> |
||
92 | '; |
||
93 | } |
||
94 | |||
95 | if ($request->getVar('from')) { |
||
96 | if (Director::is_cli()) { |
||
97 | echo ' |
||
98 | ========================== |
||
99 | Outcome |
||
100 | ========================== |
||
101 | '; |
||
102 | } else { |
||
103 | echo '<h1>Outcome</h1>'; |
||
104 | } |
||
105 | |||
106 | $outcome = mail($to, $subject . ' raw mail', $message); |
||
107 | echo 'PHP mail sent: ' . ($outcome ? 'YES' : 'NO') . $this->newLine(); |
||
108 | $email = new Email($from, $to, $subject . ' silverstripe message', $message); |
||
109 | $outcome = $email->sendPlain(); |
||
110 | echo 'Silverstripe e-mail sent: ' . ($outcome ? 'YES' : 'NO') . $this->newLine(); |
||
111 | } |
||
125 |