ErrorNotifierController

Complexity

Total Complexity

6

Size/Duplication

Total Lines	67
Duplicated Lines	0 %

Coupling/Cohesion

Components	2
Dependencies	11

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
B	Form()	0	39	3
A	senderror()	0	6	1
A	ShowThankYouNote()	0	4	1
A	Link()	0	4	1

<?php

/**
 *@author nicolaas[at]sunnysideup.co.nz
 *
 **/

class ErrorNotifierController extends Controller

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $allowed_actions = array(

Consider using a different property name as you override a private property of the parent class.

The property $allowed_actions is not used and could be removed.

        "senderror" => "ADMIN"
    );

    private static $email_to_send_error_to = '';

The property $email_to_send_error_to is not used and could be removed.

    protected $showThankYouNote = false;

    public function Form()
    {
        if ($this->request->requestVar('_REDIRECT_BACK_URL')) {
            $url = $this->request->requestVar('_REDIRECT_BACK_URL');
        } elseif ($this->request->getHeader('Referer')) {
            $url = $this->request->getHeader('Referer');
        } else {
            $url = Director::baseURL();
        }
        $folder = Folder::find_or_make("ErrorScreenshots");

        $whatDidYouTryDoField = new TextareaField('WhatDidYouTryToDo', 'What did you try to do');
        $whatDidYouTryDoField->setRows(3);

        $whatWentWrongField = new TextareaField('WhatWentWrong', 'What went wrong');
        $whatWentWrongField->setRows(3);

        $screenshotField = new FileField(
            'Screenshot',
            'To take a screenshot press the PRT SCR button on your keyboard, then open MS Word or MS Paint and paste the screenshot. Save the file and then attach (upload) the file here.'
        );
        $screenshotField->setFolderName($folder->Name);

        $form = new Form($this, 'Form',
            new FieldList(
                new TextField('Name'),
                new TextField('Email'),
                new TextField('URL', 'What is the URL of the page the error occured (this is the address shown in the address bar (e.g. http://www.mysite.com/mypage/with/errors/)', $url),
                $whatDidYouTryDoField,
                $whatWentWrongField,
                $screenshotField
            ),
            new FieldList(
                new FormAction('senderror', 'Submit Error')
            ),
            new RequiredFields(array("Email", "Name"))
        );
        return $form;
    }

    public function senderror($data, $form)

The parameter $form is not used and could be removed.

    {
        mail($this->Config()->get("email_to_send_error_to"), "error on ".Director::absoluteURL(), print_r($data, true));

The call to absoluteURL() misses a required argument $url.

        $this->showThankYouNote = true;
        return array();
    }

    public function ShowThankYouNote()
    {
        return $this->showThankYouNote;
    }

    public function Link($action = "")

The parameter $action is not used and could be removed.

    {
        return "/error/report/";
    }
}