W3cValidateApi::validate() - Code Metrics - Inspection of "PSR2" - sunnysideup/silverstripe-templateoverview - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 1b743f...79d769 )

by Nicolaas

created 2019-07-20 17:30 UTC

W3cValidateApi::validate() B

↳ Parent: W3cValidateApi

Complexity

Conditions	5
Paths	4

Size

Total Lines	66
Code Lines	42

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
cc	5
eloc	42
c	1
b	1
f	0
nc	4
nop	0
dl	0
loc	66
rs	8.9368

How to fix Long Method

<?php

namespace Sunnysideup\TemplateOverview\Api;

/*
   Author:	Jamie Telin ([email protected]), currently at employed Zebramedia.se

   Scriptname: W3C Validation Api v1.0 (W3C Markup Validation Service)

*/

class W3cValidateApi
{
    private $baseURL = 'http://validator.w3.org/check';

    private $output = 'soap12';

    private $uri = '';

    private $fragment = '';

    private $postVars = [];

    private $validResult = false;

    private $errorCount = 0;

    private $showErrors = true;

    private $errorList = [];

    public function W3Validate($uri = '', $fragment = '')
    {
        if ($uri) {
            $this->setUri($uri);
        } elseif ($fragment) {
            $this->setFragment($fragment);
        }
        $this->validate();
        if ($this->validResult) {
            $type = 'PASS';
            $color1 = '#00CC00';
        } else {
            $type = 'FAIL';
            $color1 = '#FF3300';
        }
        $errorDescription = '';
        if ($this->errorCount) {
            $errorDescription = ' - ' . $this->errorCount . 'errors: ';
            if ($this->showErrors) {
                if (count($this->errorList)) {
                    $errorDescription .= '<ul style="display: none;"><li>' . implode('</li><li>', $this->errorList) . '</li></ul>';
                }
            } else {
                $errorDescription .= '<a href="' . $this->baseURL . '?uri=' . urlencode($uri) . '">check</a>';
            }
        }

        return '<div style="background:' . $color1 . ';"><a href="#" class="showMoreClick">' . $type . '</a></strong>' . $errorDescription . '</div>';
    }

    private function makePostVars()
    {
        $this->postVars['output'] = $this->output;
        if ($this->fragment) {
            $this->postVars['fragment'] = $this->fragment;
        } elseif ($this->uri) {
            $this->postVars['uri'] = $this->uri;
        }
    }

    private function setUri($uri)
    {
        $this->uri = $uri;
    }

    private function setFragment($fragment)
    {
        $fragment = preg_replace('/\s+/', ' ', $fragment);
        $this->fragment = $fragment;
    }


    private function validate()
    {
        sleep(1);

        $this->makePostVars();

        $user_agent = 'Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; .NET CLR 1.1.4322)';
        $options = [
            CURLOPT_CUSTOMREQUEST => 'POST',        //set request type post or get
            CURLOPT_POST => 1,            //set to GET
            CURLOPT_USERAGENT => $user_agent, //"test from www.sunnysideup.co.nz",//$user_agent, //set user agent
            CURLOPT_COOKIEFILE => 'cookie.txt', //set cookie file
            CURLOPT_COOKIEJAR => 'cookie.txt', //set cookie jar
            CURLOPT_RETURNTRANSFER => true,     // return web page
            CURLOPT_HEADER => false,    // don't return headers
            CURLOPT_FOLLOWLOCATION => true,     // follow redirects
            CURLOPT_ENCODING => '',       // handle all encodings
            CURLOPT_AUTOREFERER => true,     // set referer on redirect
            CURLOPT_CONNECTTIMEOUT => 120,      // timeout on connect
            CURLOPT_TIMEOUT => 120,      // timeout on response
            CURLOPT_MAXREDIRS => 10,       // stop after 10 redirects
            CURLOPT_POSTFIELDS => $this->postVars,
            CURLOPT_URL => $this->baseURL,
        ];
        $httphttpCode = '000';


        // Initialize the curl session
        $ch = curl_init();
        if($ch) {

            curl_setopt_array($ch, $options);
            // Execute the session and capture the response
            $out = curl_exec($ch);

            //$err               = curl_errno( $ch );
            //$errmsg            = curl_error( $ch );
            //$header            = curl_getinfo( $ch );
            $httpCode = curl_getinfo($ch, CURLINFO_HTTP_CODE);
            if ($httpCode === 200) {
                $doc = simplexml_load_string($out);
                $doc->registerXPathNamespace('m', 'http://www.w3.org/2005/10/markup-validator');

                //valid ??
                $nodes = $doc->xpath('//m:markupvalidationresponse/m:validity');
                $this->validResult = strval($nodes[0]) === 'true' ? true : false;

                //error count ??
                $nodes = $doc->xpath('//m:markupvalidationresponse/m:errors/m:errorcount');
                $this->errorCount = strval($nodes[0]);
                //errors
                $nodes = $doc->xpath('//m:markupvalidationresponse/m:errors/m:errorlist/m:error');
                foreach ($nodes as $node) {
                    //line
                    $nodes = $node->xpath('m:line');
                    $line = strval($nodes[0]);
                    //col
                    $nodes = $node->xpath('m:col');
                    $col = strval($nodes[0]);
                    //message
                    $nodes = $node->xpath('m:message');
                    $message = strval($nodes[0]);
                    $this->errorList[] = $message . "(${line},${col})";
                }
            }
        }

        return $httpCode;

    }
}


1			<?php
2
3			namespace Sunnysideup\TemplateOverview\Api;
4
5			/*
6			Author: Jamie Telin ([email protected]), currently at employed Zebramedia.se
7
8			Scriptname: W3C Validation Api v1.0 (W3C Markup Validation Service)
9
10			*/
11
12			class W3cValidateApi
13			{
14			private $baseURL = 'http://validator.w3.org/check';
15
16			private $output = 'soap12';
17
18			private $uri = '';
19
20			private $fragment = '';
21
22			private $postVars = [];
23
24			private $validResult = false;
25
26			private $errorCount = 0;
27
28			private $showErrors = true;
29
30			private $errorList = [];
31
32			public function W3Validate($uri = '', $fragment = '')
33			{
34			if ($uri) {
35			$this->setUri($uri);
36			} elseif ($fragment) {
37			$this->setFragment($fragment);
38			}
39			$this->validate();
40			if ($this->validResult) {
41			$type = 'PASS';
42			$color1 = '#00CC00';
43			} else {
44			$type = 'FAIL';
45			$color1 = '#FF3300';
46			}
47			$errorDescription = '';
48			if ($this->errorCount) {
49			$errorDescription = ' - ' . $this->errorCount . 'errors: ';
50			if ($this->showErrors) {
51			if (count($this->errorList)) {
52			$errorDescription .= '<ul style="display: none;"><li>' . implode('</li><li>', $this->errorList) . '</li></ul>';
53			}
54			} else {
55			$errorDescription .= '<a href="' . $this->baseURL . '?uri=' . urlencode($uri) . '">check</a>';
56			}
57			}
58
59			return '<div style="background:' . $color1 . ';"><a href="#" class="showMoreClick">' . $type . '</a></strong>' . $errorDescription . '</div>';
60			}
61
62			private function makePostVars()
63			{
64			$this->postVars['output'] = $this->output;
65			if ($this->fragment) {
66			$this->postVars['fragment'] = $this->fragment;
67			} elseif ($this->uri) {
68			$this->postVars['uri'] = $this->uri;
69			}
70			}
71
72			private function setUri($uri)
73			{
74			$this->uri = $uri;
75			}
76
77			private function setFragment($fragment)
78			{
79			$fragment = preg_replace('/\s+/', ' ', $fragment);
80			$this->fragment = $fragment;
81			}
82
83
84			private function validate()
85			{
86			sleep(1);
87
88			$this->makePostVars();
89
90			$user_agent = 'Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; .NET CLR 1.1.4322)';
91			$options = [
92			CURLOPT_CUSTOMREQUEST => 'POST', //set request type post or get
93			CURLOPT_POST => 1, //set to GET
94			CURLOPT_USERAGENT => $user_agent, //"test from www.sunnysideup.co.nz",//$user_agent, //set user agent
95			CURLOPT_COOKIEFILE => 'cookie.txt', //set cookie file
96			CURLOPT_COOKIEJAR => 'cookie.txt', //set cookie jar
97			CURLOPT_RETURNTRANSFER => true, // return web page
98			CURLOPT_HEADER => false, // don't return headers
99			CURLOPT_FOLLOWLOCATION => true, // follow redirects
100			CURLOPT_ENCODING => '', // handle all encodings
101			CURLOPT_AUTOREFERER => true, // set referer on redirect
102			CURLOPT_CONNECTTIMEOUT => 120, // timeout on connect
103			CURLOPT_TIMEOUT => 120, // timeout on response
104			CURLOPT_MAXREDIRS => 10, // stop after 10 redirects
105			CURLOPT_POSTFIELDS => $this->postVars,
106			CURLOPT_URL => $this->baseURL,
107			];
108			$httphttpCode = '000';
			0 ignored issues – show Unused Code introduced 2019-07-20 17:32 UTC by Report Bug Copy Issue Report The assignment to `$httphttpCode` is dead and can be removed. Loading history...
109
110			// Initialize the curl session
111			$ch = curl_init();
112			if($ch) {
			0 ignored issues – show introduced 2019-07-20 17:32 UTC by Report Bug Copy Issue Report `$ch` is of type `false\|resource`, thus it always evaluated to `false`. Loading history...
113			curl_setopt_array($ch, $options);
114			// Execute the session and capture the response
115			$out = curl_exec($ch);
116
117			//$err = curl_errno( $ch );
118			//$errmsg = curl_error( $ch );
119			//$header = curl_getinfo( $ch );
120			$httpCode = curl_getinfo($ch, CURLINFO_HTTP_CODE);
121			if ($httpCode === 200) {
122			$doc = simplexml_load_string($out);
123			$doc->registerXPathNamespace('m', 'http://www.w3.org/2005/10/markup-validator');
124
125			//valid ??
126			$nodes = $doc->xpath('//m:markupvalidationresponse/m:validity');
127			$this->validResult = strval($nodes[0]) === 'true' ? true : false;
128
129			//error count ??
130			$nodes = $doc->xpath('//m:markupvalidationresponse/m:errors/m:errorcount');
131			$this->errorCount = strval($nodes[0]);
132			//errors
133			$nodes = $doc->xpath('//m:markupvalidationresponse/m:errors/m:errorlist/m:error');
134			foreach ($nodes as $node) {
135			//line
136			$nodes = $node->xpath('m:line');
137			$line = strval($nodes[0]);
138			//col
139			$nodes = $node->xpath('m:col');
140			$col = strval($nodes[0]);
141			//message
142			$nodes = $node->xpath('m:message');
143			$message = strval($nodes[0]);
144			$this->errorList[] = $message . "(${line},${col})";
145			}
146			}
147			}
148
149			return $httpCode;
			0 ignored issues – show Comprehensibility Best Practice introduced 2019-07-20 17:32 UTC by Report Bug Copy Issue Report The variable `$httpCode` does not seem to be defined for all execution paths leading up to this point. Loading history...
150			}
151			}
152

sunnysideup / silverstripe-templateoverview

Push — master ( 1b743f...79d769 )

W3cValidateApi::validate() B

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like