StaffProfilesPage

Complexity

Total Complexity

3

Size/Duplication

Total Lines	54
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	5

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
B	getCMSFields()	0	31	2
A	StaffProfilesAll()	0	4	1

<?php

/**
 *@author nicolaas[at]sunnysideup.co.nz
 *@description: displays a list of staff profiles
 *
 */
class StaffProfilesPage extends Page

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $icon = "mysite/images/treeicons/StaffProfilesPage";

The property $icon is not used and could be removed.

    private static $allowed_children = array("StaffProfilesOnePerson"); //can also be "none";

The property $allowed_children is not used and could be removed.

    private static $default_child = "StaffProfilesOnePerson";

The property $default_child is not used and could be removed.

    private static $db = array(

The property $db is not used and could be removed.

        "DefaultEmail" => "Varchar(255)",
        "SubjectLine" => "Varchar(255)"
    );

    private static $has_many = array(

The property $has_many is not used and could be removed.

        "StaffProfiles" => "StaffProfile"
    );

    public function getCMSFields()

The return type could not be reliably inferred; please add a @return annotation.

    {
        $fields = parent::getCMSFields();
        $fields->addFieldToTab("Root.Profiles", $defaultEmailTextField = new TextField("DefaultEmail"));
        $defaultEmailTextField->setRightTitle(
            _t(
                "StaffProfilesPage.DEFAULT_EMAIL_EXPLANATION",
                "This is the default email that will be used if a staff member does not have a unique email"
            )
        );
        $fields->addFieldToTab("Root.Profiles", $subjectLineTextField = new TextField("SubjectLine"));
        $subjectLineTextField->setRightTitle(
            _t(
                "StaffProfilesPage.SUBJECT_LINE_EXPLANATION",
                "Subject line for email, you can use [". implode("], [", array_keys(Config::inst()->get("StaffProfile", "subject_place_holders"))). "]" . " as placeholders"
            )
        );
        $fields->addFieldToTab(
            "Root.Profiles",
            new GridField(
                "StaffProfiles",
                "Staff Profiles",
                StaffProfile::get(),
                $config = GridFieldConfig_RelationEditor::create()
            )
        );
        if (class_exists("GridFieldSortableRows")) {
            $config->addComponent(new GridFieldSortableRows('Sort'));
        }
        return $fields;
    }

    public function StaffProfilesAll()

The return type could not be reliably inferred; please add a @return annotation.

    {
        return $this->StaffProfiles();
    }
}

class StaffProfilesPage_Controller extends Page_Controller

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    public function init()
    {
        parent::init();
        Requirements::themedCSS("StaffProfilesPage", "staffprofiles");
    }
}