EmailAuthenticator

Complexity

Total Complexity

3

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	get_login_form()	0	4	1
A	authenticate()	0	4	1
A	get_default_authenticator()	0	4	1

<?php
/**
 * Authenticator for the default "member" method
 *
 * @author Markus Lanthaler <markus@silverstripe.com>
 * @package sapphire
 * @subpackage security
 */
class EmailAuthenticator extends MemberAuthenticator

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $authenticators = array('EmailAuthenticator');

Consider using a different property name as you override a private property of the parent class.

The property $authenticators is not used and could be removed.

    private static $default_authenticator = 'EmailAuthenticator';

Consider using a different property name as you override a private property of the parent class.

The property $default_authenticator is not used and could be removed.

    /**
     * Method that creates the login form for this authentication method
     *
     * @param Controller The parent controller, necessary to create the

Should the type for parameter $controller not be Controller?

     *                   appropriate form action tag
     * @return Form Returns the login form to use with this authentication
     *              method
     */
    public static function get_login_form(Controller $controller)
    {
        return Object::create("EmailLoginForm", $controller, "LoginForm");
    }


  /**
   * Method to authenticate an user
   *
   * @param array $RAW_data Raw data to authenticate the user
   * @param Form $form Optional: If passed, better error messages can be

Should the type for parameter $form not be null|Form?

   *                             produced by using
   *                             {@link Form::sessionMessage()}
   * @return bool|Member Returns FALSE if authentication fails, otherwise

Should the return type not be false|DataObject?

   *                     the member object
   */
    public static function authenticate($RAW_data, Form $form = null)
    {
        return parent::authenticate($RAW_data, $form);
    }

  /**
   * @return string
   */
  public static function get_default_authenticator()
  {
      return "EmailAuthenticator";
  }
}