Issues in SmartChimpSignupPage.php (master) - Issues in master - sunnysideup/silverstripe-smartchimp - Measure and Improve Code Quality continuously with Scrutinizer

Issues (56)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

code/SmartChimpSignupPage.php (37 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

class SmartChimpSignupPage extends Page
namespace YourVendor;

class YourClass { }
{
    public static $icon = "smartchimp/images/treeicons/SmartChimpSignupPage";

    public static $db = array(
        //	@todo:	provide optional dropdown for entering username/password??
        'MCApiKey' => 'Varchar(50)',    //	api_key
        'MCListKey' => 'Varchar(50)',    //	list_unique_id
        'MCSuccessContent'    => 'HTMLText',
        "DoubleOptin" => "Boolean",
        "SendWelcomeMail" => "Boolean",
        "SendGoodbey" => "Boolean",
        "SendDeleteNotification" => "Boolean",
        "IsDefaultList" => "Boolean",
        "FirstFieldRequired" => "Boolean",
        "LastFieldRequired" => "Boolean"
    );

    public static $has_many = array(
        "SmartChimpNewsletters" => "SmartChimpNewsletter"
    );

    public static $defaults = array(
        "DoubleOptin" => 1,
        "SendWelcomeMail" => 0,
        "SendGoodbey" => 0,
        "IsDefaultList" => 1
    );

    public static $mc_api_version = '1.2.1';

    protected static $api = null;

    public function getAPI()
    {
        if ($this->MCApiKey && $this->MCListKey) {
            if (!(self::$api instanceof MCAPI)) {
if ($x instanceof DoesNotExist) {
    // Do something.
}
                require_once(Director::baseFolder().'/smartchimp/thirdparty/mcapi/'.self::$mc_api_version.'/MCAPI.class.php');
                self::$api = new MCAPI("$this->MCApiKey");
            }
            return self::$api;
        }
    }


    public function getCMSFields()

    {
        $fields = parent::getCMSFields();

        $fields->addFieldsToTab('Root.Content.SentNewsletters', array(
            new LiteralField('HowToRetrieve', '<p>To retrieve sent newsletters, simply save this page or <a href="'.$this->Link("update").'?flush=1">click here</a>.</p>'),
            $this->SmartChimpNewslettersTable()
        ));
        $fields->addFieldsToTab('Root.Content.MailChimpConfig', array(
            new CheckboxField('IsDefaultList', 'This is the default newsletter'),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            new TextField('MCApiKey', _t('SmartChimp.MCAPIKEY', 'API Key')),
            new TextField('MCListKey', _t('SmartChimp.MCLISTKEY', 'Unique ID for List')),
            new HTMLEditorField('MCSuccessContent', _t('SmartChimp.MCSuccessContent', 'Signup Success Content'))
        ));
        $fields->addFieldsToTab('Root.Content.Subscribe', array(
            new CheckboxField('DoubleOptin', "Double Opt-In Process (send email to confirm registration)"),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            new CheckboxField('SendWelcomeMail', "Send Welcome Mail")
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        ));
        $fields->addFieldsToTab('Root.Content.Unsubscribe', array(
            new CheckboxField('SendGoodbey', "Send Goodbey Email"),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            new CheckboxField('SendDeleteNotification', "Send notification of unsubscribe")
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        ));
        $fields->addFieldsToTab("Root.Content.RequiredFields", array(
            new CheckboxField('FirstRequired', "First name is required"),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            new CheckboxField('LastRequired', "Last name is required")
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        ));
        $this->extend('updateSmartChimpCMSFields');

        return $fields;
    }

    public function SmartChimpNewslettersTable()
    {
        $table = new HasManyComplexTableField(
            $controller = $this,
            $name = "SmartChimpNewsletters",
            $sourceClass = "SmartChimpNewsletter",
            $fieldList = null,
            $detailFormFields = null,
            $sourceFilter = "ParentID = ".$this->ID
        );
        $table->setPageSize(100);
        $table->setPermissions(array('export', 'show', 'edit', 'delete'));
        return $table;
    }

    public function SmartChimpNewslettersShow()
    {
        return DataObject::get("SmartChimpNewsletter", "\"ParentID\" = ".$this->ID." AND \"Hide\" <> 1");
    }

    public function RetrieveCampaigns()
    {
        $dos = new DataObjectSet();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        SmartChimpNewsletter::clean_up_characters();
        $api = $this->getAPI();
        if ($api && $this->ID) {
            $campaignArray = $api->campaigns(array("list_id" => $this->MCListKey));
            if (is_array($campaignArray) && count($campaignArray)) {
                foreach ($campaignArray as $key => $campaign) {
                    if ($campaign["status"] == "sent") {
                        $obj = DataObject::get_one("SmartChimpNewsletter", "`ParentID` = ".$this->ID." AND `CampaignID` = '".$campaign["id"]."'");
                        if ($obj) {
if (rand(1, 6) > 3) {
//print "Check failed";
} else {
    print "Check succeeded";
}
                            //do nothing
                        } else {
                            $content =  $api->campaignContent($campaign["id"]);
                            if ($content) {
                                $obj = new SmartChimpNewsletter();
                                $obj->ParentID = $this->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                                $obj->Date = $campaign["send_time"];//
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                                $obj->Title = $campaign["title"];//
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                                $obj->Subject = $campaign["subject"];//
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                                $obj->PermaLink = $campaign["archive_url"];//
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                                $obj->CampaignID = $campaign["id"];//
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                                $obj->WebID = $campaign["web_id"];//
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                                $obj->Status = $campaign["status"];//should be sent!
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                                //$obj->TextContent = $content["text"] ;//html

                                //$obj->HTMLContent = $content["html"];//text

                            } else {
                                user_error(" could not retrieve content for newsletter with subject: ".$campaign["subject"]." AND ID".$campaign["id"], E_USER_NOTICE);
                            }
                            $obj->write();
                        }
                    }
                }
            }
        }
    }


    public function subscribe($email, $firstname, $lastname)

    {
        $api = $this->getAPI();
        if ($api) {
            $mergeVars = array(
                'FNAME'    => $firstname,
                'LNAME'    => $lastname
            );
            //NOTE: update existing is set to false to not accidentally resubscribe someone.
            if (true === $api->listSubscribe($id = $this->MCListKey, $email, $mergeVars, $email_type='html', $this->DoubleOptin, $update_existing=false, $replace_interests=true, $this->SendWelcomeMail)) {
                return true;
            } else {
                return $api->errorMessage;
            }
        }
    }

    public function unsubscribe($email)

    {
        $api = $this->getAPI();
        if ($api) {
            if (true === $api->listUnsubscribe($id = $this->MCListKey, $email, $delete_member=false, $this->SendGoodbey, $this->SendDeleteNotification)) {
                return true;
            } else {
                return $api->errorMessage;
            }
        }
    }

    public function onBeforeWrite()
    {
        parent::onBeforeWrite();
        if ($this->IsDefaultList && $this->ID) {
            $others = DataObject::get("SmartChimpSignupPage", "`SmartChimpSignupPage`.`ID` <> ".intval($this->ID)." AND `SmartChimpSignupPage`.`IsDefaultList` = 1");
            if ($others) {
                foreach ($others as $other) {
                    $other->IsDefaultList = 0;
                    $other->writeToStage('Stage');
                    $other->publish('Stage', 'Live');
                }
            }
        }
    }

    public function onAfterWrite()
    {
        parent::onAfterWrite();
        $this->RetrieveCampaigns();
    }



    public function requireDefaultRecords()
    {
        parent::requireDefaultRecords();
        $pages = DataObject::get("SmartChimpSignupPage");
        if ($pages) {
            if ($pages->count() == 1) {
                foreach ($pages as $page) {
                    if (!$page->IsDefaultList) {
                        $page->IsDefaultList = 1;
                        $page->writeToStage('Stage');
                        $page->publish('Stage', 'Live');
                        Database::alteration_message($page->ClassName.' created/updated: added IsDefaultList = true setting as there is only one SmartChimpSignupPage', 'edited');
                    }
                }
            }
        }
    }
}


class SmartChimpSignupPage_Controller extends Page_Controller
namespace YourVendor;

class YourClass { }
{
    public static $allowed_actions = array("Form", "update");

    public function init()
    {
        parent::init();
    }


    public function update()
    {
        $this->RetrieveCampaigns();
        return array();
    }

    public function Form()
    {
        if (Session::get('SmartChimp.SUCCESS')) {
            Session::clear('SmartChimp.SUCCESS');
            return false;
        }
        $requiredFields = new RequiredFields('email');
        if ($this->FirstFieldRequired) {
            $requiredFields->appendRequiredFields(array('fname'));
        }
        if ($this->LastFieldRequired) {
            $requiredFields->appendRequiredFields(array('lname'));
        }
        $form = new Form($this, 'Form',
            new FieldSet(
                new TextField('fname', 'First name'),
                new TextField('lname', 'Last name'),
                new TextField('email', 'Email address')
            ),
            new FieldSet(
                new FormAction('SignupAction', 'Sign up')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ),
            $requiredFields
        );
        $this->extend('updateSmartChimpForm', $form);
        return $form;
    }

    public function ShortForm()
    {
        if (Session::get('SmartChimp.SUCCESS')) {
            Session::clear('SmartChimp.SUCCESS');
            return false;
        }
        $form = new Form($this, 'Form',
            new FieldSet(
                new TextField('email', 'Email Address')
            ),
            new FieldSet(
                new FormAction('SignupAction', 'Sign up')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ),
            new RequiredFields('email')
        );

        $this->extend('updateSmartChimpForm', $form);

        return $form;
    }

    public function mcsuccess()
    {
        if (Session::get('SmartChimp.SUCCESS')) {
            $this->Content = $this->MCSuccessContent;
        }
        return array();
    }

    public function SignupAction($raw_data, $form)
    {
        $data = Convert::raw2sql($raw_data);
        $outcome = $this->subscribe($data['email'], $data['fname'],  $data['lname']);
        if (true === $outcome) {
            Session::set('SmartChimp.SUCCESS', true);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            return $this->mcsuccess();
        } else {
            $form->sessionMessage($outcome, 'warning');
            Director::redirectBack();

        }
    }
}


Issues (56)

Security Analysis not enabled

code/SmartChimpSignupPage.php (37 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Missing dependencies

2. Missing use statement

1			<?php
2
3			class SmartChimpSignupPage extends Page
			0 ignored issues – show Coding Style Compatibility introduced 2017-01-03 01:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
4			{
5			public static $icon = "smartchimp/images/treeicons/SmartChimpSignupPage";
6
7			public static $db = array(
8			// @todo: provide optional dropdown for entering username/password??
9			'MCApiKey' => 'Varchar(50)', // api_key
10			'MCListKey' => 'Varchar(50)', // list_unique_id
11			'MCSuccessContent' => 'HTMLText',
12			"DoubleOptin" => "Boolean",
13			"SendWelcomeMail" => "Boolean",
14			"SendGoodbey" => "Boolean",
15			"SendDeleteNotification" => "Boolean",
16			"IsDefaultList" => "Boolean",
17			"FirstFieldRequired" => "Boolean",
18			"LastFieldRequired" => "Boolean"
19			);
20
21			public static $has_many = array(
22			"SmartChimpNewsletters" => "SmartChimpNewsletter"
23			);
24
25			public static $defaults = array(
26			"DoubleOptin" => 1,
27			"SendWelcomeMail" => 0,
28			"SendGoodbey" => 0,
29			"IsDefaultList" => 1
30			);
31
32			public static $mc_api_version = '1.2.1';
33
34			protected static $api = null;
35
36			public function getAPI()
37			{
38			if ($this->MCApiKey && $this->MCListKey) {
39			if (!(self::$api instanceof MCAPI)) {

sunnysideup / silverstripe-smartchimp

Issues (56)

Security Analysis not enabled

code/SmartChimpSignupPage.php (37 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

1. Missing dependencies

2. Missing use statement

Duplication Side-by-Side

Filter issues like