SmartChimpSignupWidget

Complexity

Total Complexity

3

Size/Duplication

Total Lines	68
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	7

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	Title()	0	4	1
B	getCMSFields()	0	43	2

<?php
/**
 * Shows a widget encouraging users to sign up
 * by months or years.
 *
 * @package blog
 */
class SmartChimpSignupWidget extends Widget

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    public static $db = array(
        'BetterTitle' => 'Varchar',
        'Introduction' => 'Text',
        'TextOnButton' => 'Varchar'
    );
    
    public static $has_one = array(
        "NewsletterSignUpPage" => "SiteTree"
    );
    
    public static $title = 'Sign Up for Newsletter';

    public static $cmsTitle = 'Sign Up for Newsletter';
    
    public static $description = 'Links to newsletter signup';

    public function Title()

The return type could not be reliably inferred; please add a @return annotation.

    {
        return $this->BetterTitle;

The property BetterTitle does not exist on object<SmartChimpSignupWidget>. Since you implemented __get, maybe consider adding a @property annotation.

    }
    
    
    public function getCMSFields()

The return type could not be reliably inferred; please add a @return annotation.

    {
        $objects = DataObject::get("SmartChimpSignupPage");
        $fields = new FieldSet();
        if ($objects) {
            $fields->push(
                new TextField(
                    'BetterTitle',
                    'Title'
                )
            );
            $fields->push(
                new TextAreaField(
                    'Introduction',
                    'Introduction',
                    $row = 5,
                    $cols = 5
                )
            );
            $fields->push(
                new TextField(
                    'TextOnButton',
                    'Text On Button'
                )
            );
            $fields->push(
                new DropdownField(
                    'NewsletterSignUpPageID',
                    'Signup Page',
                    $objects->toDropdownMap()
                )
            );
        } else {
            $fields->push(
                new LiteralField(
                    'NoSmartChimpSignupPage',
                    '<p>Please first create a sign-up page.</p>'
                )
            );
        }
        $this->extend('updateCMSFields', $fields);
        return $fields;
    }
}