SiteTreeCheckboxSetField

Complexity

Total Complexity

14

Size/Duplication

Total Lines	125
Duplicated Lines	13.6 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	setSiteTreeParentID()	0	4	1
A	setSiteTreeParentAndChildClassNames()	0	5	1
A	setClassNamesForItems()	0	10	2
A	addClassNameForItems()	0	4	1
A	getSource()	0	10	2
B	getAllChildrenForSiteTreeParent()	17	17	6

<?php

class SiteTreeCheckboxSetField extends CheckboxSetField

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    /**
     *
     * @var Int
     */
    protected $siteTreeParentID = 0;

    /**
     *
     * @var Array
     */
    protected $arrayOfAllowedIDs = array();

    /**
     *
     * @var array
     */
    protected $classNamesForItems = array("SiteTree");

    /**
     *
     * @var Array
     */
    protected $siteTreeParentAllChildren = array();

    /**
     * Creates a new dropdown field.
     *
     * @param string $name The field name
     * @param string $title The field title
     * @param array $source An map of the dropdown items
     * @param string|array $value You can pass an array of values or a single value like a drop down to be selected
     * @param int $size Optional size of the select element

There is no parameter named $size. Was it maybe removed?

     * @param form The parent form

Should the type for parameter $form not be The|null?

     */
    public function __construct($name, $title = '', $source = array(), $value='', $form=null, $emptyString=null)
    {
        Requirements::css('sitetreeformfields/css/SiteTreeCheckboxSetField.css');
        parent::__construct($name, $title, $source, $value, $form, $emptyString);

It seems like $value defined by parameter $value on line 40 can also be of type array; however, DropdownField::__construct() does only seem to accept string, maybe add an additional type check?

    }

    /**
     *
     * @param Int $id
     */
    public function setSiteTreeParentID($id)
    {
        $this->siteTreeParentID = $id;
    }

    /**
     *
     * @param Int $id
     * @param Int | string $array
     */
    public function setSiteTreeParentAndChildClassNames($id, $array)
    {
        $this->siteTreeParentID = $id;
        $this->setClassNamesForItems($array);
    }

    /**
     *
     * @param Array | str $array
     */
    public function setClassNamesForItems($array)
    {
        unset($this->classNamesForItems);
        if (is_array($array)) {
            $this->classNamesForItems = $array;
        } else {
            $this->classNamesForItems = array($array);
        }
        $this->source = $this->getSource();
    }

    /**
     *
     * @param String $str
     */
    public function addClassNameForItems($str)
    {
        $this->classNamesForItems[] = $str;
    }


    /**
     *
     * @return Array

Should the return type not be array|ArrayAccess?

     */
    public function getSource()
    {
        $source = parent::getSource();
        //debug::log("original source count ".implode($this->classNamesForItems)." ".$this->siteTreeParentID.": ".count($source));

60% of this comment could be valid code. Did you maybe forget this after debugging?

        if ($this->siteTreeParentID) {
            $arrayItems = array();

$arrayItems is not used, you could remove the assignment.

            $source = $this->getAllChildrenForSiteTreeParent($this->siteTreeParentID);
        }
        return $source;
    }

    /**
     * @param Int
     * @return Array
     */
    private function getAllChildrenForSiteTreeParent($parentID)

This method seems to be duplicated in your project.

    {
        $children = SiteTree::get()->filter(array("ParentID" => $parentID));
        if ($children && $children->count()) {
            foreach ($children as $child) {
                foreach ($this->classNamesForItems as $matchingCLassName) {
                    //debug::log("has child");

72% of this comment could be valid code. Did you maybe forget this after debugging?

                    if ($child instanceof $matchingCLassName) {
                        //debug::log("we now have ".count($this->siteTreeParentAllChildren)." children");

63% of this comment could be valid code. Did you maybe forget this after debugging?

                        $this->siteTreeParentAllChildren[$child->ID] = $child->MenuTitle;
                    }
                }
                $this->getAllChildrenForSiteTreeParent($child->ID);
            }
        }
        return $this->siteTreeParentAllChildren;
    }
}