SitemapPageDecorator

Complexity

Total Complexity

6

Size/Duplication

Total Lines	59
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
B	SiteMapPages()	0	24	6

<?php

class SitemapPageDecorator extends SiteTreeExtension

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{

    /**
     * Note, you have to list each class explicitely
     * That is, descendants need to be listed as well
     * as their parents, to exclude them both.
     *
     * Includes override excludes.  If you list includes,
     * then only those pages will be shown.
     * If you dont list includes, then the exclude list will be
     * used and if this is empty all page types will be included.
     *
     * @var Array
     */
    private static $sitemap_classes_to_exclude = array("ErrorPage");

The property $sitemap_classes_to_exclude is not used and could be removed.

    /**
     * Note, you have to list each class explicitely
     * That is, descendants need to be listed as well
     * as their parents, to exclude them both.
     *
     * Includes override excludes.  If you list includes,
     * then only those pages will be shown.
     * If you dont list includes, then the exclude list will be
     * used and if this is empty all page types will be included.
     *
     * @var Array
     */
    private static $sitemap_classes_to_include = array();

The property $sitemap_classes_to_include is not used and could be removed.

    /**
     * @return DataList
     */
    public function SiteMapPages($noParent = false)
    {
        if ($noParent) {
            $parentID = 0;
        } else {
            $parentID = $this->owner->ID;
        }
        $filterArray = array(
            "ParentID" => $parentID,
            "ShowInMenus" => 1,
            "ShowInSearch" => 1
        );
        $excludeArray = array("ClassName" => 'SiteMapPage');
        $inc = Config::inst()->get("SitemapPageDecorator", "sitemap_classes_to_include");
        $exc = Config::inst()->get("SitemapPageDecorator", "sitemap_classes_to_exclude");
        if (is_array($inc) && count($inc)) {
            $filterArray["ClassName"] = $inc;
        } elseif (is_array($exc) && count($exc)) {
            $excludeArray["ClassName"] = $exc;
        }
        return SiteTree::get()
            ->filter($filterArray)
            ->exclude($excludeArray);
    }
}