sunnysideup / silverstripe-site-wide-search

src/Helpers/FindEditableObjects.php

Spacing +8 added lines, -8 removed lines

@@ -213,7 +213,7 @@ 
                     $outcome = null;
                     if ($dataObject->hasMethod($validMethod)) {
                         $outcome = $dataObject->{$validMethod}();
-                    } elseif (! empty($dataObject->{$validMethod})) {
+                    } elseif (!empty($dataObject->{$validMethod})) {
                         $outcome = $dataObject->{$validMethod};
                     }
 
@@ -243,7 +243,7 @@ 
                 continue;
             }
 
-            if (! isset($this->relationTypesCovered[$relType])) {
+            if (!isset($this->relationTypesCovered[$relType])) {
                 $rels = null;
                 if ($dataObject->hasMethod($relationName)) {
                     $rels = $dataObject->{$relationName}();
@@ -251,7 +251,7 @@ 
                     user_error('Relation ' . print_r($relationName, 1) . ' does not exist on ' . $dataObject->ClassName . ' Relations are: ' . print_r($this->getRelations($dataObject), 1), E_USER_NOTICE);
                 }
                 if ($rels) {
-                    if ($rels instanceof DataList && ! $rels instanceof UnsavedRelationList) {
+                    if ($rels instanceof DataList && !$rels instanceof UnsavedRelationList) {
                         $rels = $rels->first();
                     }
                     if ($rels && $rels instanceof DataObject && $rels->exists()) {
@@ -270,7 +270,7 @@ 
 
     protected function getRelations($dataObject): array
     {
-        if (! isset($this->cache['rels'][$dataObject->ClassName])) {
+        if (!isset($this->cache['rels'][$dataObject->ClassName])) {
             $this->cache['rels'][$dataObject->ClassName] = array_merge(
                 Config::inst()->get($dataObject->ClassName, 'belongs_to'),
                 Config::inst()->get($dataObject->ClassName, 'has_one'),
@@ -279,7 +279,7 @@ 
                 Config::inst()->get($dataObject->ClassName, 'many_many')
             );
             foreach ($this->cache['rels'][$dataObject->ClassName] as $key => $value) {
-                if (! (is_string($value) && class_exists($value) && $this->classCanBeIncluded($value))) {
+                if (!(is_string($value) && class_exists($value) && $this->classCanBeIncluded($value))) {
                     unset($this->cache['rels'][$dataObject->ClassName][$key]);
                 }
             }
@@ -290,7 +290,7 @@ 
 
     protected function getValidMethods(string $type): array
     {
-        if (! isset($this->cache['validMethods'][$type])) {
+        if (!isset($this->cache['validMethods'][$type])) {
             $this->cache['validMethods'][$type] = $this->Config()->get($type);
         }
 
@@ -303,10 +303,10 @@ 
     protected function classCanBeIncluded(string $dataObjectClassName): bool
     {
         if (count($this->excludedClasses) > 0) {
-            if (! class_exists($dataObjectClassName)) {
+            if (!class_exists($dataObjectClassName)) {
                 return false;
             }
-            return ! in_array($dataObjectClassName, $this->excludedClasses, true);
+            return !in_array($dataObjectClassName, $this->excludedClasses, true);
         }
         user_error('Please set excludedClasses', E_USER_NOTICE);
         return false;

src/Admin/SearchAdmin.php

Spacing +4 added lines, -4 removed lines

@@ -103,7 +103,7 @@ 
             )->setHeadingLevel(4)
         );
 
-        if (! $this->getRequest()->requestVar('Keywords')) {
+        if (!$this->getRequest()->requestVar('Keywords')) {
             $lastResults = $this->lastSearchResults();
             $resultsTitle = $lastResults instanceof \SilverStripe\ORM\ArrayList ? 'Last Results' : 'Last Edited';
             $this->listHTML = $this->renderWith(self::class . '_Results');
@@ -201,7 +201,7 @@ 
         if ($results->count() === 1) {
             $result = $results->first();
             // files do not re-redirect nicely...
-            if ($result->HasCMSEditLink && $result->CMSEditLink && ! in_array(File::class, ClassInfo::ancestry($result->ClassName), true)) {
+            if ($result->HasCMSEditLink && $result->CMSEditLink && !in_array(File::class, ClassInfo::ancestry($result->ClassName), true)) {
                 // this is a variable, not a method!
                 $this->redirect($result->CMSEditLink);
             }
@@ -216,7 +216,7 @@ 
 
     protected function workOutBoolean(string $fieldName, ?array $data = null, ?bool $default = false): bool
     {
-        return (bool) (isset($data['IsSubmitHiddenField']) ? ! empty($data[$fieldName]) : $default);
+        return (bool) (isset($data['IsSubmitHiddenField']) ? !empty($data[$fieldName]) : $default);
     }
 
     protected function workOutString(string $fieldName, ?array $data = null, ?string $default = ''): string
@@ -248,7 +248,7 @@ 
                 $session->set('QuickSearchType', '');
             }
         }
-        if (! $this->quickSearchType) {
+        if (!$this->quickSearchType) {
             $this->quickSearchType = $this->Config()->get('default_quick_search_type');
         }
         return (string) $this->quickSearchType;

src/Helpers/FindClassesAndFields.php

Spacing +5 added lines, -5 removed lines

@@ -101,7 +101,7 @@ 
 
     public function getAllDataObjects(): array
     {
-        if (! isset($this->cache['AllDataObjects'][$this->baseClass])) {
+        if (!isset($this->cache['AllDataObjects'][$this->baseClass])) {
             $this->cache['AllDataObjects'][$this->baseClass] = array_values(
                 ClassInfo::subclassesFor($this->baseClass, false)
             );
@@ -113,7 +113,7 @@ 
 
     public function getAllValidFields(string $className, ?bool $isQuickSearch = false, ?array $includedFields = [], ?array $includedClassFieldCombos = []): array
     {
-        if (! isset($this->cache['AllValidFields'][$className])) {
+        if (!isset($this->cache['AllValidFields'][$className])) {
             $this->cache['AllValidFields'][$className] = Config::inst()->get($className, 'db') ?? [];
             $this->cache['AllValidFields'][$className] = array_merge(
                 $this->cache['AllValidFields'][$className],
@@ -148,7 +148,7 @@ 
 
     protected function getAllIndexedFields(string $className, array $dbFields): array
     {
-        if (! isset($this->cache['AllIndexedFields'][$className])) {
+        if (!isset($this->cache['AllIndexedFields'][$className])) {
             $this->cache['AllIndexedFields'][$className] = [];
             $indexes = Config::inst()->get($className, 'indexes');
             if (is_array($indexes)) {
@@ -171,7 +171,7 @@ 
                                 }
                             }
                         }
-                    } elseif(isset($dbFields[$key])) {
+                    } elseif (isset($dbFields[$key])) {
                         $this->cache['AllIndexedFields'][$className][$key] = $key;
                     }
                 }
@@ -186,7 +186,7 @@ 
      */
     protected function isValidFieldType(string $type, string $className, string $fieldName): bool
     {
-        if (! isset($this->cache['AllValidFieldTypes'][$type])) {
+        if (!isset($this->cache['AllValidFieldTypes'][$type])) {
             $this->cache['AllValidFieldTypes'][$type] = false;
             $singleton = Injector::inst()->get($className);
             $field = $singleton->dbObject($fieldName);

src/QuickSearches/QuickSearchBaseClass.php

Spacing +1 added lines, -1 removed lines

@@ -70,7 +70,7 @@
             'limited' => 'Quick search (limited search)',
         ];
         $availableSearchClasses = self::available_quick_searches();
-        if (! empty($availableSearchClasses) > 0) {
+        if (!empty($availableSearchClasses) > 0) {
             foreach ($availableSearchClasses as $availableSearchClass) {
                 $singleton = Injector::inst()->get($availableSearchClass);
                 if ($singleton->isEnabled()) {

src/Tasks/SiteWideSearch.php

Spacing +2 added lines, -2 removed lines

@@ -25,12 +25,12 @@
         Environment::increaseMemoryLimitTo(-1);
         $debug = $request->postVar('debug') ? 'checked="checked"' : '';
         $word = $request->requestVar('word');
-        if (! is_string($word)) {
+        if (!is_string($word)) {
             $word = '';
         }
 
         $replace = trim($request->requestVar('replace'));
-        if (! is_string($replace)) {
+        if (!is_string($replace)) {
             $replace = '';
         }
 

src/Api/SearchApi.php

Spacing +11 added lines, -11 removed lines

@@ -170,7 +170,7 @@ 
 
     public function setBypassCanMethods(bool $b): SearchApi
     {
-        if (! Director::is_cli()) {
+        if (!Director::is_cli()) {
             user_error('setBypassCanMethods() is only available in CLI mode. Use with caution as it will bypass all canView() and canEdit() checks.', E_USER_WARNING);
         } else {
             $this->bypassCanMethods = $b;
@@ -300,13 +300,13 @@ 
                     $className = $item->ClassName;
                     $fields = $this->getAllValidFields($className);
                     foreach ($fields as $field) {
-                        if (! $item->{$field} || ! is_string($item->{$field})) {
+                        if (!$item->{$field} || !is_string($item->{$field})) {
                             continue;
                         }
                         if (strpos($item->{$field}, $word) === false) {
                             continue;
                         }
-                        if (! $this->includeFieldTest($className, $field)) {
+                        if (!$this->includeFieldTest($className, $field)) {
                             continue;
                         }
                         if ($type === 'url') {
@@ -364,7 +364,7 @@ 
             $myStage = Versioned::get_stage();
             Versioned::set_stage(Versioned::DRAFT);
             // is it on live and is live the same as draft
-            $canBePublished = $item->isPublished() && ! $item->isModifiedOnDraft();
+            $canBePublished = $item->isPublished() && !$item->isModifiedOnDraft();
             $item->writeToStage(Versioned::DRAFT);
             if ($canBePublished) {
                 $item->publishSingle();
@@ -397,7 +397,7 @@ 
 
         if (count($this->words) > 0) {
             foreach ($this->getAllDataObjects() as $className) {
-                if (! $this->includeClassTest($className)) {
+                if (!$this->includeClassTest($className)) {
                     continue;
                 }
 
@@ -405,7 +405,7 @@ 
                 $fields = $this->getAllValidFields($className);
                 $filterAny = [];
                 foreach ($fields as $field) {
-                    if (! $this->includeFieldTest($className, $field)) {
+                    if (!$this->includeFieldTest($className, $field)) {
                         continue;
                     }
                     $filterAny[$field . ':PartialMatch'] = $this->words;
@@ -454,7 +454,7 @@ 
         $back = $this->config()->get('hours_back_for_recent') ?: 24;
         $limit = $this->Config()->get('limit_per_class_for_recent') ?: 5;
         $threshold = strtotime('-' . $back . ' hours', DBDatetime::now()->getTimestamp());
-        if (! $threshold) {
+        if (!$threshold) {
             $threshold = time() - 86400;
         }
 
@@ -560,7 +560,7 @@ 
         }
         $finder->saveCache();
 
-        if (! empty($this->sortOverride)) {
+        if (!empty($this->sortOverride)) {
             return $list->sort($this->sortOverride);
         } else {
             return $list->sort(['SiteWideSearchSortValue' => 'ASC']);
@@ -590,7 +590,7 @@ 
             $testWords = array_unique($testWords);
             foreach ($testWords as $wordKey => $word) {
                 //match a exact field to full words / one word
-                $fullWords = ! (bool) $wordKey;
+                $fullWords = !(bool) $wordKey;
                 if (false === $done) {
                     $count = 0;
                     foreach ($fieldValues as $fieldValue) {
@@ -708,7 +708,7 @@ 
 
     protected function includeClassTest(string $className): bool
     {
-        if (count($this->includedClassesWithSubClassess) && ! in_array($className, $this->includedClassesWithSubClassess, true)) {
+        if (count($this->includedClassesWithSubClassess) && !in_array($className, $this->includedClassesWithSubClassess, true)) {
             if ($this->debug) {
                 DB::alteration_message(' ... Skipping as not included ' . $className);
             }
@@ -734,7 +734,7 @@ 
         } elseif (count($this->includedFields) > 0) {
             return in_array($field, $this->includedFields, true);
         } elseif (count($this->excludedFields) > 0) {
-            return ! in_array($field, $this->includedFields, true);
+            return !in_array($field, $this->includedFields, true);
         } else {
             return false;
         }