sunnysideup / silverstripe-simple-template-caching

src/Model/ObjectsUpdated.php

<?php

namespace Sunnysideup\SimpleTemplateCaching\Model;

use SilverStripe\Core\Injector\Injector;
use SilverStripe\Forms\ReadonlyField;
use SilverStripe\ORM\DataObject;
use SilverStripe\ORM\DB;

/**
 * A blog category for generalising blog posts.
 *
 * @property string $ClassNameLastEdited
 */
class ObjectsUpdated extends DataObject
{

    public static function classes_edited(?string $myClass = ''): string
    {
        $query = DB::query('
            SELECT "ClassNameLastEdited", COUNT(*) AS "Count"
            FROM "ObjectsUpdated"
            GROUP BY "ClassNameLastEdited"
            ORDER BY "ClassNameLastEdited" ASC
        ');
        foreach ($query as $row) {
            $array[$row['ClassNameLastEdited']] =
                Injector::inst()->get($row['ClassNameLastEdited'])->i18n_singular_name() .
                ' (×' . $row['Count'] . ')';
            if ($myClass && $myClass === $row['ClassNameLastEdited']) {
                return $row['Count'];
            }
        }
        return '<br />' . implode('<br> ', $array);

The variable $array seems to be defined by a foreach iteration on line 26. Are you sure the iterator is never empty, otherwise this variable is not defined?

    }

    /**
     * @var string
     */
    private static $table_name = 'ObjectsUpdated';

    /**
     * @var array
     */
    private static $db = [
        'ClassNameLastEdited' => 'Varchar(255)',
    ];

    private static $default_sort = [
        'ID' => 'DESC',
    ];

    /**
     * @var array
     */
    private static $summary_fields = [
        'LastEdited.Ago' => 'Updated',
        'Title' => 'Record name',
    ];

    /**
     * @var array
     */
    private static $field_labels = [
        'Created' => 'Updated',
        'Title' => 'Human readable name',
    ];

    /**
     * @var array
     */
    private static $casting = [
        'Title' => 'Varchar',
    ];

    public function getTitle(): string
    {
        if (class_exists((string) $this->ClassNameLastEdited)) {
            return Injector::inst()->get($this->ClassNameLastEdited)->i18n_singular_name();
        }

        return 'ERROR: class not found';
    }

    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $fields->removeByName('ClassNameLastEdited');
        $fields->addFieldsToTab(
            'Root.Main',
            [
                ReadonlyField::create('Created', 'Recorded'),
                ReadonlyField::create('Title', 'Title', $this->getTitle())
                    ->setDescription('Included ' . self::classes_edited($this->ClassNameLastEdited) . '× in the list.'),
            ]
        );
        return $fields;
    }
}