sunnysideup /
silverstripe-simple-template-caching
| Conditions | 18 |
| Paths | 34 |
| Total Lines | 63 |
| Code Lines | 39 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 5 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 23 | public function onBeforeInit() |
||
| 24 | { |
||
| 25 | //make sure that caching is always https |
||
| 26 | $controller = $this->getOwner(); |
||
| 27 | /** PageController|ControllerExtension $controller */ |
||
| 28 | if ($controller instanceof PageController) { |
||
| 29 | $dataRecord = $controller->data(); |
||
| 30 | if (empty($dataRecord) || !$dataRecord instanceof Page) { |
||
| 31 | return $this->returnNoCache(); |
||
| 32 | } |
||
| 33 | if ($dataRecord->PageCanBeCachedEntirely() !== true) { |
||
| 34 | return $this->returnNoCache(); |
||
| 35 | } |
||
| 36 | if (Security::getCurrentUser()) { |
||
| 37 | return $this->returnNoCache(); |
||
| 38 | } |
||
| 39 | if (Versioned::get_reading_mode() !== 'Stage.Live') { |
||
| 40 | return $this->returnNoCache(); |
||
| 41 | } |
||
| 42 | if (!Director::isLive()) { |
||
| 43 | return $this->returnNoCache(); |
||
| 44 | } |
||
| 45 | |||
| 46 | // exclude special situations... |
||
| 47 | $request = $controller->getRequest(); |
||
| 48 | if ($controller->hasMethod('cacheControlExcludedActions')) { |
||
| 49 | $excludeActions = $controller->cacheControlExcludedActions(); |
||
| 50 | $action = strtolower($request->param('Action')); |
||
| 51 | if ($action) { |
||
| 52 | if (in_array($action, $excludeActions)) { |
||
| 53 | return $this->returnNoCache(); |
||
| 54 | } |
||
| 55 | } |
||
| 56 | } |
||
| 57 | if ($request->isAjax()) { |
||
| 58 | return $this->returnNoCache(); |
||
| 59 | } |
||
| 60 | if ($request->getVar('flush')) { |
||
| 61 | return $this->returnNoCache(); |
||
| 62 | } |
||
| 63 | if ($request->requestVars()) { |
||
| 64 | return $this->returnNoCache(); |
||
| 65 | } |
||
| 66 | if ($request->isGET() !== true) { |
||
| 67 | return $this->returnNoCache(); |
||
| 68 | } |
||
| 69 | if ($controller->hasMethod('canCachePage')) { |
||
| 70 | $canCachePage = $controller->canCachePage(); |
||
| 71 | if ($canCachePage !== true) { |
||
| 72 | return $this->returnNoCache(); |
||
| 73 | } |
||
| 74 | } |
||
| 75 | $cacheTime = $dataRecord->PageCanBeCachedEntirelyDuration(); |
||
| 76 | if ($cacheTime > 0) { |
||
| 77 | return HTTPCacheControlMiddleware::singleton() |
||
| 78 | ->enableCache() |
||
| 79 | ->setMaxAge($cacheTime) |
||
| 80 | ->publicCache(true) |
||
| 81 | ; |
||
| 82 | } |
||
| 83 | } |
||
| 84 | |||
| 85 | return null; |
||
| 86 | } |
||
| 96 |
Loading history...
The issue could also be caused by a filter entry in the build configuration. If the path has been excluded in your configuration, e.g.
excluded_paths: ["lib/*"], you can move it to the dependency path list as follows:For further information see https://scrutinizer-ci.com/docs/tools/php/php-scrutinizer/#list-dependency-paths