sunnysideup / silverstripe-sharethis

code/control/RemoveFacebookItemController.php

<?php

namespace SunnysideUp\ShareThis;

use SilverStripe\Core\Config\Config;
use SilverStripe\Core\Convert;
use SunnysideUp\ShareThis\FacebookFeed_Item;
use SilverStripe\Control\Controller;

/**
 * RemoveFacebookItemController
 */
class RemoveFacebookItemController extends Controller
{
    /**
     * @var array
     */
    private static $allowed_actions = [

The private property $allowed_actions is not used, and could be removed.

        'remove' => 'ADMIN'
    ];

    /**
     * @var string
     */
    private static $url_segment = 'removefacebooklink';

The private property $url_segment is not used, and could be removed.

    /**
     * Link
     *
     * @return  string
     */
    public function Link($action = null)
    {
        $urlSegment = Config::inst()->get(RemoveFacebookItemController::class, 'url_segment');
        return '/'.$urlSegment.'/'.$action;
    }

    /**
     * remove
     *
     * @return void
     */
    public function remove($request)
    {
        $uid = Convert::raw2sql($request->param('ID'));
        $item = FacebookFeed_Item::get()->filter(array("UID" => $uid))->first();
        if ($item) {

$item is of type SilverStripe\ORM\DataObject, thus it always evaluated to true.

            $item->Hide = true;
            $item->write();
            $this->redirect('/?flush=all');
        }
    }
}