FacebookFeed_Page::Fetch() - Code Metrics - Inspection of "upgrade/ss4: updated the share-this module to be f..." - sunnysideup/silverstripe-sharethis - Measure and Improve Code Quality continuously with Scrutinizer

Completed
Pull Request — master (#9)

unknown
created 2018-11-02 02:00 UTC
FacebookFeed_Page::Fetch() D

↳ Parent: FacebookFeed_Page
Complexity

Conditions	18
Paths	16
Size

Total Lines
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
cc	18
nc	16
nop	1
dl	0
loc	64
rs	4.8666
c	0
b	0
f	0
How to fix Long Method Complexity

<?php

namespace SunnysideUp\ShareThis;

use SilverStripe\Forms\TreeMultiSelectField;
use SunnysideUp\ShareThis\FacebookFeed_Item;
use SilverStripe\CMS\Model\SiteTree;
use SilverStripe\Security\Permission;
use SilverStripe\Forms\LiteralField;
use SilverStripe\ORM\DB;
use SunnysideUp\ShareThis\SilverstripeFacebookConnector;
use SilverStripe\ORM\DataObject;

/**
 * FROM: http://www.acornartwork.com/blog/2010/04/19/tutorial-facebook-rss-feed-parser-in-pure-php/
 * EXAMPLE:
 *		//Run the function with the url and a number as arguments
 *		$fb = new TheFaceBook_communicator();
 *		$dos = $fb->fetchFBFeed('http://facebook.com/feeds/status.php?id=xxxxxx&viewer=xxxxxx&key=xxxxx&format=rss20', 3);
 *		//Print Facebook status updates
 *		echo '<ul class="fb-updates">';
 *			 foreach ($dos as $do) {
 *					echo '<li>';
 *					echo '<span class="update">' .$do->Description. '</span>';
 *					echo '<span class="date">' .$do->Date. '</span>';
 *					echo '<span class="link"><a href="' .$do->Link. '">more</a></span>';
 *					echo '</li>';
 *			 }
 *		echo '</ul>';
 *
 *  SEE README on getting facebook URL for RSS Feed.
 *
 *
 **/
class FacebookFeed_Page extends DataObject
{
    /**
     * @var string
     */
    private static $table_name = 'FacebookFeed_Page';


    /**
     * @var array
     */
    private static $db = [

        "Title" => "Varchar(244)",
        'FacebookPageID' => 'Varchar(40)'
    ];

    /**
     * @var array
     */
    private static $has_many = [

        'Items' => FacebookFeed_Item::class
    ];

    /**
     * @var array
     */
    private static $many_many = [

        'Pages' => SiteTree::class
    ];

    /**
     * @return boolean

     */
    public function canCreate($member = null, $context = [])
    {
        return Permission::checkMember($member, 'SOCIAL_MEDIA');
    }

    /**
     * @return boolean

     */
    public function canView($member = null)
    {
        return Permission::checkMember($member, 'SOCIAL_MEDIA');
    }

    /**
     * @return boolean

     */
    public function canEdit($member = null)
    {
        return Permission::checkMember($member, 'SOCIAL_MEDIA');
    }

    /**
     * @return boolean

     */
    public function canDelete($member = null)
    {
        return Permission::checkMember($member, 'SOCIAL_MEDIA');
    }

    /**
     * @return FieldList $fields

     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();

        $fields->addFieldToTab(
            "Root.Main",
            LiteralField::create(
                "HowToFindPageID",
                "<p>
                To find the Facebook Page ID value, you can follow these steps :</p>
                <ol>
                    <li>Open a new tab and open <a href=\"http://www.facebook.com\" target=\"_blank\">facebook</a></li>
                    <li>Find your page (e.g. https://www.facebook.com/EOSAsia)</li>
                    <li>Note the name (e.g. EOSAsia)</li>
                    <li>Go to <a href=\"http://findmyfacebookid.com\" target=\"_blank\">http://findmyfacebookid.com</a></li>
                    <li>Enter http://www.facebook.com/EOSAsia</li>
                    <li>You'll get the answer (e.g. 357864420974239)</li>
                </ol>"
            )
        );

        $fields->addFieldToTab(
            "Root.Pages",
            TreeMultiSelectField::create("Pages", "Show on", SiteTree::class)
        );

        $pages = $this->Pages();
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }

        if ($pages && $pages->count()) {
            $links = [];

            foreach ($pages as $page) {
                $links[] = "<li><a href=\"".$page->Link("updatefb")."\">".$page->Title."</a></li>";
            }

            if (count($links)) {
                $fields->addFieldToTab(
                    "Root.Pages",
                    LiteralField::create(
                        "LinksToCheck",
                        "<p>
                            Choose the links below to view your facebook feed:
                        <ol>
                            ".implode("", $links)."
                        </ol>"
                    )
                );
            }
        }

        return $fields;
    }

    /**
     *
     * @param SiteTree | Int $page - page or page id
     * @param Int $limit
     *
     */
    public static function all_for_one_page($page, $limit = 10)
    {
        if ($page instanceof SiteTree) {
            $pageID = $page->ID;
        } else {
            $pageID = $page;
        }

        $feedIDs = [];

        $sql = "
            SELECT \"FacebookFeed_Page_Pages\".\"FacebookFeed_PageID\"
            FROM \"FacebookFeed_Page_Pages\"
            WHERE \"FacebookFeed_Page_Pages\".\"SiteTreeID\" = $pageID";

        $rows = DB::query($sql);

        if ($rows) {
            foreach ($rows as $row) {
                $feedIDs[$row["FacebookFeed_PageID"]] = $row["FacebookFeed_PageID"];
            }
        }

        if (count($feedIDs)) {
            return FacebookFeed_Item::get()->filter(
                [
                    "FacebookFeed_PageID" => $feedIDs,
                    "Hide" => 0
                ]
            )
            ->limit($limit);
        }
    }

    /**
     * ShowableItems
     * @param integer $limit
     */
    public function ShowableItems($limit = 10)
    {
        return $this->getComponents('Items', 'Hide = 0', null, '', $limit);

    }

    /**
     * Fetch
     * @param boolean $verbose
     */
    public function Fetch($verbose = false)
    {
        $count = 0;
        if ($this->FacebookPageID) {
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            $items = SilverstripeFacebookConnector::get_feed($this->FacebookPageID);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

            if ($items) {

                foreach ($items as $item) {
                    $filter = [
                        "UID" => $item["id"]
                    ];

                    if (! FacebookFeed_Item::get()->filter($filter)->first()) {
                        $count++;
                        $message = "";

                        if (isset($item["message"])) {
                            $message = $item["message"];
                        } elseif (isset($item["description"])) {
                            $message = $item["description"];
                        }

                        //Converts UTF-8 into ISO-8859-1 to solve special symbols issues
                        $message = iconv("UTF-8", "ISO-8859-1//TRANSLIT", $message);
                        $message = $this->stripUnsafe($message);

                        //Get status update time
                        $pubDate = strtotime(isset($item["created_time"]) ? $item["created_time"] : "today");

                        //Customize this to your liking
                        $convertedDate = gmdate($timeFormat = 'Y-m-d', $pubDate);

                        //Store values in array
                        $obj = FacebookFeed_Item::create($filter);
                        $obj->Title = (string) (isset($item["name"]) ? $item["name"] : "");
                        $obj->Date = $convertedDate;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                        $obj->Author = (string) (isset($item["from"]["name"]) ? $item["from"]["name"] : "");
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                        $obj->Link = (string) (isset($item["link"]) ? $item["link"] : "");
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                        $obj->PictureLink = (string) (isset($item["full_picture"]) ? $item["full_picture"] : "");
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                        $obj->Description = $message;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                        $obj->FacebookFeed_PageID = $this->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
                        $obj->write();
                    }
                }
            } else {
                if ($verbose) {
                    DB::alteration_message("ERROR: no data returned", "deleted");
                }
            }

            if ($count == 0 && $verbose) {
                DB::alteration_message("Nothing to add.");
            }

        } else {
            if ($verbose) {
                DB::alteration_message("ERROR: no Facebook Page ID provided", "deleted");
            }
        }

        if ($count && $verbose) {
            DB::alteration_message("Added $count items", "created");
        }
    }

    /**
     * stripUnsafe
     * @param  string $string
     *
     * @return string $string
     */
    public function stripUnsafe($string)
    {
        // Unsafe HTML tags that members may abuse
        $unsafe = [
            '/onmouseover="(.*?)"/is',
            '/onclick="(.*?)"/is',
            '/style="(.*?)"/is',
            '/target="(.*?)"/is',
            '/onunload="(.*?)"/is',
            '/rel="(.*?)"/is',
            '/<a(.*?)>/is',
            '/<\/a>/is'
        ];

        $string= preg_replace($unsafe, " ", $string);
        return $string;
    }
}

sunnysideup / silverstripe-sharethis

Pull Request — master (#9)

FacebookFeed_Page::Fetch() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like
