SunnysideUp\ShareThis\ShareThisDataObject

Complexity

Total Complexity

27

Size/Duplication

Total Lines	279
Duplicated Lines	6.45 %

Coupling/Cohesion

Components	1
Dependencies	11

Importance

Changes

0

15 Methods

Rating	Name	Duplication	Size	Complexity
A	providePermissions()	0	4	1
A	canView()	0	4	1
A	canCreate()	0	4	1
A	canEdit()	0	4	1
A	canDelete()	0	4	1
A	IncludeThisIconNice()	0	4	1
A	getIncludeThisIconNice()	0	4	2
A	IncludeThisIconInExtendedListNice()	0	4	1
A	getIncludeThisIconInExtendedListNice()	0	4	2
A	Icon()	0	4	1
A	getIcon()	0	11	2
A	getCMSFields()	0	9	2
A	onAfterWrite()	0	5	1
A	validate()	0	16	2
B	requireDefaultRecords()	18	54	8

<?php

namespace SunnysideUp\ShareThis;

use SilverStripe\Assets\Image;
use SilverStripe\Core\Config\Config;
use SilverStripe\Forms\LiteralField;
use SilverStripe\ORM\DataObject;
use SilverStripe\ORM\DB;
use SilverStripe\ORM\FieldType\DBField;
use SilverStripe\ORM\ValidationResult;
use SilverStripe\Security\Permission;
use SilverStripe\Security\PermissionProvider;
use SunnysideUp\ShareThis\ShareThisOptions;
use SunnysideUp\ShareThis\ShareThisSTE;

/**
 * @author nicolaas[at]sunnysideup.co.nz
 * @description: list of Share This Options that can be shown
 * @todo finish onAfterWrite and delete objects
 */
// class ShareThisDataObject extends DataObject implements PermissionProvider
class ShareThisDataObject extends DataObject
{
    /**
     * @var string
     */
    private static $table_name = 'ShareThisDataObject';

Consider using a different property name as you override a private property of the parent class.

    /**
     * @var array
     */
    private static $permission_framework = [
        "SOCIAL_MEDIA" => [
            'name' => "Social Media Management",
            'category' => "Social Media",
            'help' => 'Edit relationships, links and data of various social media platforms.',
            'sort' => 0
        ]
    ];

    /**
     * @var array
     */
    private static $db = [

Consider using a different property name as you override a private property of the parent class.

        'Title' => 'Varchar(20)',
        'IncludeThisIcon' => 'Boolean',
        'IncludeThisIconInExtendedList' => 'Boolean',
        'Sort' => 'Int'
    ];

    /**
     * @var array
     */
    private static $has_one = [

Consider using a different property name as you override a private property of the parent class.

        'AlternativeIcon' => Image::class
    ];

    /**
     * @var array
     */
    private static $casting = [

Consider using a different property name as you override a private property of the parent class.

        'Icon' => 'HTMLText',
        'IncludeThisIconNice' => 'Varchar',
        'IncludeThisIconInExtendedListNice' => 'IncludeThisIconInExtendedList'
    ];

    /**
     * @var array
     */
    private static $field_labels = [

Consider using a different property name as you override a private property of the parent class.

        'Title' => 'Name',
        'IncludeThisIcon' => 'Include in main list',
        'IncludeThisIconNice' => 'Include in primary list',
        'IncludeThisIconInExtendedList' => 'Include in secondary list',
        'IncludeThisIconInExtendedListNice' => 'Include in secondary list',
        'Sort' => 'Sort Index (lower numbers shown first)',
        'AlternativeIcon' => 'Optional Alternative Icon (can be any size, a 32px by 32px square is recommended)'
    ];

    /**
     * @var array
     */
    private static $summary_fields = [

Consider using a different property name as you override a private property of the parent class.

        'Title' => 'Name',
    ];

    /**
     * @var string
     */
    private static $singular_name = 'Icon to share this page';

Consider using a different property name as you override a private property of the parent class.

    /**
     * @var string
     */
    private static $plural_name = 'Icons to share this page';

Consider using a different property name as you override a private property of the parent class.

    /**
     * @var string
     */
    private static $default_sort = 'IncludeThisIcon DESC, IncludeThisIconInExtendedList ASC, Sort ASC, Title ASC';

Consider using a different property name as you override a private property of the parent class.

    /**
     * @return string
     */
    public function providePermissions()
    {
        return Config::inst()->get(ShareThisDataObject::class, "permission_framework");
    }

    /**
     * @return boolean

Should the return type not be boolean|string?

     */
    public function canView($member = null)
    {
        return Permission::checkMember($member, 'SOCIAL_MEDIA');
    }

    /**
     * @return boolean

Should the return type not be boolean|string?

     */
    public function canCreate($member = null, $context = [])
    {
        return Permission::checkMember($member, 'SOCIAL_MEDIA');
    }

    /**
     * @return boolean

Should the return type not be boolean|string?

     */
    public function canEdit($member = null)
    {
        return Permission::checkMember($member, 'SOCIAL_MEDIA');
    }

    /**
     * @return boolean

Should the return type not be boolean|string?

     */
    public function canDelete($member = null)
    {
        return Permission::checkMember($member, 'SOCIAL_MEDIA');
    }

    /**
     * @return string
     */
    public function IncludeThisIconNice()
    {
        return $this->getIncludeThisIconNice();
    }

    /**
     * @return string
     */
    public function getIncludeThisIconNice()
    {
        return $this->IncludeThisIcon ? "Yes" : "No" ;

The property IncludeThisIcon does not exist on object<SunnysideUp\ShareThis\ShareThisDataObject>. Since you implemented __get, maybe consider adding a @property annotation.

    }

    /**
     * @return string
     */
    public function IncludeThisIconInExtendedListNice()
    {
        return $this->getIncludeThisIconInExtendedListNice();
    }

    /**
     * @return string
     */
    public function getIncludeThisIconInExtendedListNice()
    {
        return $this->IncludeThisIconInExtendedList ? "Yes" : "No" ;

The property IncludeThisIconInExtendedList does not exist on object<SunnysideUp\ShareThis\ShareThisDataObject>. Since you implemented __get, maybe consider adding a @property annotation.

    }

    /**
     * Icon
     */
    public function Icon()
    {
        return $this->getIcon();
    }

    /**
     * Get the icon
     *
     * @return  DBField [<description>]
     */
    public function getIcon()
    {
        $icon = $this->AlternativeIcon();

The method AlternativeIcon does not exist on object<SunnysideUp\ShareThis\ShareThisDataObject>? Since you implemented __call, maybe consider adding a @method annotation.

        if ($icon->exists()) {
            return $icon->ScaleHeight(16);
        }

        $html = '<img src="' . SS_SHARETHIS_DIR . '/images/icons/' . strtolower($this->Title) . ".png\" alt=\"{$this->Title}\"/>";

        return DBField::create_field("HTMLText", $html);
    }

    /**
     * @return FieldList $fields

Should the return type not be \SilverStripe\Forms\FieldList?

     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        if (class_exists("DataObjectSorterDOD")) {
            $fields->addFieldToTab("Root.Sort", LiteralField::create("SortShortList", $this->dataObjectSorterPopupLink("IncludeThisIcon", 1, "<h3>Sort Main Icons</h3>")));

The method dataObjectSorterPopupLink does not exist on object<SunnysideUp\ShareThis\ShareThisDataObject>? Since you implemented __call, maybe consider adding a @method annotation.

        }

        return $fields;
    }

    /**
     * @return void
     */
    public function onAfterWrite()
    {
        parent::onAfterWrite();
        $objects = ShareThisDataObject::get()->filter('Title', $this->Title)->exclude('ID', $this->ID);

$objects is not used, you could remove the assignment.

    }

    /**
     * @return ValidationResult $result
     */
    public function validate()
    {
        $result = parent::validate();
        $bookmarks = ShareThisOptions::get_page_specific_data("", "", "");
        if (!isset($bookmarks[$this->Title])) {
            $result->addError(sprintf(
                _t(
                    'ShareThisDataObject.NON_EXISTING_TITLE',
                    'This social plaform "%s" does not exist.  Please change / delete the this entry.'
                ),
                $this->Title
            ));
        }

        return $result;
    }

    /**
     * Setting default records
     *
     * @return void
     */
    public function requireDefaultRecords()
    {
        parent::requireDefaultRecords();
        $actualArray = ShareThisOptions::get_general_data();
        Config::inst()->update(ShareThisSTE::class, "included_icons", []);

It seems like you code against a concrete implementation and not the interface SilverStripe\Config\Collections\ConfigCollectionInterface as the method update() does only exist in the following implementations of said interface: SilverStripe\Config\Collections\DeltaConfigCollection, SilverStripe\Config\Collections\MemoryConfigCollection.

        Config::inst()->update(ShareThisSTE::class, "excluded_icons", []);

It seems like you code against a concrete implementation and not the interface SilverStripe\Config\Collections\ConfigCollectionInterface as the method update() does only exist in the following implementations of said interface: SilverStripe\Config\Collections\DeltaConfigCollection, SilverStripe\Config\Collections\MemoryConfigCollection.

        ShareThisOptions::set_general_data(null);

The call to ShareThisOptions::set_general_data() has too many arguments starting with null.

        $fullArray = ShareThisOptions::get_general_data();

        foreach ($fullArray as $key) {
            $object = ShareThisDataObject::get()->filter('Title', $key);

            if (!$object->exists()) {
                $object = new ShareThisDataObject();
                $object->Title = $key;
                $style = 'excluded';
                $object->IncludeThisIcon = false;

The property IncludeThisIcon does not exist on object<SunnysideUp\ShareThis\ShareThisDataObject>. Since you implemented __set, maybe consider adding a @property annotation.

                if (in_array($key, $actualArray)) {
                    $object->IncludeThisIcon = true;

The property IncludeThisIcon does not exist on object<SunnysideUp\ShareThis\ShareThisDataObject>. Since you implemented __set, maybe consider adding a @property annotation.

                    $style = 'included';
                }

                $object->write();
                DB::alteration_message("Added Bookmark Icon for $key ($style)", 'created');
            }
        }

        $inc = Config::inst()->get(ShareThisSTE::class, "included_icons");

        foreach ($inc as $key) {

This code seems to be duplicated across your project.

            $object = ShareThisDataObject::get()->filter(['Title' => $key, 'IncludeThisIcon' => 0]);

            if ($object->exists()) {
                $object = $object->first();
                $object->IncludeThisIcon = true;
                $object->write();
                DB::alteration_message("Updated inclusion for $key", 'created');
            }
        }

        $exc = Config::inst()->get(ShareThisSTE::class, "excluded_icons");

        foreach ($exc as $key) {

This code seems to be duplicated across your project.

            $object = ShareThisDataObject::get()->filter(['Title' => $key, 'IncludeThisIcon' => 1]);

            if ($object->exists()) {
                $object = $object->first();
                $object->IncludeThisIcon = false;
                $object->write();
                DB::alteration_message("Updated inclusion for $key", 'created');
            }
        }
    }
}