RecommendedSearchPlusSection

Complexity

Total Complexity

4

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getCMSFields()	0	8	1
A	onBeforeWrite()	0	11	3

<?php
/**
 *@author: nicolaas[at]sunnysideup.co.nz
 *@description:
 * a log history and counted history of searches done (e.g. 100 people searched for "sunshine")
 * it allows gives the opportunity to link zero or more pages to a particular search phrase
 *
 *
 *
 **/

class RecommendedSearchPlusSection extends DataObject

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    private static $db = array(

Consider using a different property name as you override a private property of the parent class.

The property $db is not used and could be removed.

        "Title" => "Varchar(255)",
        "Intro" => "Text",
        "Sort" => "Int"
    );

    private static $has_one = array(

Consider using a different property name as you override a private property of the parent class.

The property $has_one is not used and could be removed.

        "ParentPage" => "Page",
        "Parent" => "SearchPlusPage"
    );

    private static $defaults = array(

Consider using a different property name as you override a private property of the parent class.

The property $defaults is not used and could be removed.

        "Sort" => 100
    );

    private static $singular_name = 'Recommended SearchPlus Section';

Consider using a different property name as you override a private property of the parent class.

The property $singular_name is not used and could be removed.

    private static $plural_name = 'Recommended SearchPlus Sections';

Consider using a different property name as you override a private property of the parent class.

The property $plural_name is not used and could be removed.

    private static $default_sort = 'Sort, Title';

Consider using a different property name as you override a private property of the parent class.

The property $default_sort is not used and could be removed.

    private static $searchable_fields = array(

Consider using a different property name as you override a private property of the parent class.

The property $searchable_fields is not used and could be removed.

        "Title"
    );

    private static $summary_fields = array(

Consider using a different property name as you override a private property of the parent class.

The property $summary_fields is not used and could be removed.

        "Title", "Sort"
    );

    private static $field_labels = array(

Consider using a different property name as you override a private property of the parent class.

The property $field_labels is not used and could be removed.

        "Sort" => "Sort Index"
    );

    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $fields->removeByName("ParentPageID");
        $fields->removeByName("ParentID");
        $fields->addFieldToTab("Root.Main", new TreeDropdownField($name = "ParentPageID", $title = "Parent Page (show all child pages as links for this recommended section)", $sourceObject = "SiteTree"));
        return $fields;
    }

    public function onBeforeWrite()
    {
        parent::onBeforeWrite();
        if (!$this->ParentID) {

The property ParentID does not exist on object<RecommendedSearchPlusSection>. Since you implemented __get, maybe consider adding a @property annotation.

            if ($page = SearchPlusPage::get()->first()) {
                $this->ParentID = $page->ID;

The property ParentID does not exist on object<RecommendedSearchPlusSection>. Since you implemented __set, maybe consider adding a @property annotation.

            } else {
                user_error("Make sure to create a SearchPlusPage", E_USER_NOTICE);
            }
        }
    }
}