SalesForceSignupForm

Complexity

Total Complexity

9

Size/Duplication

Total Lines	99
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	6

Importance

Changes

0

8 Methods

Rating	Name	Duplication	Size	Complexity
A	setFormSubmitText()	0	8	1
A	__construct()	0	14	1
A	getBaseFields()	0	6	1
A	setRequiredFields()	0	5	1
A	getBaseAction()	0	4	1
A	setSigupFields()	0	12	2
A	getBaseRequiredFields()	0	7	1
A	doSalesForceSignUp()	0	4	1

<?php

/**
 * This class can be used by controllers in your project to set up a basic sign up
 * form.
 *
 * You can test it in isolation using the SalesForceExamplesSignupController class.
 */

class SalesForceSignupForm extends Form
{

    private static $allowed_actions = [

The private property $allowed_actions is not used, and could be removed.

        'doSalesForceSignUp' => true
    ];

    private static $based_on_instance_of = 'SalesForceContact';

The private property $based_on_instance_of is not used, and could be removed.

    /**
     * Our constructor only requires the controller and the name of the form
     * method. We'll create the fields and actions in here.
     *
     */
    public function __construct($controller, $name)
    {
        $fields = $this->getBaseFields();

        $actions = $this->getBaseAction();

        $required = $this->getBaseRequiredFields();

Are you sure the assignment to $required is correct as $this->getBaseRequiredFields() targeting SalesForceSignupForm::getBaseRequiredFields() seems to always return null.

        // now we create the actual form with our fields and actions defined
        // within this class
        parent::__construct($controller, $name, $fields, $actions, $required);

        // any modifications we need to make to the form.
        $this->loadDataFrom($_REQUEST);
    }


    public function setSigupFields(array $fieldArray)

The parameter $fieldArray is not used and could be removed.

    {
        $newList = new FieldList();
        $oldFields = $this->Fields();
        foreach($fieldsArray as $field) {

The variable $fieldsArray does not exist. Did you maybe mean $fieldArray?

            $newField = $oldFields->dataFieldByName($field);
            $newList->push($newField);
        }

        $this->setFields($newList);

        return $this;
    }

    public function setRequiredFields(array $fieldArray)
    {
        $this->setRequiredFields(new RequiredFields($fieldArray));

new RequiredFields($fieldArray) of type RequiredFields is incompatible with the type array expected by parameter $fieldArray of SalesForceSignupForm::setRequiredFields().

        return $this;
    }


    public function setFormSubmitText(string $label)
    {
        $newFields = new FieldList(
            FormAction::create('doSalesForceSignUp', $label)
        );
        $this->setActions($newFields);

        return $this;
    }

    protected function getBaseFields()
    {
        $newInstanceClassName = Config::inst()->get('SalesForceSignupForm', 'based_on_instance_of');
        $newInstance = $newInstanceClassName::create();

        return $newInstance->getFrontEndFields();

    }

    protected function getBaseAction()
    {
        return new FieldList(
            FormAction::create('doSalesForceSignUp', 'Register')
        );
    }

    protected function getBaseRequiredFields()
    {
        new RequiredFields(
            [
                'FirstName',
                'LastName',
                'Email',
            ]
        );
    }


    public function doSalesForceSignUp($data, Form $form)

The parameter $form is not used and could be removed.

    {
        MySalesForcePartnerAPI::create_contact($data);
        die('We need the option here to set a redirection link AND/OR provide an AJAX response');

Using exit here is not recommended.

    }


}